net/af_packet: fix for stale sockets
Checks
Commit Message
af_packet driver is leaving stale socket after device is removed.
Ring buffers are memory mapped when device is added using rte_dev_probe.
There is no corresponding munmap call when device is removed/closed.
This commit fixes the issue by calling munmap
from rte_pmd_af_packet_remove().
Bugzilla ID: 339
Cc: stable@dpdk.org
Signed-off-by: Abhishek Sachan <abhishek.sachan@altran.com>
Reviewed-by: John W. Linville <linville@redhat.com>
---
drivers/net/af_packet/rte_eth_af_packet.c | 4 ++++
1 file changed, 4 insertions(+)
Comments
On Thu, Aug 22, 2019 at 11:55:36AM +0530, Abhishek Sachan wrote:
> af_packet driver is leaving stale socket after device is removed.
> Ring buffers are memory mapped when device is added using rte_dev_probe.
> There is no corresponding munmap call when device is removed/closed.
> This commit fixes the issue by calling munmap
> from rte_pmd_af_packet_remove().
>
> Bugzilla ID: 339
> Cc: stable@dpdk.org
>
> Signed-off-by: Abhishek Sachan <abhishek.sachan@altran.com>
> Reviewed-by: John W. Linville <linville@redhat.com>
Confirmed...
Reviewed-by: John W. Linville <linville@redhat.com>
John
On 8/23/2019 4:28 PM, John W. Linville wrote:
> On Thu, Aug 22, 2019 at 11:55:36AM +0530, Abhishek Sachan wrote:
>> af_packet driver is leaving stale socket after device is removed.
>> Ring buffers are memory mapped when device is added using rte_dev_probe.
>> There is no corresponding munmap call when device is removed/closed.
>> This commit fixes the issue by calling munmap
>> from rte_pmd_af_packet_remove().
>>
>> Bugzilla ID: 339
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Abhishek Sachan <abhishek.sachan@altran.com>
>> Reviewed-by: John W. Linville <linville@redhat.com>
>
> Confirmed...
>
> Reviewed-by: John W. Linville <linville@redhat.com>
Applied to dpdk-next-net/master, thanks.
@@ -972,6 +972,7 @@ rte_pmd_af_packet_remove(struct rte_vdev_device *dev)
{
struct rte_eth_dev *eth_dev = NULL;
struct pmd_internals *internals;
+ struct tpacket_req *req;
unsigned q;
PMD_LOG(INFO, "Closing AF_PACKET ethdev on numa socket %u",
@@ -992,7 +993,10 @@ rte_pmd_af_packet_remove(struct rte_vdev_device *dev)
return rte_eth_dev_release_port(eth_dev);
internals = eth_dev->data->dev_private;
+ req = &internals->req;
for (q = 0; q < internals->nb_queues; q++) {
+ munmap(internals->rx_queue[q].map,
+ 2 * req->tp_block_size * req->tp_block_nr);
rte_free(internals->rx_queue[q].rd);
rte_free(internals->tx_queue[q].rd);
}