Message ID | 1431961409-22252-2-git-send-email-helin.zhang@intel.com (mailing list archive) |
---|---|
State | Superseded, archived |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 04C61C344; Mon, 18 May 2015 17:04:45 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id C1F4FC33C for <dev@dpdk.org>; Mon, 18 May 2015 17:04:42 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP; 18 May 2015 08:03:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,453,1427785200"; d="scan'208";a="711918410" Received: from shvmail01.sh.intel.com ([10.239.29.42]) by fmsmga001.fm.intel.com with ESMTP; 18 May 2015 08:03:39 -0700 Received: from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com [10.239.29.89]) by shvmail01.sh.intel.com with ESMTP id t4IF3abu007784; Mon, 18 May 2015 23:03:36 +0800 Received: from shecgisg004.sh.intel.com (localhost [127.0.0.1]) by shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP id t4IF3WPT022293; Mon, 18 May 2015 23:03:34 +0800 Received: (from hzhan75@localhost) by shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id t4IF3Wun022289; Mon, 18 May 2015 23:03:32 +0800 From: Helin Zhang <helin.zhang@intel.com> To: dev@dpdk.org Date: Mon, 18 May 2015 23:03:28 +0800 Message-Id: <1431961409-22252-2-git-send-email-helin.zhang@intel.com> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1431961409-22252-1-git-send-email-helin.zhang@intel.com> References: <1431957127-21395-1-git-send-email-helin.zhang@intel.com> <1431961409-22252-1-git-send-email-helin.zhang@intel.com> Subject: [dpdk-dev] [PATCH v2 1/2] i40e/base: compile fix on ICC 13.0.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Commit Message
Zhang, Helin
May 18, 2015, 3:03 p.m. UTC
Below compile error can be found on ICC 13.0.0, which is a warning
treated as error. Forcedly disabling the warning can fix it.
Error log:
lib/librte_pmd_i40e/i40e/i40e_nvm.c(1022): error #188: enumerated
type mixed with another type
hw->aq.asq_last_status = old_asq_status;
^
Signed-off-by: Helin Zhang <helin.zhang@intel.com>
---
lib/librte_pmd_i40e/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Mon, May 18, 2015 at 11:03:28PM +0800, Helin Zhang wrote: > Below compile error can be found on ICC 13.0.0, which is a warning > treated as error. Forcedly disabling the warning can fix it. > > Error log: > lib/librte_pmd_i40e/i40e/i40e_nvm.c(1022): error #188: enumerated > type mixed with another type > hw->aq.asq_last_status = old_asq_status; > ^ > > Signed-off-by: Helin Zhang <helin.zhang@intel.com> Acked-by: Bruce Richardson <bruce.richardson@intel.com> > --- > lib/librte_pmd_i40e/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/librte_pmd_i40e/Makefile b/lib/librte_pmd_i40e/Makefile > index 22f0716..911e4f5 100644 > --- a/lib/librte_pmd_i40e/Makefile > +++ b/lib/librte_pmd_i40e/Makefile > @@ -48,7 +48,7 @@ LIBABIVER := 1 > # to disable warnings > # > ifeq ($(CC), icc) > -CFLAGS_BASE_DRIVER = -wd593 > +CFLAGS_BASE_DRIVER = -wd593 -wd188 > else ifeq ($(CC), clang) > CFLAGS_BASE_DRIVER += -Wno-sign-compare > CFLAGS_BASE_DRIVER += -Wno-unused-value > -- > 1.8.1.4 >
On Mon, May 18, 2015 at 04:11:06PM +0100, Bruce Richardson wrote: > On Mon, May 18, 2015 at 11:03:28PM +0800, Helin Zhang wrote: > > Below compile error can be found on ICC 13.0.0, which is a warning > > treated as error. Forcedly disabling the warning can fix it. > > > > Error log: > > lib/librte_pmd_i40e/i40e/i40e_nvm.c(1022): error #188: enumerated > > type mixed with another type > > hw->aq.asq_last_status = old_asq_status; > > ^ > > > > Signed-off-by: Helin Zhang <helin.zhang@intel.com> > > Acked-by: Bruce Richardson <bruce.richardson@intel.com> > Fix works, but you probably should reword the title to start with "fix". For future reference, it would also be nice to reference the commit that broke things. > > --- > > lib/librte_pmd_i40e/Makefile | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/lib/librte_pmd_i40e/Makefile b/lib/librte_pmd_i40e/Makefile > > index 22f0716..911e4f5 100644 > > --- a/lib/librte_pmd_i40e/Makefile > > +++ b/lib/librte_pmd_i40e/Makefile > > @@ -48,7 +48,7 @@ LIBABIVER := 1 > > # to disable warnings > > # > > ifeq ($(CC), icc) > > -CFLAGS_BASE_DRIVER = -wd593 > > +CFLAGS_BASE_DRIVER = -wd593 -wd188 > > else ifeq ($(CC), clang) > > CFLAGS_BASE_DRIVER += -Wno-sign-compare > > CFLAGS_BASE_DRIVER += -Wno-unused-value > > -- > > 1.8.1.4 > >
diff --git a/lib/librte_pmd_i40e/Makefile b/lib/librte_pmd_i40e/Makefile index 22f0716..911e4f5 100644 --- a/lib/librte_pmd_i40e/Makefile +++ b/lib/librte_pmd_i40e/Makefile @@ -48,7 +48,7 @@ LIBABIVER := 1 # to disable warnings # ifeq ($(CC), icc) -CFLAGS_BASE_DRIVER = -wd593 +CFLAGS_BASE_DRIVER = -wd593 -wd188 else ifeq ($(CC), clang) CFLAGS_BASE_DRIVER += -Wno-sign-compare CFLAGS_BASE_DRIVER += -Wno-unused-value