[v4,3/3] app/testpmd: add RSS offload types extending support
Checks
Commit Message
This patch adds cmdline support for extended rss types configuration.
Signed-off-by: Simei Su <simei.su@intel.com>
---
app/test-pmd/config.c | 4 ++++
1 file changed, 4 insertions(+)
Comments
Hi Simei,
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Simei Su
> Sent: Friday, September 27, 2019 11:54 AM
> To: qi.z.zhang@intel.com; jingjing.wu@intel.com; xiaolong.ye@intel.com
> Cc: dev@dpdk.org; simei.su@intel.com
> Subject: [dpdk-dev] [PATCH v4 3/3] app/testpmd: add RSS offload types
> extending support
>
> This patch adds cmdline support for extended rss types configuration.
>
> Signed-off-by: Simei Su <simei.su@intel.com>
> ---
> app/test-pmd/config.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
> index 1a5a5c1..a59a69e 100644
> --- a/app/test-pmd/config.c
> +++ b/app/test-pmd/config.c
> @@ -103,6 +103,10 @@
> { "tcp", ETH_RSS_TCP },
> { "sctp", ETH_RSS_SCTP },
> { "tunnel", ETH_RSS_TUNNEL },
> + { "l3-src-only", ETH_RSS_L3_SRC_ONLY },
> + { "l3-dst-only", ETH_RSS_L3_DST_ONLY },
> + { "l4-src-only", ETH_RSS_L4_SRC_ONLY },
> + { "l4-dst-only", ETH_RSS_L4_DST_ONLY },
> { NULL, 0 },
> };
>
You must also add the new flags in app/test-pmd/cmdline.c
So they can be used when creating rte_flow.
Thanks,
Ori Kam
> --
> 1.8.3.1
Hi, Ori Kam,
> -----Original Message-----
> From: Ori Kam [mailto:orika@mellanox.com]
> Sent: Sunday, September 29, 2019 12:49 AM
> To: Su, Simei <simei.su@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>; Wu,
> Jingjing <jingjing.wu@intel.com>; Ye, Xiaolong <xiaolong.ye@intel.com>
> Cc: dev@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH v4 3/3] app/testpmd: add RSS offload types
> extending support
>
> Hi Simei,
>
> > -----Original Message-----
> > From: dev <dev-bounces@dpdk.org> On Behalf Of Simei Su
> > Sent: Friday, September 27, 2019 11:54 AM
> > To: qi.z.zhang@intel.com; jingjing.wu@intel.com; xiaolong.ye@intel.com
> > Cc: dev@dpdk.org; simei.su@intel.com
> > Subject: [dpdk-dev] [PATCH v4 3/3] app/testpmd: add RSS offload types
> > extending support
> >
> > This patch adds cmdline support for extended rss types configuration.
> >
> > Signed-off-by: Simei Su <simei.su@intel.com>
> > ---
> > app/test-pmd/config.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index
> > 1a5a5c1..a59a69e 100644
> > --- a/app/test-pmd/config.c
> > +++ b/app/test-pmd/config.c
> > @@ -103,6 +103,10 @@
> > { "tcp", ETH_RSS_TCP },
> > { "sctp", ETH_RSS_SCTP },
> > { "tunnel", ETH_RSS_TUNNEL },
> > + { "l3-src-only", ETH_RSS_L3_SRC_ONLY },
> > + { "l3-dst-only", ETH_RSS_L3_DST_ONLY },
> > + { "l4-src-only", ETH_RSS_L4_SRC_ONLY },
> > + { "l4-dst-only", ETH_RSS_L4_DST_ONLY },
> > { NULL, 0 },
> > };
> >
>
> You must also add the new flags in app/test-pmd/cmdline.c So they can be used
> when creating rte_flow.
If nothing added in app/test-pmd/cmdline.c, they can also be created successfully when creating rte_flow.
If still need to add the new flag in app/test-pmd/cmdline.c, I will add related code in next patch.
Br
Simei
>
> Thanks,
> Ori Kam
>
> > --
> > 1.8.3.1
Hi, Ori Kam,
I have updated the patch for v7.
Br
Simei
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Su, Simei
> Sent: Sunday, September 29, 2019 2:47 PM
> To: Ori Kam <orika@mellanox.com>; Zhang, Qi Z <qi.z.zhang@intel.com>; Wu,
> Jingjing <jingjing.wu@intel.com>; Ye, Xiaolong <xiaolong.ye@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v4 3/3] app/testpmd: add RSS offload types
> extending support
>
> Hi, Ori Kam,
>
> > -----Original Message-----
> > From: Ori Kam [mailto:orika@mellanox.com]
> > Sent: Sunday, September 29, 2019 12:49 AM
> > To: Su, Simei <simei.su@intel.com>; Zhang, Qi Z
> > <qi.z.zhang@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>; Ye,
> > Xiaolong <xiaolong.ye@intel.com>
> > Cc: dev@dpdk.org
> > Subject: RE: [dpdk-dev] [PATCH v4 3/3] app/testpmd: add RSS offload
> > types extending support
> >
> > Hi Simei,
> >
> > > -----Original Message-----
> > > From: dev <dev-bounces@dpdk.org> On Behalf Of Simei Su
> > > Sent: Friday, September 27, 2019 11:54 AM
> > > To: qi.z.zhang@intel.com; jingjing.wu@intel.com;
> > > xiaolong.ye@intel.com
> > > Cc: dev@dpdk.org; simei.su@intel.com
> > > Subject: [dpdk-dev] [PATCH v4 3/3] app/testpmd: add RSS offload
> > > types extending support
> > >
> > > This patch adds cmdline support for extended rss types configuration.
> > >
> > > Signed-off-by: Simei Su <simei.su@intel.com>
> > > ---
> > > app/test-pmd/config.c | 4 ++++
> > > 1 file changed, 4 insertions(+)
> > >
> > > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index
> > > 1a5a5c1..a59a69e 100644
> > > --- a/app/test-pmd/config.c
> > > +++ b/app/test-pmd/config.c
> > > @@ -103,6 +103,10 @@
> > > { "tcp", ETH_RSS_TCP },
> > > { "sctp", ETH_RSS_SCTP },
> > > { "tunnel", ETH_RSS_TUNNEL },
> > > + { "l3-src-only", ETH_RSS_L3_SRC_ONLY },
> > > + { "l3-dst-only", ETH_RSS_L3_DST_ONLY },
> > > + { "l4-src-only", ETH_RSS_L4_SRC_ONLY },
> > > + { "l4-dst-only", ETH_RSS_L4_DST_ONLY },
> > > { NULL, 0 },
> > > };
> > >
> >
> > You must also add the new flags in app/test-pmd/cmdline.c So they can
> > be used when creating rte_flow.
>
> If nothing added in app/test-pmd/cmdline.c, they can also be created
> successfully when creating rte_flow.
> If still need to add the new flag in app/test-pmd/cmdline.c, I will add related
> code in next patch.
>
> Br
> Simei
>
> >
> > Thanks,
> > Ori Kam
> >
> > > --
> > > 1.8.3.1
@@ -103,6 +103,10 @@
{ "tcp", ETH_RSS_TCP },
{ "sctp", ETH_RSS_SCTP },
{ "tunnel", ETH_RSS_TUNNEL },
+ { "l3-src-only", ETH_RSS_L3_SRC_ONLY },
+ { "l3-dst-only", ETH_RSS_L3_DST_ONLY },
+ { "l4-src-only", ETH_RSS_L4_SRC_ONLY },
+ { "l4-dst-only", ETH_RSS_L4_DST_ONLY },
{ NULL, 0 },
};