Message ID | 157083994018.11524.11276616720287263690.stgit@devele (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3D79A1EB4A; Sat, 12 Oct 2019 02:26:29 +0200 (CEST) Received: from devele.ntop.org (net-93-145-196-230.cust.vodafonedsl.it [93.145.196.230]) by dpdk.org (Postfix) with ESMTP id 36E591EB49 for <dev@dpdk.org>; Sat, 12 Oct 2019 02:26:27 +0200 (CEST) Received: from [192.168.2.134] (localhost6.localdomain6 [IPv6:::1]) by devele.ntop.org (Postfix) with ESMTP id C55B46C003C for <dev@dpdk.org>; Sat, 12 Oct 2019 02:26:26 +0200 (CEST) From: Alfredo Cardigliano <cardigliano@ntop.org> To: dev@dpdk.org Date: Sat, 12 Oct 2019 02:26:26 +0200 Message-ID: <157083994018.11524.11276616720287263690.stgit@devele> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Subject: [dpdk-dev] [PATCH 00/17] Series short description X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
Series short description
|
|
Message
Alfredo Cardigliano
Oct. 12, 2019, 12:26 a.m. UTC
The patch series provides an initial version of a poll mode driver for Pensando network adapters. The driver name is ionic. --- Alfredo Cardigliano (17): net/ionic: add skeleton net/ionic: add hardware structures definitions net/ionic: add log net/ionic: register and initialize the adapter net/ionic: add port management commands net/ionic: add basic lif support net/ionic: add doorbells net/ionic: add adminq support net/ionic: add notifyq support net/ionic: add basic port operations net/ionic: add RX filters support net/ionic: net-ionic-add-flow-control-support net/ionic: add RSS support net/ionic: add RX and TX handling net/ionic: add stats net/ionic: add TX checksum support net/ionic: read fw version MAINTAINERS | 6 config/common_base | 7 doc/guides/nics/features/ionic.ini | 36 doc/guides/nics/index.rst | 1 doc/guides/nics/ionic.rst | 45 drivers/net/Makefile | 1 drivers/net/ionic/Makefile | 64 + drivers/net/ionic/ionic.h | 82 + drivers/net/ionic/ionic_dev.c | 572 ++++++ drivers/net/ionic/ionic_dev.h | 281 +++ drivers/net/ionic/ionic_ethdev.c | 1335 ++++++++++++++ drivers/net/ionic/ionic_ethdev.h | 22 drivers/net/ionic/ionic_if.h | 2491 +++++++++++++++++++++++++++ drivers/net/ionic/ionic_lif.c | 1713 +++++++++++++++++++ drivers/net/ionic/ionic_lif.h | 189 ++ drivers/net/ionic/ionic_logs.h | 46 drivers/net/ionic/ionic_mac_api.c | 61 + drivers/net/ionic/ionic_mac_api.h | 13 drivers/net/ionic/ionic_main.c | 452 +++++ drivers/net/ionic/ionic_osdep.h | 81 + drivers/net/ionic/ionic_regs.h | 142 ++ drivers/net/ionic/ionic_rx_filter.c | 140 ++ drivers/net/ionic/ionic_rx_filter.h | 47 + drivers/net/ionic/ionic_rxtx.c | 1077 ++++++++++++ drivers/net/ionic/ionic_rxtx.h | 44 drivers/net/ionic/meson.build | 15 drivers/net/ionic/rte_pmd_ionic_version.map | 5 mk/rte.app.mk | 1 28 files changed, 8969 insertions(+) create mode 100644 doc/guides/nics/features/ionic.ini create mode 100644 doc/guides/nics/ionic.rst create mode 100644 drivers/net/ionic/Makefile create mode 100644 drivers/net/ionic/ionic.h create mode 100644 drivers/net/ionic/ionic_dev.c create mode 100644 drivers/net/ionic/ionic_dev.h create mode 100644 drivers/net/ionic/ionic_ethdev.c create mode 100644 drivers/net/ionic/ionic_ethdev.h create mode 100644 drivers/net/ionic/ionic_if.h create mode 100644 drivers/net/ionic/ionic_lif.c create mode 100644 drivers/net/ionic/ionic_lif.h create mode 100644 drivers/net/ionic/ionic_logs.h create mode 100644 drivers/net/ionic/ionic_mac_api.c create mode 100644 drivers/net/ionic/ionic_mac_api.h create mode 100644 drivers/net/ionic/ionic_main.c create mode 100644 drivers/net/ionic/ionic_osdep.h create mode 100644 drivers/net/ionic/ionic_regs.h create mode 100644 drivers/net/ionic/ionic_rx_filter.c create mode 100644 drivers/net/ionic/ionic_rx_filter.h create mode 100644 drivers/net/ionic/ionic_rxtx.c create mode 100644 drivers/net/ionic/ionic_rxtx.h create mode 100644 drivers/net/ionic/meson.build create mode 100644 drivers/net/ionic/rte_pmd_ionic_version.map -- Signature
Comments
On Sat, 12 Oct 2019 02:26:26 +0200 Alfredo Cardigliano <cardigliano@ntop.org> wrote: > The patch series provides an initial version of a > poll mode driver for Pensando network adapters. > The driver name is ionic. > > --- > > Alfredo Cardigliano (17): > net/ionic: add skeleton > net/ionic: add hardware structures definitions > net/ionic: add log > net/ionic: register and initialize the adapter > net/ionic: add port management commands > net/ionic: add basic lif support > net/ionic: add doorbells > net/ionic: add adminq support > net/ionic: add notifyq support > net/ionic: add basic port operations > net/ionic: add RX filters support > net/ionic: net-ionic-add-flow-control-support > net/ionic: add RSS support > net/ionic: add RX and TX handling > net/ionic: add stats > net/ionic: add TX checksum support > net/ionic: read fw version > When adding a new driver, could you send it as one unit, yes it is a big bit of code to review but drippling it out in pieces doesn't make review easier.
Hi Stephen yes, we were thinking of doing a single post for just that reason, but Thomas recommended that we split it up. Thank you Alfredo > On 12 Oct 2019, at 17:28, Stephen Hemminger <stephen@networkplumber.org> wrote: > > On Sat, 12 Oct 2019 02:26:26 +0200 > Alfredo Cardigliano <cardigliano@ntop.org> wrote: > >> The patch series provides an initial version of a >> poll mode driver for Pensando network adapters. >> The driver name is ionic. >> >> --- >> >> Alfredo Cardigliano (17): >> net/ionic: add skeleton >> net/ionic: add hardware structures definitions >> net/ionic: add log >> net/ionic: register and initialize the adapter >> net/ionic: add port management commands >> net/ionic: add basic lif support >> net/ionic: add doorbells >> net/ionic: add adminq support >> net/ionic: add notifyq support >> net/ionic: add basic port operations >> net/ionic: add RX filters support >> net/ionic: net-ionic-add-flow-control-support >> net/ionic: add RSS support >> net/ionic: add RX and TX handling >> net/ionic: add stats >> net/ionic: add TX checksum support >> net/ionic: read fw version >> > > When adding a new driver, could you send it as > one unit, yes it is a big bit of code to review but > drippling it out in pieces doesn't make review easier. >
On 10/14/19 10:16 AM, Alfredo Cardigliano wrote: > Hi Stephen > yes, we were thinking of doing a single post for just that reason, > but Thomas recommended that we split it up. I agree with Thomas that it is better to split it up. What I don't understand from the list below is, for example, why RSS goes before Rx/Tx handling. Ideally, it should be no dead code in patches, the driver should be buildable from patch #1 and subsequent patches should add more and more functionality which is testable. Of course, it is not always doable, for example when a base driver should be added first, but it does not look so in this case. > Thank you > Alfredo > >> On 12 Oct 2019, at 17:28, Stephen Hemminger <stephen@networkplumber.org> wrote: >> >> On Sat, 12 Oct 2019 02:26:26 +0200 >> Alfredo Cardigliano <cardigliano@ntop.org> wrote: >> >>> The patch series provides an initial version of a >>> poll mode driver for Pensando network adapters. >>> The driver name is ionic. >>> >>> --- >>> >>> Alfredo Cardigliano (17): >>> net/ionic: add skeleton >>> net/ionic: add hardware structures definitions >>> net/ionic: add log >>> net/ionic: register and initialize the adapter >>> net/ionic: add port management commands >>> net/ionic: add basic lif support >>> net/ionic: add doorbells >>> net/ionic: add adminq support >>> net/ionic: add notifyq support >>> net/ionic: add basic port operations >>> net/ionic: add RX filters support >>> net/ionic: net-ionic-add-flow-control-support >>> net/ionic: add RSS support >>> net/ionic: add RX and TX handling >>> net/ionic: add stats >>> net/ionic: add TX checksum support >>> net/ionic: read fw version >>> >> When adding a new driver, could you send it as >> one unit, yes it is a big bit of code to review but >> drippling it out in pieces doesn't make review easier. >>