mbox series

[00/17] Series short description

Message ID 157083994018.11524.11276616720287263690.stgit@devele (mailing list archive)
Headers
Series Series short description |

Message

Alfredo Cardigliano Oct. 12, 2019, 12:26 a.m. UTC 
  The patch series provides an initial version of a
poll mode driver for Pensando network adapters.
The driver name is ionic.

---

Alfredo Cardigliano (17):
      net/ionic: add skeleton
      net/ionic: add hardware structures definitions
      net/ionic: add log
      net/ionic: register and initialize the adapter
      net/ionic: add port management commands
      net/ionic: add basic lif support
      net/ionic: add doorbells
      net/ionic: add adminq support
      net/ionic: add notifyq support
      net/ionic: add basic port operations
      net/ionic: add RX filters support
      net/ionic: net-ionic-add-flow-control-support
      net/ionic: add RSS support
      net/ionic: add RX and TX handling
      net/ionic: add stats
      net/ionic: add TX checksum support
      net/ionic: read fw version


 MAINTAINERS                                 |    6 
 config/common_base                          |    7 
 doc/guides/nics/features/ionic.ini          |   36 
 doc/guides/nics/index.rst                   |    1 
 doc/guides/nics/ionic.rst                   |   45 
 drivers/net/Makefile                        |    1 
 drivers/net/ionic/Makefile                  |   64 +
 drivers/net/ionic/ionic.h                   |   82 +
 drivers/net/ionic/ionic_dev.c               |  572 ++++++
 drivers/net/ionic/ionic_dev.h               |  281 +++
 drivers/net/ionic/ionic_ethdev.c            | 1335 ++++++++++++++
 drivers/net/ionic/ionic_ethdev.h            |   22 
 drivers/net/ionic/ionic_if.h                | 2491 +++++++++++++++++++++++++++
 drivers/net/ionic/ionic_lif.c               | 1713 +++++++++++++++++++
 drivers/net/ionic/ionic_lif.h               |  189 ++
 drivers/net/ionic/ionic_logs.h              |   46 
 drivers/net/ionic/ionic_mac_api.c           |   61 +
 drivers/net/ionic/ionic_mac_api.h           |   13 
 drivers/net/ionic/ionic_main.c              |  452 +++++
 drivers/net/ionic/ionic_osdep.h             |   81 +
 drivers/net/ionic/ionic_regs.h              |  142 ++
 drivers/net/ionic/ionic_rx_filter.c         |  140 ++
 drivers/net/ionic/ionic_rx_filter.h         |   47 +
 drivers/net/ionic/ionic_rxtx.c              | 1077 ++++++++++++
 drivers/net/ionic/ionic_rxtx.h              |   44 
 drivers/net/ionic/meson.build               |   15 
 drivers/net/ionic/rte_pmd_ionic_version.map |    5 
 mk/rte.app.mk                               |    1 
 28 files changed, 8969 insertions(+)
 create mode 100644 doc/guides/nics/features/ionic.ini
 create mode 100644 doc/guides/nics/ionic.rst
 create mode 100644 drivers/net/ionic/Makefile
 create mode 100644 drivers/net/ionic/ionic.h
 create mode 100644 drivers/net/ionic/ionic_dev.c
 create mode 100644 drivers/net/ionic/ionic_dev.h
 create mode 100644 drivers/net/ionic/ionic_ethdev.c
 create mode 100644 drivers/net/ionic/ionic_ethdev.h
 create mode 100644 drivers/net/ionic/ionic_if.h
 create mode 100644 drivers/net/ionic/ionic_lif.c
 create mode 100644 drivers/net/ionic/ionic_lif.h
 create mode 100644 drivers/net/ionic/ionic_logs.h
 create mode 100644 drivers/net/ionic/ionic_mac_api.c
 create mode 100644 drivers/net/ionic/ionic_mac_api.h
 create mode 100644 drivers/net/ionic/ionic_main.c
 create mode 100644 drivers/net/ionic/ionic_osdep.h
 create mode 100644 drivers/net/ionic/ionic_regs.h
 create mode 100644 drivers/net/ionic/ionic_rx_filter.c
 create mode 100644 drivers/net/ionic/ionic_rx_filter.h
 create mode 100644 drivers/net/ionic/ionic_rxtx.c
 create mode 100644 drivers/net/ionic/ionic_rxtx.h
 create mode 100644 drivers/net/ionic/meson.build
 create mode 100644 drivers/net/ionic/rte_pmd_ionic_version.map

--
Signature

Comments

Stephen Hemminger Oct. 12, 2019, 3:28 p.m. UTC | #1 
On Sat, 12 Oct 2019 02:26:26 +0200
Alfredo Cardigliano <cardigliano@ntop.org> wrote:

> The patch series provides an initial version of a
> poll mode driver for Pensando network adapters.
> The driver name is ionic.
> 
> ---
> 
> Alfredo Cardigliano (17):
>       net/ionic: add skeleton
>       net/ionic: add hardware structures definitions
>       net/ionic: add log
>       net/ionic: register and initialize the adapter
>       net/ionic: add port management commands
>       net/ionic: add basic lif support
>       net/ionic: add doorbells
>       net/ionic: add adminq support
>       net/ionic: add notifyq support
>       net/ionic: add basic port operations
>       net/ionic: add RX filters support
>       net/ionic: net-ionic-add-flow-control-support
>       net/ionic: add RSS support
>       net/ionic: add RX and TX handling
>       net/ionic: add stats
>       net/ionic: add TX checksum support
>       net/ionic: read fw version
> 

When adding a new driver, could you send it as
one unit, yes it is a big bit of code to review but
drippling it out in pieces doesn't make review easier.
Alfredo Cardigliano Oct. 14, 2019, 7:16 a.m. UTC | #2 
Hi Stephen
yes, we were thinking of doing a single post for just that reason, 
but Thomas recommended that we split it up.

Thank you
Alfredo

> On 12 Oct 2019, at 17:28, Stephen Hemminger <stephen@networkplumber.org> wrote:
> 
> On Sat, 12 Oct 2019 02:26:26 +0200
> Alfredo Cardigliano <cardigliano@ntop.org> wrote:
> 
>> The patch series provides an initial version of a
>> poll mode driver for Pensando network adapters.
>> The driver name is ionic.
>> 
>> ---
>> 
>> Alfredo Cardigliano (17):
>>      net/ionic: add skeleton
>>      net/ionic: add hardware structures definitions
>>      net/ionic: add log
>>      net/ionic: register and initialize the adapter
>>      net/ionic: add port management commands
>>      net/ionic: add basic lif support
>>      net/ionic: add doorbells
>>      net/ionic: add adminq support
>>      net/ionic: add notifyq support
>>      net/ionic: add basic port operations
>>      net/ionic: add RX filters support
>>      net/ionic: net-ionic-add-flow-control-support
>>      net/ionic: add RSS support
>>      net/ionic: add RX and TX handling
>>      net/ionic: add stats
>>      net/ionic: add TX checksum support
>>      net/ionic: read fw version
>> 
> 
> When adding a new driver, could you send it as
> one unit, yes it is a big bit of code to review but
> drippling it out in pieces doesn't make review easier.
>
Andrew Rybchenko Oct. 14, 2019, 7:56 a.m. UTC | #3 
On 10/14/19 10:16 AM, Alfredo Cardigliano wrote:
> Hi Stephen
> yes, we were thinking of doing a single post for just that reason,
> but Thomas recommended that we split it up.

I agree with Thomas that it is better to split it up.
What I don't understand from the list below is, for example,
why RSS goes before Rx/Tx handling.  Ideally, it should be
no dead code in patches, the driver should be buildable
from patch #1 and subsequent patches should add more
and more functionality which is testable. Of course, it is
not always doable, for example when a base driver should
be added first, but it does not look so in this case.

> Thank you
> Alfredo
>
>> On 12 Oct 2019, at 17:28, Stephen Hemminger <stephen@networkplumber.org> wrote:
>>
>> On Sat, 12 Oct 2019 02:26:26 +0200
>> Alfredo Cardigliano <cardigliano@ntop.org> wrote:
>>
>>> The patch series provides an initial version of a
>>> poll mode driver for Pensando network adapters.
>>> The driver name is ionic.
>>>
>>> ---
>>>
>>> Alfredo Cardigliano (17):
>>>       net/ionic: add skeleton
>>>       net/ionic: add hardware structures definitions
>>>       net/ionic: add log
>>>       net/ionic: register and initialize the adapter
>>>       net/ionic: add port management commands
>>>       net/ionic: add basic lif support
>>>       net/ionic: add doorbells
>>>       net/ionic: add adminq support
>>>       net/ionic: add notifyq support
>>>       net/ionic: add basic port operations
>>>       net/ionic: add RX filters support
>>>       net/ionic: net-ionic-add-flow-control-support
>>>       net/ionic: add RSS support
>>>       net/ionic: add RX and TX handling
>>>       net/ionic: add stats
>>>       net/ionic: add TX checksum support
>>>       net/ionic: read fw version
>>>
>> When adding a new driver, could you send it as
>> one unit, yes it is a big bit of code to review but
>> drippling it out in pieces doesn't make review easier.
>>