Message ID | 20190926145444.114485-1-haiyue.wang@intel.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 98D212F4F; Thu, 26 Sep 2019 17:00:21 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id BF2AB2D13 for <dev@dpdk.org>; Thu, 26 Sep 2019 17:00:19 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Sep 2019 08:00:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,552,1559545200"; d="scan'208";a="194151350" Received: from npg-dpdk-haiyue-1.sh.intel.com ([10.67.119.153]) by orsmga006.jf.intel.com with ESMTP; 26 Sep 2019 08:00:16 -0700 From: Haiyue Wang <haiyue.wang@intel.com> To: dev@dpdk.org, ferruh.yigit@intel.com, xiaolong.ye@intel.com Cc: ray.kinsella@intel.com, bernard.iremonger@intel.com, chenmin.sun@intel.com, Haiyue Wang <haiyue.wang@intel.com> Date: Thu, 26 Sep 2019 22:54:40 +0800 Message-Id: <20190926145444.114485-1-haiyue.wang@intel.com> X-Mailer: git-send-email 2.17.1 Subject: [dpdk-dev] [PATCH v2 0/4] get Rx/Tx packet burst mode information X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series | get Rx/Tx packet burst mode information | |
Message
Wang, Haiyue
Sept. 26, 2019, 2:54 p.m. UTC
v1 -> v2: 1). Change the return type of dev_ops callback from 'void' to 'int'. 2). Update the ice/i40 PMD patches with clear git commit log. RFCv3 -> v1: https://patchwork.dpdk.org/patch/59103/ https://patchwork.dpdk.org/patch/59104/ https://patchwork.dpdk.org/patch/59105/ https://patchwork.dpdk.org/patch/59106/ 1). Use the function 'rte_bsf64' to iterate the options for getting the name. Haiyue Wang (4): ethdev: add the API for getting burst mode information net/i40e: add Rx/Tx burst mode get callbacks net/ice: add Rx/Tx burst mode get callbacks app/testpmd: show the Rx/Tx burst mode description app/test-pmd/config.c | 29 +++++++++ doc/guides/rel_notes/release_19_11.rst | 9 +++ drivers/net/i40e/i40e_ethdev.c | 2 + drivers/net/i40e/i40e_ethdev.h | 4 ++ drivers/net/i40e/i40e_rxtx.c | 76 ++++++++++++++++++++++ drivers/net/ice/ice_ethdev.c | 2 + drivers/net/ice/ice_rxtx.c | 58 +++++++++++++++++ drivers/net/ice/ice_rxtx.h | 4 ++ lib/librte_ethdev/rte_ethdev.c | 71 ++++++++++++++++++++ lib/librte_ethdev/rte_ethdev.h | 82 ++++++++++++++++++++++++ lib/librte_ethdev/rte_ethdev_core.h | 5 ++ lib/librte_ethdev/rte_ethdev_version.map | 5 ++ 12 files changed, 347 insertions(+)
Comments
On 09/26, Haiyue Wang wrote: >v1 -> v2: > 1). Change the return type of dev_ops callback from 'void' to > 'int'. > 2). Update the ice/i40 PMD patches with clear git commit log. > >RFCv3 -> v1: > https://patchwork.dpdk.org/patch/59103/ > https://patchwork.dpdk.org/patch/59104/ > https://patchwork.dpdk.org/patch/59105/ > https://patchwork.dpdk.org/patch/59106/ > 1). Use the function 'rte_bsf64' to iterate the options for > getting the name. > >Haiyue Wang (4): > ethdev: add the API for getting burst mode information > net/i40e: add Rx/Tx burst mode get callbacks > net/ice: add Rx/Tx burst mode get callbacks > app/testpmd: show the Rx/Tx burst mode description > > app/test-pmd/config.c | 29 +++++++++ > doc/guides/rel_notes/release_19_11.rst | 9 +++ > drivers/net/i40e/i40e_ethdev.c | 2 + > drivers/net/i40e/i40e_ethdev.h | 4 ++ > drivers/net/i40e/i40e_rxtx.c | 76 ++++++++++++++++++++++ > drivers/net/ice/ice_ethdev.c | 2 + > drivers/net/ice/ice_rxtx.c | 58 +++++++++++++++++ > drivers/net/ice/ice_rxtx.h | 4 ++ > lib/librte_ethdev/rte_ethdev.c | 71 ++++++++++++++++++++ > lib/librte_ethdev/rte_ethdev.h | 82 ++++++++++++++++++++++++ > lib/librte_ethdev/rte_ethdev_core.h | 5 ++ > lib/librte_ethdev/rte_ethdev_version.map | 5 ++ > 12 files changed, 347 insertions(+) > >-- >2.17.1 > For series: Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>
On 9/26/2019 3:54 PM, Haiyue Wang wrote: > v1 -> v2: > 1). Change the return type of dev_ops callback from 'void' to > 'int'. > 2). Update the ice/i40 PMD patches with clear git commit log. > > RFCv3 -> v1: > https://patchwork.dpdk.org/patch/59103/ > https://patchwork.dpdk.org/patch/59104/ > https://patchwork.dpdk.org/patch/59105/ > https://patchwork.dpdk.org/patch/59106/ > 1). Use the function 'rte_bsf64' to iterate the options for > getting the name. > > Haiyue Wang (4): > ethdev: add the API for getting burst mode information > net/i40e: add Rx/Tx burst mode get callbacks > net/ice: add Rx/Tx burst mode get callbacks > app/testpmd: show the Rx/Tx burst mode description Hi Haiyue, Overall lgtm, but what do you think adding a new feature to default.ini for this, something like 'Burst mode info"? And i40e and ixgbe patches can add this feature to the PMD .ini files. Also please remind 'doc/guides/nics/features.rst' also needs to be updated with default.ini update. Thanks, ferruh
Hi, Ferruh > -----Original Message----- > From: Yigit, Ferruh > Sent: Monday, October 14, 2019 20:12 > To: Wang, Haiyue <haiyue.wang@intel.com>; dev@dpdk.org; Ye, Xiaolong <xiaolong.ye@intel.com> > Cc: Kinsella, Ray <ray.kinsella@intel.com>; Iremonger, Bernard <bernard.iremonger@intel.com>; Sun, > Chenmin <chenmin.sun@intel.com> > Subject: Re: [PATCH v2 0/4] get Rx/Tx packet burst mode information > > On 9/26/2019 3:54 PM, Haiyue Wang wrote: > > v1 -> v2: > > 1). Change the return type of dev_ops callback from 'void' to > > 'int'. > > 2). Update the ice/i40 PMD patches with clear git commit log. > > > > RFCv3 -> v1: > > https://patchwork.dpdk.org/patch/59103/ > > https://patchwork.dpdk.org/patch/59104/ > > https://patchwork.dpdk.org/patch/59105/ > > https://patchwork.dpdk.org/patch/59106/ > > 1). Use the function 'rte_bsf64' to iterate the options for > > getting the name. > > > > Haiyue Wang (4): > > ethdev: add the API for getting burst mode information > > net/i40e: add Rx/Tx burst mode get callbacks > > net/ice: add Rx/Tx burst mode get callbacks > > app/testpmd: show the Rx/Tx burst mode description > > Hi Haiyue, > > Overall lgtm, but what do you think adding a new feature to default.ini for > this, something like 'Burst mode info"? > > And i40e and ixgbe patches can add this feature to the PMD .ini files. > > Also please remind 'doc/guides/nics/features.rst' also needs to be updated with > default.ini update. > No problem, I will update it in v3. > Thanks, > ferruh