build: print out dependency names for clarity
Checks
Commit Message
To help developers to get the correct dependency name e.g. when creating a
new example that depends on a specific component, print out the dependency
name for each lib/driver as it is processed.
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
drivers/meson.build | 3 +++
lib/meson.build | 6 ++++--
2 files changed, 7 insertions(+), 2 deletions(-)
Comments
On 19-Sep-19 4:07 PM, Bruce Richardson wrote:
> To help developers to get the correct dependency name e.g. when creating a
> new example that depends on a specific component, print out the dependency
> name for each lib/driver as it is processed.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
Very nice change, +1!
Tested-by: Anatoly Burakov <anatoly.burakov@intel.com>
18/10/2019 18:54, Burakov, Anatoly:
> On 19-Sep-19 4:07 PM, Bruce Richardson wrote:
> > To help developers to get the correct dependency name e.g. when creating a
> > new example that depends on a specific component, print out the dependency
> > name for each lib/driver as it is processed.
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > ---
>
> Very nice change, +1!
>
> Tested-by: Anatoly Burakov <anatoly.burakov@intel.com>
Applied, thanks
It makes meson processing very verbose.
Is there way to filter meson messages?
On Wed, Oct 23, 2019 at 04:40:28PM +0200, Thomas Monjalon wrote:
> 18/10/2019 18:54, Burakov, Anatoly:
> > On 19-Sep-19 4:07 PM, Bruce Richardson wrote:
> > > To help developers to get the correct dependency name e.g. when creating a
> > > new example that depends on a specific component, print out the dependency
> > > name for each lib/driver as it is processed.
> > >
> > > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > > ---
> >
> > Very nice change, +1!
> >
> > Tested-by: Anatoly Burakov <anatoly.burakov@intel.com>
>
> Applied, thanks
>
> It makes meson processing very verbose.
> Is there way to filter meson messages?
>
Well, we can look to make it build configurable, or only add them for
particular build types. However, I think for developers the info it
provides is really useful, so I'd like to keep it on by default initially
anyway.
A good feature to add in 20.02 might be to have settings like this
controlled as in make - where we check for the presence of a .git folder,
for example.
/Bruce
@@ -157,6 +157,9 @@ foreach class:dpdk_driver_classes
set_variable('shared_@0@'.format(lib_name), shared_dep)
set_variable('static_@0@'.format(lib_name), static_dep)
+ dependency_name = ''.join(lib_name.split('rte_'))
+ message('drivers/@0@: Defining dependency "@1@"'.format(
+ drv_path, dependency_name))
endif # build
endforeach
@@ -154,7 +154,9 @@ foreach l:libraries
dpdk_static_libraries = [static_lib] + dpdk_static_libraries
endif # sources.length() > 0
- set_variable('shared_' + libname, shared_dep)
- set_variable('static_' + libname, static_dep)
+ set_variable('shared_rte_' + name, shared_dep)
+ set_variable('static_rte_' + name, static_dep)
+ message('lib/@0@: Defining dependency "@1@"'.format(
+ dir_name, name))
endif # if build
endforeach