mbox series

[v7,0/2] examples/client_server_mp: port id (fixes only)

Message ID 20190805163817.3713-1-stephen@networkplumber.org (mailing list archive)
Headers
Series examples/client_server_mp: port id (fixes only) |

Message

Stephen Hemminger Aug. 5, 2019, 4:38 p.m. UTC 
  v7 - widen port mask to allow 64 ports

v6 - just include fixes; cleanups can wait until 19.11

v5 - change logic in server_mp for evaluating port mask

v4 - fix checkpatch warning
     add patches to fix style issues and use ether format addr

v3 - merge both patches in one series
     use alternative algorithm to check port ownership (N^2)
     because reviewer didn't like direct check.

Stephen Hemminger (2):
  examples/multi_process/client_server_mp: check port validity
  examples/multi_process/client_server_mp - fix crash in mp_client with
    sparse ports

 .../client_server_mp/mp_client/client.c       | 18 ++++-----
 .../client_server_mp/mp_server/args.c         | 40 ++++++++++---------
 .../client_server_mp/mp_server/args.h         |  2 +-
 .../client_server_mp/mp_server/init.c         |  7 +---
 4 files changed, 34 insertions(+), 33 deletions(-)

Comments

Matan Azrad Aug. 7, 2019, 5:40 a.m. UTC | #1 
Acked-by: Matan Azrad <matan@mellanox.com>

From:  Stephen Hemminger
> Sent: Monday, August 5, 2019 7:38 PM
> To: dev@dpdk.org
> Cc: Stephen Hemminger <stephen@networkplumber.org>
> Subject: [dpdk-dev] [PATCH v7 0/2] examples/client_server_mp: port id
> (fixes only)
> 
> v7 - widen port mask to allow 64 ports
> 
> v6 - just include fixes; cleanups can wait until 19.11
> 
> v5 - change logic in server_mp for evaluating port mask
> 
> v4 - fix checkpatch warning
>      add patches to fix style issues and use ether format addr
> 
> v3 - merge both patches in one series
>      use alternative algorithm to check port ownership (N^2)
>      because reviewer didn't like direct check.
> 
> Stephen Hemminger (2):
>   examples/multi_process/client_server_mp: check port validity
>   examples/multi_process/client_server_mp - fix crash in mp_client with
>     sparse ports
> 
>  .../client_server_mp/mp_client/client.c       | 18 ++++-----
>  .../client_server_mp/mp_server/args.c         | 40 ++++++++++---------
>  .../client_server_mp/mp_server/args.h         |  2 +-
>  .../client_server_mp/mp_server/init.c         |  7 +---
>  4 files changed, 34 insertions(+), 33 deletions(-)
> 
> --
> 2.20.1
Thomas Monjalon Nov. 25, 2019, 10:51 p.m. UTC | #2 
07/08/2019 07:40, Matan Azrad:
> 
> Acked-by: Matan Azrad <matan@mellanox.com>
> 
> From:  Stephen Hemminger
> > Sent: Monday, August 5, 2019 7:38 PM
> > 
> > v7 - widen port mask to allow 64 ports
> > 
> > v6 - just include fixes; cleanups can wait until 19.11
> > 
> > v5 - change logic in server_mp for evaluating port mask
> > 
> > v4 - fix checkpatch warning
> >      add patches to fix style issues and use ether format addr
> > 
> > v3 - merge both patches in one series
> >      use alternative algorithm to check port ownership (N^2)
> >      because reviewer didn't like direct check.
> > 
> > Stephen Hemminger (2):
> >   examples/multi_process/client_server_mp: check port validity
> >   examples/multi_process/client_server_mp - fix crash in mp_client with
> >     sparse ports

Applied, thanks.

Sorry for having forgotten this patchset.