diff mbox series

[v2] cfgfile: update map file

Message ID 20191217115203.22162-1-lironh@marvell.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series [v2] cfgfile: update map file |

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/iol-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/travis-robot success Travis build: passed
ci/iol-intel-Performance success Performance Testing PASS
ci/Intel-compilation fail apply issues

Commit Message

Liron Himi Dec. 17, 2019, 11:52 a.m. UTC 
  From: Liron Himi <lironh@marvell.com>

rte_cfgfile_section_num_entries_by_index was missing from the map
file.
meson build failed when calling this function, due to linking a binary to cfgfile built
as a shared library

Fixes: 85ff364f3b ("build: align symbols with global ABI version")

Signed-off-by: Liron Himi <lironh@marvell.com>
---

v2:
  - update commit msg.
  - add 'Fixes'
  - follow alphabetical order

 lib/librte_cfgfile/rte_cfgfile_version.map | 1 +
 1 file changed, 1 insertion(+)

Comments

Cristian Dumitrescu Dec. 17, 2019, 11:12 a.m. UTC | #1 
> -----Original Message-----
> From: lironh@marvell.com <lironh@marvell.com>
> Sent: Tuesday, December 17, 2019 11:52 AM
> To: dev@dpdk.org
> Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; stable@dpdk.org;
> Liron Himi <lironh@marvell.com>
> Subject: [PATCH v2] cfgfile: update map file
> 
> From: Liron Himi <lironh@marvell.com>
> 
> rte_cfgfile_section_num_entries_by_index was missing from the map
> file.
> meson build failed when calling this function, due to linking a binary to cfgfile
> built
> as a shared library
> 
> Fixes: 85ff364f3b ("build: align symbols with global ABI version")
> 
> Signed-off-by: Liron Himi <lironh@marvell.com>
> ---

Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Thomas Monjalon Jan. 19, 2020, 11:31 p.m. UTC | #2 
17/12/2019 12:12, Dumitrescu, Cristian:
> 
> > -----Original Message-----
> > From: lironh@marvell.com <lironh@marvell.com>
> > Sent: Tuesday, December 17, 2019 11:52 AM
> > To: dev@dpdk.org
> > Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; stable@dpdk.org;
> > Liron Himi <lironh@marvell.com>
> > Subject: [PATCH v2] cfgfile: update map file
> > 
> > From: Liron Himi <lironh@marvell.com>
> > 
> > rte_cfgfile_section_num_entries_by_index was missing from the map
> > file.
> > meson build failed when calling this function, due to linking a binary to cfgfile
> > built
> > as a shared library
> > 
> > Fixes: 85ff364f3b ("build: align symbols with global ABI version")
> > 
> > Signed-off-by: Liron Himi <lironh@marvell.com>
> 
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>


Fixing the "Fixes" line with the real root cause:

Fixes: 3d2e0448ebb5 ("cfgfile: add section number of entries by index")
Cc: stable@dpdk.org


Applied, thanks
diff mbox series

Patch

diff --git a/lib/librte_cfgfile/rte_cfgfile_version.map b/lib/librte_cfgfile/rte_cfgfile_version.map
index 906eee96b..22c999fe1 100644
--- a/lib/librte_cfgfile/rte_cfgfile_version.map
+++ b/lib/librte_cfgfile/rte_cfgfile_version.map
@@ -15,6 +15,7 @@  DPDK_20.0 {
 	rte_cfgfile_section_entries;
 	rte_cfgfile_section_entries_by_index;
 	rte_cfgfile_section_num_entries;
+	rte_cfgfile_section_num_entries_by_index;
 	rte_cfgfile_sections;
 	rte_cfgfile_set_entry;