Message ID | 20200108062510.3478-1-oda@valinux.co.jp (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 33C55A04FA; Wed, 8 Jan 2020 07:25:22 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F09981D90A; Wed, 8 Jan 2020 07:25:15 +0100 (CET) Received: from valinux.co.jp (vagw.valinux.co.jp [210.128.90.14]) by dpdk.org (Postfix) with ESMTP id 650721D6E4 for <dev@dpdk.org>; Wed, 8 Jan 2020 07:25:12 +0100 (CET) Received: by valinux.co.jp (Postfix, from userid 1000) id 0DA7524098A; Wed, 8 Jan 2020 15:25:10 +0900 (JST) From: oda@valinux.co.jp To: dev@dpdk.org Date: Wed, 8 Jan 2020 15:25:06 +0900 Message-Id: <20200108062510.3478-1-oda@valinux.co.jp> X-Mailer: git-send-email 2.17.1 Subject: [dpdk-dev] [PATCH 0/4] make vhost PMD available for secondary processes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
make vhost PMD available for secondary processes
|
|
Message
Itsuro Oda
Jan. 8, 2020, 6:25 a.m. UTC
From: Itsuro Oda <oda@valinux.co.jp>
vhost PMD has not been available for secondary processes since
DPDK v18.11. (https://bugs.dpdk.org/show_bug.cgi?id=194)
(for a long term !)
This series of patches intend to make vhost PMD available for
secondary processes.
Because now setting vhost driver to communicate with a vhost-user
master (ex. Qemu) is accomplished by the probe function of the
primary process, only the primary process can be a vhost-user
slave.
With this patch, setting vhost driver is delayed at eth_dev
configuration in order to be able to set it from a secondary
process. Because (in the first place,) setting vhost driver is not
necessary to be done at probe (it is enough to be done up to eth_dev
start), this fix is no problem for the primary process.
There is a precondition that the same process has to operate
a vhost interface from begining to end (eth_dev configuration to
eth_dev close). (This patch leaves it to user's responsibility.)
This precondition will not be a problem in most use cases
(including SPP).
Itsuro Oda (4):
net/vhost: remove an unused member
net/vhost: allocate iface_name from heap
net/vhost: delay vhost driver setup
net/vhost: make secondary probe complete
drivers/net/vhost/rte_eth_vhost.c | 152 +++++++++++++++++-------------
1 file changed, 88 insertions(+), 64 deletions(-)
Comments
Hi, I will fix to add signed-off-by and correct spelling error according to test-report@dpdk. Please check the content until then. Thanks. On Wed, 8 Jan 2020 15:25:06 +0900 oda@valinux.co.jp wrote: > From: Itsuro Oda <oda@valinux.co.jp> > > vhost PMD has not been available for secondary processes since > DPDK v18.11. (https://bugs.dpdk.org/show_bug.cgi?id=194) > (for a long term !) > This series of patches intend to make vhost PMD available for > secondary processes. > Because now setting vhost driver to communicate with a vhost-user > master (ex. Qemu) is accomplished by the probe function of the > primary process, only the primary process can be a vhost-user > slave. > With this patch, setting vhost driver is delayed at eth_dev > configuration in order to be able to set it from a secondary > process. Because (in the first place,) setting vhost driver is not > necessary to be done at probe (it is enough to be done up to eth_dev > start), this fix is no problem for the primary process. > There is a precondition that the same process has to operate > a vhost interface from begining to end (eth_dev configuration to > eth_dev close). (This patch leaves it to user's responsibility.) > This precondition will not be a problem in most use cases > (including SPP). > > Itsuro Oda (4): > net/vhost: remove an unused member > net/vhost: allocate iface_name from heap > net/vhost: delay vhost driver setup > net/vhost: make secondary probe complete > > drivers/net/vhost/rte_eth_vhost.c | 152 +++++++++++++++++------------- > 1 file changed, 88 insertions(+), 64 deletions(-) > > -- > 2.17.0
vhost PMD has not been available for secondary processes since DPDK v18.11. (https://bugs.dpdk.org/show_bug.cgi?id=194) (for a long term !) This series of patches intend to make vhost PMD available for secondary processes. Because now setting vhost driver to communicate with a vhost-user master (ex. Qemu) is accomplished by the probe function of the primary process, only the primary process can be a vhost-user slave. With this patch, setting vhost driver is delayed at eth_dev configuration in order to be able to set it from a secondary process. Because (in the first place,) setting vhost driver is not necessary to be done at probe (it is enough to be done up to eth_dev start), this fix is no problem for the primary process. There is a precondition that the same process has to operate a vhost interface from beginning to end (from eth_dev configuration to eth_dev close). (This patch leaves it to user's responsibility.) This precondition will not be a problem in most use cases (including SPP). v2: - add signed-off-by - fix spelling error Itsuro Oda (4): net/vhost: remove an unused member net/vhost: allocate iface_name from heap net/vhost: delay vhost driver setup net/vhost: make secondary probe complete drivers/net/vhost/rte_eth_vhost.c | 152 +++++++++++++++++------------- 1 file changed, 88 insertions(+), 64 deletions(-)
Hi vhost PMD maitainers, I have not got any feedback yet. Since this is the first time I submit a patch, something may be wrong, would you tell me what should I do ? Thanks. On Thu, 9 Jan 2020 08:22:05 +0900 Itsuro Oda <oda@valinux.co.jp> wrote: > vhost PMD has not been available for secondary processes since > DPDK v18.11. (https://bugs.dpdk.org/show_bug.cgi?id=194) > (for a long term !) > This series of patches intend to make vhost PMD available for > secondary processes. > Because now setting vhost driver to communicate with a vhost-user > master (ex. Qemu) is accomplished by the probe function of the > primary process, only the primary process can be a vhost-user > slave. > With this patch, setting vhost driver is delayed at eth_dev > configuration in order to be able to set it from a secondary > process. Because (in the first place,) setting vhost driver is not > necessary to be done at probe (it is enough to be done up to eth_dev > start), this fix is no problem for the primary process. > There is a precondition that the same process has to operate > a vhost interface from beginning to end (from eth_dev configuration > to eth_dev close). (This patch leaves it to user's responsibility.) > This precondition will not be a problem in most use cases > (including SPP). > > v2: > - add signed-off-by > - fix spelling error > > Itsuro Oda (4): > net/vhost: remove an unused member > net/vhost: allocate iface_name from heap > net/vhost: delay vhost driver setup > net/vhost: make secondary probe complete > > drivers/net/vhost/rte_eth_vhost.c | 152 +++++++++++++++++------------- > 1 file changed, 88 insertions(+), 64 deletions(-) > > -- > 2.17.0
Hi Itsuro, On 1/20/20 3:17 AM, Itsuro ODA wrote: > Hi vhost PMD maitainers, > > I have not got any feedback yet. > Since this is the first time I submit a patch, something > may be wrong, would you tell me what should I do ? Sorry for the delay, and thanks for the contribution. You series does not apply properly on dpdk-next-virtio master branch: https://git.dpdk.org/next/dpdk-next-virtio I will review it, so when doing v3, please rebase it. More generally, you series comprises fixes (patch 2 to 4), and cleanup (patch 1). Cleanup patch should be the last, in order to ease the backporting of the fixes to LTSes (we avoid backporting cleanup patches). Regarding fixes patches, it should tag the faulty commit in master branch, and stable@dpdk.org should be Cc'ed. Example of commit message with fixes tag: http://patches.dpdk.org/patch/63305/ Finally, when you'll post the v3, please prefix the patches subject with the revision number: git format-patch --subject-prefix"PATCH v3" ... Thanks, Maxime > Thanks. > > On Thu, 9 Jan 2020 08:22:05 +0900 > Itsuro Oda <oda@valinux.co.jp> wrote: > >> vhost PMD has not been available for secondary processes since >> DPDK v18.11. (https://bugs.dpdk.org/show_bug.cgi?id=194) >> (for a long term !) >> This series of patches intend to make vhost PMD available for >> secondary processes. >> Because now setting vhost driver to communicate with a vhost-user >> master (ex. Qemu) is accomplished by the probe function of the >> primary process, only the primary process can be a vhost-user >> slave. >> With this patch, setting vhost driver is delayed at eth_dev >> configuration in order to be able to set it from a secondary >> process. Because (in the first place,) setting vhost driver is not >> necessary to be done at probe (it is enough to be done up to eth_dev >> start), this fix is no problem for the primary process. >> There is a precondition that the same process has to operate >> a vhost interface from beginning to end (from eth_dev configuration >> to eth_dev close). (This patch leaves it to user's responsibility.) >> This precondition will not be a problem in most use cases >> (including SPP). >> >> v2: >> - add signed-off-by >> - fix spelling error >> >> Itsuro Oda (4): >> net/vhost: remove an unused member >> net/vhost: allocate iface_name from heap >> net/vhost: delay vhost driver setup >> net/vhost: make secondary probe complete >> >> drivers/net/vhost/rte_eth_vhost.c | 152 +++++++++++++++++------------- >> 1 file changed, 88 insertions(+), 64 deletions(-) >> >> -- >> 2.17.0 >
Hi Maxime, Thank you for your reply and review. I will make fixes of the patches according to your indication and post them. Thanks. Itsuro Oda On Tue, 4 Feb 2020 18:54:23 +0100 Maxime Coquelin <maxime.coquelin@redhat.com> wrote: > Hi Itsuro, > > On 1/20/20 3:17 AM, Itsuro ODA wrote: > > Hi vhost PMD maitainers, > > > > I have not got any feedback yet. > > Since this is the first time I submit a patch, something > > may be wrong, would you tell me what should I do ? > > Sorry for the delay, and thanks for the contribution. > > You series does not apply properly on dpdk-next-virtio master branch: > https://git.dpdk.org/next/dpdk-next-virtio > > I will review it, so when doing v3, please rebase it. > > More generally, you series comprises fixes (patch 2 to 4), and > cleanup (patch 1). > > Cleanup patch should be the last, in order to ease the backporting > of the fixes to LTSes (we avoid backporting cleanup patches). > > Regarding fixes patches, it should tag the faulty commit in > master branch, and stable@dpdk.org should be Cc'ed. > > Example of commit message with fixes tag: > http://patches.dpdk.org/patch/63305/ > > Finally, when you'll post the v3, please prefix the patches subject > with the revision number: > > git format-patch --subject-prefix"PATCH v3" ... > > Thanks, > Maxime > > > Thanks. > > > > On Thu, 9 Jan 2020 08:22:05 +0900 > > Itsuro Oda <oda@valinux.co.jp> wrote: > > > >> vhost PMD has not been available for secondary processes since > >> DPDK v18.11. (https://bugs.dpdk.org/show_bug.cgi?id=194) > >> (for a long term !) > >> This series of patches intend to make vhost PMD available for > >> secondary processes. > >> Because now setting vhost driver to communicate with a vhost-user > >> master (ex. Qemu) is accomplished by the probe function of the > >> primary process, only the primary process can be a vhost-user > >> slave. > >> With this patch, setting vhost driver is delayed at eth_dev > >> configuration in order to be able to set it from a secondary > >> process. Because (in the first place,) setting vhost driver is not > >> necessary to be done at probe (it is enough to be done up to eth_dev > >> start), this fix is no problem for the primary process. > >> There is a precondition that the same process has to operate > >> a vhost interface from beginning to end (from eth_dev configuration > >> to eth_dev close). (This patch leaves it to user's responsibility.) > >> This precondition will not be a problem in most use cases > >> (including SPP). > >> > >> v2: > >> - add signed-off-by > >> - fix spelling error > >> > >> Itsuro Oda (4): > >> net/vhost: remove an unused member > >> net/vhost: allocate iface_name from heap > >> net/vhost: delay vhost driver setup > >> net/vhost: make secondary probe complete > >> > >> drivers/net/vhost/rte_eth_vhost.c | 152 +++++++++++++++++------------- > >> 1 file changed, 88 insertions(+), 64 deletions(-) > >> > >> -- > >> 2.17.0 > >