[v2,1/1] eal: improve user notification for too low memzone segments

Message ID 20191220150839.17994-2-arturx.trybula@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series eal: user notification improvement |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK

Commit Message

Artur Trybula Dec. 20, 2019, 3:08 p.m. UTC
  In case of too low number of memzone segements user notification
was misleading. This patch improves the description by providing
better explanation about the cause.

Signed-off-by: Artur Trybula <arturx.trybula@intel.com>
---
 lib/librte_eal/common/eal_common_memzone.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
  

Comments

Burakov, Anatoly Jan. 14, 2020, 10:40 a.m. UTC | #1
On 20-Dec-19 3:08 PM, Artur Trybula wrote:
> In case of too low number of memzone segements user notification
> was misleading. This patch improves the description by providing
> better explanation about the cause.
> 
> Signed-off-by: Artur Trybula <arturx.trybula@intel.com>
> ---

Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
  
Thomas Monjalon Jan. 20, 2020, 5:53 p.m. UTC | #2
14/01/2020 11:40, Burakov, Anatoly:
> On 20-Dec-19 3:08 PM, Artur Trybula wrote:
> > In case of too low number of memzone segements user notification
> > was misleading. This patch improves the description by providing
> > better explanation about the cause.
> > 
> > Signed-off-by: Artur Trybula <arturx.trybula@intel.com>
> 
> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>

Applied, thanks
  

Patch

diff --git a/lib/librte_eal/common/eal_common_memzone.c b/lib/librte_eal/common/eal_common_memzone.c
index 99b8d6531..86f61369b 100644
--- a/lib/librte_eal/common/eal_common_memzone.c
+++ b/lib/librte_eal/common/eal_common_memzone.c
@@ -71,7 +71,9 @@  memzone_reserve_aligned_thread_unsafe(const char *name, size_t len,
 
 	/* no more room in config */
 	if (arr->count >= arr->len) {
-		RTE_LOG(ERR, EAL, "%s(): No more room in config\n", __func__);
+		RTE_LOG(ERR, EAL,
+		"%s(): Number of requested memzone segments exceeds RTE_MAX_MEMZONE\n",
+			__func__);
 		rte_errno = ENOSPC;
 		return NULL;
 	}