mbox series

[v5,0/5] fixes for tap

Message ID 1587006237-21592-1-git-send-email-wangyunjian@huawei.com (mailing list archive)
Headers
Series fixes for tap |

Message

Yunjian Wang April 16, 2020, 3:03 a.m. UTC 
  From: Yunjian Wang <wangyunjian@huawei.com>

This series include five fixes patches for tap PMD driver.

--
v5:
* fix check fd error
v4:
* Update some code suggested by Ferruh Yigit and Stephen Hemminger
* Update commit log
* Add fix leak of fds on failure
v3:
* Add fix close a vaild fd and netlink socket file descriptor check
  before close
v2:
* Add null check in tap_rxq_pool_free()

Yunjian Wang (5):
  net/tap: fix mbuf double free when writev fails
  net/tap: fix mbuf and mem leak during queue release
  net/tap: fix check for mbuf's nb_segs failure
  net/tap: fix close a valid fd
  net/tap: fix leak of fds on failure

 drivers/net/tap/rte_eth_tap.c | 106 ++++++++++++++++++++--------------
 1 file changed, 63 insertions(+), 43 deletions(-)

Comments

Stephen Hemminger April 16, 2020, 5:07 a.m. UTC | #1 
On Thu, 16 Apr 2020 11:03:57 +0800
wangyunjian <wangyunjian@huawei.com> wrote:

> From: Yunjian Wang <wangyunjian@huawei.com>
> 
> This series include five fixes patches for tap PMD driver.
> 
> --
> v5:
> * fix check fd error
> v4:
> * Update some code suggested by Ferruh Yigit and Stephen Hemminger
> * Update commit log
> * Add fix leak of fds on failure
> v3:
> * Add fix close a vaild fd and netlink socket file descriptor check
>   before close
> v2:
> * Add null check in tap_rxq_pool_free()
> 
> Yunjian Wang (5):
>   net/tap: fix mbuf double free when writev fails
>   net/tap: fix mbuf and mem leak during queue release
>   net/tap: fix check for mbuf's nb_segs failure
>   net/tap: fix close a valid fd
>   net/tap: fix leak of fds on failure
> 
>  drivers/net/tap/rte_eth_tap.c | 106 ++++++++++++++++++++--------------
>  1 file changed, 63 insertions(+), 43 deletions(-)
> 

These all look good.
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
Ferruh Yigit April 16, 2020, 11:54 a.m. UTC | #2 
On 4/16/2020 6:07 AM, Stephen Hemminger wrote:
> On Thu, 16 Apr 2020 11:03:57 +0800
> wangyunjian <wangyunjian@huawei.com> wrote:
> 
>> From: Yunjian Wang <wangyunjian@huawei.com>
>>
>> This series include five fixes patches for tap PMD driver.
>>
>> --
>> v5:
>> * fix check fd error
>> v4:
>> * Update some code suggested by Ferruh Yigit and Stephen Hemminger
>> * Update commit log
>> * Add fix leak of fds on failure
>> v3:
>> * Add fix close a vaild fd and netlink socket file descriptor check
>>   before close
>> v2:
>> * Add null check in tap_rxq_pool_free()
>>
>> Yunjian Wang (5):
>>   net/tap: fix mbuf double free when writev fails
>>   net/tap: fix mbuf and mem leak during queue release
>>   net/tap: fix check for mbuf's nb_segs failure
>>   net/tap: fix close a valid fd
>>   net/tap: fix leak of fds on failure
>>
>>  drivers/net/tap/rte_eth_tap.c | 106 ++++++++++++++++++++--------------
>>  1 file changed, 63 insertions(+), 43 deletions(-)
>>
> 
> These all look good.
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>
> 

For series,
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Series applied to dpdk-next-net/master, thanks.
Ferruh Yigit April 16, 2020, 11:54 a.m. UTC | #3 
On 4/16/2020 6:07 AM, Stephen Hemminger wrote:
> On Thu, 16 Apr 2020 11:03:57 +0800
> wangyunjian <wangyunjian@huawei.com> wrote:
> 
>> From: Yunjian Wang <wangyunjian@huawei.com>
>>
>> This series include five fixes patches for tap PMD driver.
>>
>> --
>> v5:
>> * fix check fd error
>> v4:
>> * Update some code suggested by Ferruh Yigit and Stephen Hemminger
>> * Update commit log
>> * Add fix leak of fds on failure
>> v3:
>> * Add fix close a vaild fd and netlink socket file descriptor check
>>   before close
>> v2:
>> * Add null check in tap_rxq_pool_free()
>>
>> Yunjian Wang (5):
>>   net/tap: fix mbuf double free when writev fails
>>   net/tap: fix mbuf and mem leak during queue release
>>   net/tap: fix check for mbuf's nb_segs failure
>>   net/tap: fix close a valid fd
>>   net/tap: fix leak of fds on failure
>>
>>  drivers/net/tap/rte_eth_tap.c | 106 ++++++++++++++++++++--------------
>>  1 file changed, 63 insertions(+), 43 deletions(-)
>>
> 
> These all look good.
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>
> 

For series,
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Series applied to dpdk-next-net/master, thanks.