app/test-fib: fix unchecked return value
Checks
Commit Message
Check returned value after strtok()
CID 355674 (#1 of 1): Dereference null return value (NULL_RETURNS)
4. dereference: Dereferencing a pointer that might be NULL s when
calling inet_pton
Fixes: 103809d032cd ("app/test-fib: add test application for FIB")
Cc: stable@dpdk.org
Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
---
app/test-fib/main.c | 2 ++
1 file changed, 2 insertions(+)
Comments
11/05/2020 11:22, Vladimir Medvedkin:
> Check returned value after strtok()
> CID 355674 (#1 of 1): Dereference null return value (NULL_RETURNS)
> 4. dereference: Dereferencing a pointer that might be NULL s when
> calling inet_pton
>
> Fixes: 103809d032cd ("app/test-fib: add test application for FIB")
> Cc: stable@dpdk.org
>
> Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
Applied, thanks
@@ -543,6 +543,8 @@ parse_lookup(FILE *f, int af)
while (fgets(line, sizeof(line), f) != NULL) {
s = strtok(line, " \t\n");
+ if (s == NULL)
+ return -EINVAL;
ret = inet_pton(af, s, &tbl[i]);
if (ret != 1)
return -EINVAL;