Message ID | 20200522132320.26373-1-louise.kilheeney@intel.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EEB40A0350; Fri, 22 May 2020 15:24:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 165341D96D; Fri, 22 May 2020 15:24:20 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 6F37E1D960 for <dev@dpdk.org>; Fri, 22 May 2020 15:24:18 +0200 (CEST) IronPort-SDR: GVJSXXwEWM3qtM8mZDd01x3fOPlrbQdJA47aE2ErR9YL7cC1iXhfH6te/92T9JqJfTGErJRkVV SLVNRowpoZbw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 May 2020 06:24:17 -0700 IronPort-SDR: XL7H7j9ypyW3pOM4Rhm/PQ+i/i1gEOjk8ytGOcMeez/BV1UjVepZs6dfXziEW3WiiiLWeq95D6 jwHeTf0yMpkg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,421,1583222400"; d="scan'208";a="283397985" Received: from silpixa00389033.ir.intel.com (HELO silpixa00389033.ger.corp.intel.com) ([10.237.223.171]) by orsmga002.jf.intel.com with ESMTP; 22 May 2020 06:24:16 -0700 From: Louise Kilheeney <louise.kilheeney@intel.com> To: dev@dpdk.org Cc: Louise Kilheeney <louise.kilheeney@intel.com> Date: Fri, 22 May 2020 14:23:11 +0100 Message-Id: <20200522132320.26373-1-louise.kilheeney@intel.com> X-Mailer: git-send-email 2.17.1 Subject: [dpdk-dev] [PATCH 20.08 0/9] adding support for python 3 only. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
adding support for python 3 only.
|
|
Message
Louise Kilheeney
May 22, 2020, 1:23 p.m. UTC
This patch set converts all python scripts in the project to use python3 only. This is due to python2 being EOL in January 2020. One script not tested: ./config/arm/armv8_machine.py Louise Kilheeney (9): app/test-bbdev: support python3 only usertools/dpdk-devbind: support python3 only usertools/dpdk-telemetry-client: support python3 only usertools/dpdk-pmdinfo: support python3 only usertools/cpu_layout: support python3 only app/test-cmdline: support python3 only app/test: support python3 only devtools: support python3 only config/arm: support python3 only app/test-bbdev/test-bbdev.py | 7 +++---- app/test-cmdline/cmdline_test.py | 3 +-- app/test-cmdline/cmdline_test_data.py | 1 + app/test/autotest.py | 3 +-- app/test/autotest_data.py | 1 + app/test/autotest_runner.py | 14 +++++++------- app/test/autotest_test_funcs.py | 1 + config/arm/armv8_machine.py | 2 +- devtools/update_version_map_abi.py | 3 +-- mk/rte.sdktest.mk | 6 +++--- usertools/cpu_layout.py | 9 ++------- usertools/dpdk-devbind.py | 3 +-- usertools/dpdk-pmdinfo.py | 4 +--- usertools/dpdk-telemetry-client.py | 16 ++++------------ 14 files changed, 28 insertions(+), 45 deletions(-)
Comments
Hi Louise, 2020-05-22, Louise Kilheeney: > This patch set converts all python scripts in the project to use > python3 only. This is due to python2 being EOL in January 2020. > > One script not tested: ./config/arm/armv8_machine.py > > Louise Kilheeney (9): > app/test-bbdev: support python3 only > usertools/dpdk-devbind: support python3 only > usertools/dpdk-telemetry-client: support python3 only > usertools/dpdk-pmdinfo: support python3 only > usertools/cpu_layout: support python3 only > app/test-cmdline: support python3 only > app/test: support python3 only > devtools: support python3 only > config/arm: support python3 only How did you test your changes? Also, I had understood that python 2 support would not be dropped before 20.11: http://mails.dpdk.org/archives/dev/2020-February/157793.html Did I miss something?
On Mon, May 25, 2020 at 09:27:17AM +0200, Robin Jarry wrote: > Hi Louise, > > 2020-05-22, Louise Kilheeney: > > This patch set converts all python scripts in the project to use > > python3 only. This is due to python2 being EOL in January 2020. > > > > One script not tested: ./config/arm/armv8_machine.py > > > > Louise Kilheeney (9): > > app/test-bbdev: support python3 only > > usertools/dpdk-devbind: support python3 only > > usertools/dpdk-telemetry-client: support python3 only > > usertools/dpdk-pmdinfo: support python3 only > > usertools/cpu_layout: support python3 only > > app/test-cmdline: support python3 only > > app/test: support python3 only > > devtools: support python3 only > > config/arm: support python3 only > > How did you test your changes? > > Also, I had understood that python 2 support would not be dropped before > 20.11: http://mails.dpdk.org/archives/dev/2020-February/157793.html > > Did I miss something? > The 20.11 was just a suggestion from me, but I'm not sure it was ever definitively agreed upon. I'd be ok with removing python2 support in either 20.08 or deferring to 20.11. I don't think the patches would be different no matter what release it being targetted. :-) Is there a particular concern around removing python2 support? I thought all linux distros now have python3, and many are stopping installing python2 by default also.
2020-05-25, Bruce Richardson: > The 20.11 was just a suggestion from me, but I'm not sure it was ever > definitively agreed upon. I'd be ok with removing python2 support in either > 20.08 or deferring to 20.11. I don't think the patches would be different > no matter what release it being targetted. :-) > Is there a particular concern around removing python2 support? I thought > all linux distros now have python3, and many are stopping installing > python2 by default also. Absolutely no concern around getting rid of Python 2 support :-) Thanks for the clarification.
I tested all scripts by running each of them manually, if you have any input into what tests you thinks would be good to run please do let me know. Louise Kilheeney > -----Original Message----- > From: Robin Jarry <robin.jarry@6wind.com> > Sent: Monday 25 May 2020 08:27 > To: Kilheeney, Louise <louise.kilheeney@intel.com> > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 20.08 0/9] adding support for python 3 only. > > Hi Louise, > > 2020-05-22, Louise Kilheeney: > > This patch set converts all python scripts in the project to use > > python3 only. This is due to python2 being EOL in January 2020. > > > > One script not tested: ./config/arm/armv8_machine.py > > > > Louise Kilheeney (9): > > app/test-bbdev: support python3 only > > usertools/dpdk-devbind: support python3 only > > usertools/dpdk-telemetry-client: support python3 only > > usertools/dpdk-pmdinfo: support python3 only > > usertools/cpu_layout: support python3 only > > app/test-cmdline: support python3 only > > app/test: support python3 only > > devtools: support python3 only > > config/arm: support python3 only > > How did you test your changes? > > Also, I had understood that python 2 support would not be dropped before > 20.11: http://mails.dpdk.org/archives/dev/2020-February/157793.html > > Did I miss something? > > -- > Robin
2020-05-25, Kilheeney, Louise: > I tested all scripts by running each of them manually, if you have any > input into what tests you thinks would be good to run please do let me > know. This should be enough to debunk the most obvious problems. Thanks.