Message ID | 1590139278-11046-1-git-send-email-xavier.huwei@huawei.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E3354A0093; Fri, 22 May 2020 11:22:50 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 112991D954; Fri, 22 May 2020 11:22:45 +0200 (CEST) Received: from huawei.com (szxga05-in.huawei.com [45.249.212.191]) by dpdk.org (Postfix) with ESMTP id C86741D93F for <dev@dpdk.org>; Fri, 22 May 2020 11:22:40 +0200 (CEST) Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 00ED72C0C4F00CF5036A for <dev@dpdk.org>; Fri, 22 May 2020 17:22:39 +0800 (CST) Received: from localhost.localdomain (10.69.192.56) by DGGEMS413-HUB.china.huawei.com (10.3.19.213) with Microsoft SMTP Server id 14.3.487.0; Fri, 22 May 2020 17:22:34 +0800 From: "Wei Hu (Xavier)" <xavier.huwei@huawei.com> To: <dev@dpdk.org> Date: Fri, 22 May 2020 17:21:13 +0800 Message-ID: <1590139278-11046-1-git-send-email-xavier.huwei@huawei.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.69.192.56] X-CFilter-Loop: Reflected Subject: [dpdk-dev] [PATCH 0/5] misc updates for hns3 PMD driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
misc updates for hns3 PMD driver
|
|
Message
Wei Hu (Xavier)
May 22, 2020, 9:21 a.m. UTC
This series are improvement and bugfixes for hns3 PMD driver. Chengchang Tang (2): net/hns3: replace PF vport id zero with private macro net/hns3: fix promiscuous config not clear for PF on uninit Lijun Ou (2): net/hns3: add RSS hash offload to port Rx configuration net/hns3: fix key length when configuring RSS Wei Hu (Xavier) (1): net/hns3: fix preparing sending packets less than 60 bytes drivers/net/hns3/hns3_ethdev.c | 102 ++++++++++++++++++++++++-------------- drivers/net/hns3/hns3_ethdev.h | 3 ++ drivers/net/hns3/hns3_ethdev_vf.c | 1 + drivers/net/hns3/hns3_flow.c | 8 +++ drivers/net/hns3/hns3_rxtx.c | 6 --- 5 files changed, 78 insertions(+), 42 deletions(-)
Comments
On 5/22/2020 10:21 AM, Wei Hu (Xavier) wrote: > This series are improvement and bugfixes for hns3 PMD driver. Hi Xavier, We are planning to have the -rc4 this weekend and the release on Tuesday. So we are literally a few days away from the release. It is definitely not good idea to change the code this close to the release, that is why we are saying -rc4 for the critical defects only. I will postpone this series to the next release, fyi. > > Chengchang Tang (2): > net/hns3: replace PF vport id zero with private macro > net/hns3: fix promiscuous config not clear for PF on uninit > > Lijun Ou (2): > net/hns3: add RSS hash offload to port Rx configuration > net/hns3: fix key length when configuring RSS > > Wei Hu (Xavier) (1): > net/hns3: fix preparing sending packets less than 60 bytes > > drivers/net/hns3/hns3_ethdev.c | 102 ++++++++++++++++++++++++-------------- > drivers/net/hns3/hns3_ethdev.h | 3 ++ > drivers/net/hns3/hns3_ethdev_vf.c | 1 + > drivers/net/hns3/hns3_flow.c | 8 +++ > drivers/net/hns3/hns3_rxtx.c | 6 --- > 5 files changed, 78 insertions(+), 42 deletions(-) >
On 2020/5/22 19:20, Ferruh Yigit wrote: > On 5/22/2020 10:21 AM, Wei Hu (Xavier) wrote: >> This series are improvement and bugfixes for hns3 PMD driver. > Hi Xavier, > > We are planning to have the -rc4 this weekend and the release on Tuesday. So we > are literally a few days away from the release. > > It is definitely not good idea to change the code this close to the release, > that is why we are saying -rc4 for the critical defects only. > > I will postpone this series to the next release, fyi. Hi, Ferruh Yigit I got it. I will adjust the frequency of sending patches to the community in future. Thank you. Regards Xavier >> Chengchang Tang (2): >> net/hns3: replace PF vport id zero with private macro >> net/hns3: fix promiscuous config not clear for PF on uninit >> >> Lijun Ou (2): >> net/hns3: add RSS hash offload to port Rx configuration >> net/hns3: fix key length when configuring RSS >> >> Wei Hu (Xavier) (1): >> net/hns3: fix preparing sending packets less than 60 bytes >> >> drivers/net/hns3/hns3_ethdev.c | 102 ++++++++++++++++++++++++-------------- >> drivers/net/hns3/hns3_ethdev.h | 3 ++ >> drivers/net/hns3/hns3_ethdev_vf.c | 1 + >> drivers/net/hns3/hns3_flow.c | 8 +++ >> drivers/net/hns3/hns3_rxtx.c | 6 --- >> 5 files changed, 78 insertions(+), 42 deletions(-) >> >
On 5/22/2020 10:21 AM, Wei Hu (Xavier) wrote: > This series are improvement and bugfixes for hns3 PMD driver. > > Chengchang Tang (2): > net/hns3: replace PF vport id zero with private macro > net/hns3: fix promiscuous config not clear for PF on uninit > > Lijun Ou (2): > net/hns3: add RSS hash offload to port Rx configuration > net/hns3: fix key length when configuring RSS > > Wei Hu (Xavier) (1): > net/hns3: fix preparing sending packets less than 60 bytes > Series applied to dpdk-next-net/master, thanks. A minor modification done [1] to fix 32-bit build error [2]. [1] diff --git a/drivers/net/hns3/hns3_flow.c b/drivers/net/hns3/hns3_flow.c index e3c239286a..c7851b235c 100644 --- a/drivers/net/hns3/hns3_flow.c +++ b/drivers/net/hns3/hns3_flow.c @@ -1478,7 +1478,7 @@ hns3_config_rss_filter(struct rte_eth_dev *dev, if (rss_flow_conf.key_len && rss_flow_conf.key_len > RTE_DIM(rss_info->key)) { hns3_err(hw, - "input hash key(%u) greater than supported len(%lu)", + "input hash key(%u) greater than supported len(%zu)", rss_flow_conf.key_len, RTE_DIM(rss_info->key)); return -EINVAL; } [2] In file included from .../drivers/net/hns3/hns3_flow.c:12: .../drivers/net/hns3/hns3_flow.c: In function ‘hns3_config_rss_filter’: .../drivers/net/hns3/hns3_logs.h:16:38: error: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 7 has type ‘unsigned int’ [-Werror=format=] 16 | rte_log(level, hns3_logtype_driver, "%s %s(): " fmt, \ | ^~~~~~~~~~~ .../drivers/net/hns3/hns3_logs.h:20:2: note: in expansion of macro ‘PMD_DRV_LOG_RAW’ 20 | PMD_DRV_LOG_RAW(hw, RTE_LOG_ERR, fmt "\n", ## args) | ^~~~~~~~~~~~~~~ .../drivers/net/hns3/hns3_flow.c:1480:3: note: in expansion of macro ‘hns3_err’ 1480 | hns3_err(hw, | ^~~~~~~~ .../drivers/net/hns3/hns3_flow.c:1481:53: note: format string is defined here 1481 | "input hash key(%u) greater than supported len(%lu)", | ~~^ | | | long unsigned int | %u cc1: all warnings being treated as errors
Hi, Ferruh Yigit On 2020/5/27 23:36, Ferruh Yigit wrote: > On 5/22/2020 10:21 AM, Wei Hu (Xavier) wrote: >> This series are improvement and bugfixes for hns3 PMD driver. >> >> Chengchang Tang (2): >> net/hns3: replace PF vport id zero with private macro >> net/hns3: fix promiscuous config not clear for PF on uninit >> >> Lijun Ou (2): >> net/hns3: add RSS hash offload to port Rx configuration >> net/hns3: fix key length when configuring RSS >> >> Wei Hu (Xavier) (1): >> net/hns3: fix preparing sending packets less than 60 bytes >> > Series applied to dpdk-next-net/master, thanks. > > A minor modification done [1] to fix 32-bit build error [2]. > > > [1] > diff --git a/drivers/net/hns3/hns3_flow.c b/drivers/net/hns3/hns3_flow.c > index e3c239286a..c7851b235c 100644 > --- a/drivers/net/hns3/hns3_flow.c > +++ b/drivers/net/hns3/hns3_flow.c > @@ -1478,7 +1478,7 @@ hns3_config_rss_filter(struct rte_eth_dev *dev, > if (rss_flow_conf.key_len && > rss_flow_conf.key_len > RTE_DIM(rss_info->key)) { > hns3_err(hw, > - "input hash key(%u) greater than supported len(%lu)", > + "input hash key(%u) greater than supported len(%zu)", > rss_flow_conf.key_len, RTE_DIM(rss_info->key)); > return -EINVAL; > } > > > > [2] > In file included from .../drivers/net/hns3/hns3_flow.c:12: > .../drivers/net/hns3/hns3_flow.c: In function ‘hns3_config_rss_filter’: > .../drivers/net/hns3/hns3_logs.h:16:38: error: format ‘%lu’ expects argument of > type ‘long unsigned int’, but argument 7 has type ‘unsigned int’ [-Werror=format=] > 16 | rte_log(level, hns3_logtype_driver, "%s %s(): " fmt, \ > | ^~~~~~~~~~~ > .../drivers/net/hns3/hns3_logs.h:20:2: note: in expansion of macro ‘PMD_DRV_LOG_RAW’ > 20 | PMD_DRV_LOG_RAW(hw, RTE_LOG_ERR, fmt "\n", ## args) > | ^~~~~~~~~~~~~~~ > .../drivers/net/hns3/hns3_flow.c:1480:3: note: in expansion of macro ‘hns3_err’ > 1480 | hns3_err(hw, > | ^~~~~~~~ > .../drivers/net/hns3/hns3_flow.c:1481:53: note: format string is defined here > 1481 | "input hash key(%u) greater than supported len(%lu)", > | ~~^ > | | > | long unsigned int > | %u > cc1: all warnings being treated as errors > > Thank you very much! Xavier