Message ID | 20200909210807.55311-1-ohilyard@iol.unh.edu (mailing list archive) |
---|---|
State | Superseded |
Headers |
Return-Path: <dts-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C0D47A04B5; Wed, 9 Sep 2020 23:08:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7B1EA1BE0C; Wed, 9 Sep 2020 23:08:14 +0200 (CEST) Received: from mail-qk1-f171.google.com (mail-qk1-f171.google.com [209.85.222.171]) by dpdk.org (Postfix) with ESMTP id 9452E1DB8 for <dts@dpdk.org>; Wed, 9 Sep 2020 23:08:12 +0200 (CEST) Received: by mail-qk1-f171.google.com with SMTP id 16so3917144qkf.4 for <dts@dpdk.org>; Wed, 09 Sep 2020 14:08:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=48QuKTBfU7aM9Z5OtZ96LGB+MkBPqx5/Ouxj6n4HHXQ=; b=Jk1KGMDkPHVDHaHPQy9wWpqjYUG2jASUYEO+FO0A5NQrthC6r7sZHUWSH21bOPIj7Y lovcburdKTdSaB9SYRu+bTTQ6cz/cfszQVqx051NgXVpYf1osbmBvrJzZMyjkcMJlf4W k1zIkrVNUTqB+qIDz0l8MsL14MhUbjkLZCVIw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=48QuKTBfU7aM9Z5OtZ96LGB+MkBPqx5/Ouxj6n4HHXQ=; b=K3bOLxy1xY4ceaEE4eY808bZ7Aqsrni1xRycxx1CUNK0mXhFeNczdFqRPuJc0YyDm7 errW0nhSv64lC+xlN0vIqeJEu9zRNNoKYYF2fygzpCNT8Hw1Gs+I7dJK6jkAlmelzM3w lDRdF159Z46BusFjfjUpGbM1pADe4Hajs6AGFELwKKWBBIsweu2qU2guI+32MEdL35gx QcFJcPTy/hhdfDnsvfcusdsVaAskLhV9AAE2qxp2fA/rctG7U2fjicistDwE+5OKuF+V e0RvavM2y1uIczvRnEOU1IJViN1CZ1ANZ3Lp591DleC3+YynxDWOie30NkuK+xmPCLon FHTw== X-Gm-Message-State: AOAM53079YwCp+y9mAG9Z6GYuayGkICAl8I+vYZn5Gm08P6UMWm7Ymbr /ESQWV9xDjJlruOwFctLuBKJOqdKWPJP0FBIWPTN6Qdgz9SX4WP1u2CJyVjCmDRQdS7yMafSMvI QQiva6fvSesepj2G5yHmJtV3yOy4jZpnMjAPXP2/1YRgb4FIS33Eql135Gw== X-Google-Smtp-Source: ABdhPJyMhyhqkTPGj1RpvpUGuhBZSIHBlH8yj2LcH3gW8ZXHEqIQL/WUcIoan5hwbzhFFHRcpkJv2A== X-Received: by 2002:a05:620a:13f6:: with SMTP id h22mr5305198qkl.9.1599685691722; Wed, 09 Sep 2020 14:08:11 -0700 (PDT) Received: from ohilyard-Alienware-m17.unh.edu (nt-238-68.w4.unh.edu. [132.177.238.68]) by smtp.googlemail.com with ESMTPSA id o2sm3973059qkk.42.2020.09.09.14.08.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Sep 2020 14:08:11 -0700 (PDT) From: Owen Hilyard <ohilyard@iol.unh.edu> To: dts@dpdk.org, lihongx.ma@intel.com Cc: ohilyard@iol.unh.edu, lylavoie@iol.unh.edu Date: Wed, 9 Sep 2020 17:08:06 -0400 Message-Id: <20200909210807.55311-1-ohilyard@iol.unh.edu> X-Mailer: git-send-email 2.25.1 In-Reply-To: <BN8PR11MB3715526029F2FC27401578269E260@BN8PR11MB3715.namprd11.prod.outlook.com> References: <BN8PR11MB3715526029F2FC27401578269E260@BN8PR11MB3715.namprd11.prod.outlook.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dts] [PATCH V1] tests/checksum_offload: Bugfix for bug 529 X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions <dts.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dts>, <mailto:dts-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dts/> List-Post: <mailto:dts@dpdk.org> List-Help: <mailto:dts-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dts>, <mailto:dts-request@dpdk.org?subject=subscribe> Errors-To: dts-bounces@dpdk.org Sender: "dts" <dts-bounces@dpdk.org> |
Series |
[V1] tests/checksum_offload: Bugfix for bug 529
|
|
Commit Message
Owen Hilyard
Sept. 9, 2020, 9:08 p.m. UTC
added missing quote in template for scapy packets.
rearraged closing down scapy and testpmd to avoid issues with other test
cases.
Signed-off-by: Owen Hilyard <ohilyard@iol.unh.edu>
---
tests/TestSuite_checksum_offload.py | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
Comments
Hello Ma,lihong, While I was re-testing the entire suite to get the test log file for you, I found a few more issues that occur when running the entire test suite at once. I've included fixes for these but apparently checkpatch doesn't like something about the patch, so I'll resubmit. Sorry about that. I've included the log file after stripping some of the output. Due to how the test was constructed, I wasn't able to use the normal method to run scapy and had to do it through send_expect, which means that all of the colorings in the shell were logged. I've done my best to remove all of the lines with color symbols in them since they aren't needed to understand the output. Sorry about messing up the submission again, Owen On Wed, Sep 9, 2020 at 5:08 PM Owen Hilyard <ohilyard@iol.unh.edu> wrote: > added missing quote in template for scapy packets. > rearraged closing down scapy and testpmd to avoid issues with other test > cases. > > Signed-off-by: Owen Hilyard <ohilyard@iol.unh.edu> > --- > tests/TestSuite_checksum_offload.py | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/tests/TestSuite_checksum_offload.py > b/tests/TestSuite_checksum_offload.py > index c4a877d..f2e9878 100644 > --- a/tests/TestSuite_checksum_offload.py > +++ b/tests/TestSuite_checksum_offload.py > @@ -374,7 +374,7 @@ class TestChecksumOffload(TestCase): > def replay_pcap_file_on_tester(self, iface, packet_file_path): > self.tester.send_expect("scapy", ">>>") > self.scapy_exec(f"packets = rdpcap('{packet_file_path}')") > - self.scapy_exec(f"sendp(packets, iface={iface})") > + self.scapy_exec(f"sendp(packets, iface='{iface}')") > self.tester.send_expect("quit()", "# ") > > def validate_packet_list_checksums(self, packets): > @@ -703,7 +703,7 @@ class TestChecksumOffload(TestCase): > for l4 in l4_protos: > for chksum in "", "chksum=0xf": > vf = > self.send_pkt_expect_good_bad_from_flag_catch_failure( > - f"eth/IP({chksum})/{l4}()/(X'*50)", > + f"eth/IP({chksum})/{l4}()/('X'*50)", > "PKT_RX_IP_CKSUM_", f"{l4}", > should_pass=(chksum == "")) > if vf is not None: > @@ -846,14 +846,13 @@ class TestChecksumOffload(TestCase): > # if vf is not None: > # verification_errors.append(vf) > > - # tunneled inner > + self.tester.send_expect("quit", "#") > + self.dut.send_expect("stop", "testpmd>") > > for err in verification_errors: > self.logger.error(str(err)) > self.verify(len(verification_errors) == 0, "See previous output") > > - self.tester.send_expect("quit", "#") > - self.dut.send_expect("stop", "testpmd>") > > def test_hardware_checksum_check_l4_tx(self): > self.checksum_enablehw(self.dut_ports[0]) > @@ -887,7 +886,9 @@ class TestChecksumOffload(TestCase): > > error_messages = > self.validate_packet_list_checksums(captured_packets) > > + self.tester.send_expect("quit", "#") > self.dut.send_expect("stop", "testpmd>") > + > if len(error_messages) != 0: > for error_msg in error_messages: > self.logger.error(error_msg) > -- > 2.25.1 > >
Thanks response of that, in the log file, I find the result of new cases test_hardware_checksum_check_l4_rx and test_hardware_checksum_check_l4_tx are failed, Is it expected result of now or there is bug of it ? Regards, Ma,lihong From: Owen Hilyard <ohilyard@iol.unh.edu> Sent: Thursday, September 10, 2020 5:14 AM To: dts@dpdk.org; Ma, LihongX <lihongx.ma@intel.com> Cc: Lincoln Lavoie <lylavoie@iol.unh.edu> Subject: Re: [PATCH V1] tests/checksum_offload: Bugfix for bug 529 Hello Ma,lihong, While I was re-testing the entire suite to get the test log file for you, I found a few more issues that occur when running the entire test suite at once. I've included fixes for these but apparently checkpatch doesn't like something about the patch, so I'll resubmit. Sorry about that. I've included the log file after stripping some of the output. Due to how the test was constructed, I wasn't able to use the normal method to run scapy and had to do it through send_expect, which means that all of the colorings in the shell were logged. I've done my best to remove all of the lines with color symbols in them since they aren't needed to understand the output. Sorry about messing up the submission again, Owen On Wed, Sep 9, 2020 at 5:08 PM Owen Hilyard <ohilyard@iol.unh.edu<mailto:ohilyard@iol.unh.edu>> wrote: added missing quote in template for scapy packets. rearraged closing down scapy and testpmd to avoid issues with other test cases. Signed-off-by: Owen Hilyard <ohilyard@iol.unh.edu<mailto:ohilyard@iol.unh.edu>> --- tests/TestSuite_checksum_offload.py | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/tests/TestSuite_checksum_offload.py b/tests/TestSuite_checksum_offload.py index c4a877d..f2e9878 100644 --- a/tests/TestSuite_checksum_offload.py +++ b/tests/TestSuite_checksum_offload.py @@ -374,7 +374,7 @@ class TestChecksumOffload(TestCase): def replay_pcap_file_on_tester(self, iface, packet_file_path): self.tester.send_expect("scapy", ">>>") self.scapy_exec(f"packets = rdpcap('{packet_file_path}')") - self.scapy_exec(f"sendp(packets, iface={iface})") + self.scapy_exec(f"sendp(packets, iface='{iface}')") self.tester.send_expect("quit()", "# ") def validate_packet_list_checksums(self, packets): @@ -703,7 +703,7 @@ class TestChecksumOffload(TestCase): for l4 in l4_protos: for chksum in "", "chksum=0xf": vf = self.send_pkt_expect_good_bad_from_flag_catch_failure( - f"eth/IP({chksum})/{l4}()/(X'*50)", + f"eth/IP({chksum})/{l4}()/('X'*50)", "PKT_RX_IP_CKSUM_", f"{l4}", should_pass=(chksum == "")) if vf is not None: @@ -846,14 +846,13 @@ class TestChecksumOffload(TestCase): # if vf is not None: # verification_errors.append(vf) - # tunneled inner + self.tester.send_expect("quit", "#") + self.dut.send_expect("stop", "testpmd>") for err in verification_errors: self.logger.error(str(err)) self.verify(len(verification_errors) == 0, "See previous output") - self.tester.send_expect("quit", "#") - self.dut.send_expect("stop", "testpmd>") def test_hardware_checksum_check_l4_tx(self): self.checksum_enablehw(self.dut_ports[0]) @@ -887,7 +886,9 @@ class TestChecksumOffload(TestCase): error_messages = self.validate_packet_list_checksums(captured_packets) + self.tester.send_expect("quit", "#") self.dut.send_expect("stop", "testpmd>") + if len(error_messages) != 0: for error_msg in error_messages: self.logger.error(error_msg) -- 2.25.1
BTW, it is better increase the version number when we submit a new version of the patch, it will easy to know the latest version of the patch. eg: V1 ,V2, V3 …. Regards, Ma,lihong From: Ma, LihongX Sent: Thursday, September 10, 2020 9:46 AM To: Owen Hilyard <ohilyard@iol.unh.edu>; dts@dpdk.org Cc: Lincoln Lavoie <lylavoie@iol.unh.edu> Subject: RE: [PATCH V1] tests/checksum_offload: Bugfix for bug 529 Thanks response of that, in the log file, I find the result of new cases test_hardware_checksum_check_l4_rx and test_hardware_checksum_check_l4_tx are failed, Is it expected result of now or there is bug of it ? Regards, Ma,lihong From: Owen Hilyard <ohilyard@iol.unh.edu<mailto:ohilyard@iol.unh.edu>> Sent: Thursday, September 10, 2020 5:14 AM To: dts@dpdk.org<mailto:dts@dpdk.org>; Ma, LihongX <lihongx.ma@intel.com<mailto:lihongx.ma@intel.com>> Cc: Lincoln Lavoie <lylavoie@iol.unh.edu<mailto:lylavoie@iol.unh.edu>> Subject: Re: [PATCH V1] tests/checksum_offload: Bugfix for bug 529 Hello Ma,lihong, While I was re-testing the entire suite to get the test log file for you, I found a few more issues that occur when running the entire test suite at once. I've included fixes for these but apparently checkpatch doesn't like something about the patch, so I'll resubmit. Sorry about that. I've included the log file after stripping some of the output. Due to how the test was constructed, I wasn't able to use the normal method to run scapy and had to do it through send_expect, which means that all of the colorings in the shell were logged. I've done my best to remove all of the lines with color symbols in them since they aren't needed to understand the output. Sorry about messing up the submission again, Owen On Wed, Sep 9, 2020 at 5:08 PM Owen Hilyard <ohilyard@iol.unh.edu<mailto:ohilyard@iol.unh.edu>> wrote: added missing quote in template for scapy packets. rearraged closing down scapy and testpmd to avoid issues with other test cases. Signed-off-by: Owen Hilyard <ohilyard@iol.unh.edu<mailto:ohilyard@iol.unh.edu>> --- tests/TestSuite_checksum_offload.py | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/tests/TestSuite_checksum_offload.py b/tests/TestSuite_checksum_offload.py index c4a877d..f2e9878 100644 --- a/tests/TestSuite_checksum_offload.py +++ b/tests/TestSuite_checksum_offload.py @@ -374,7 +374,7 @@ class TestChecksumOffload(TestCase): def replay_pcap_file_on_tester(self, iface, packet_file_path): self.tester.send_expect("scapy", ">>>") self.scapy_exec(f"packets = rdpcap('{packet_file_path}')") - self.scapy_exec(f"sendp(packets, iface={iface})") + self.scapy_exec(f"sendp(packets, iface='{iface}')") self.tester.send_expect("quit()", "# ") def validate_packet_list_checksums(self, packets): @@ -703,7 +703,7 @@ class TestChecksumOffload(TestCase): for l4 in l4_protos: for chksum in "", "chksum=0xf": vf = self.send_pkt_expect_good_bad_from_flag_catch_failure( - f"eth/IP({chksum})/{l4}()/(X'*50)", + f"eth/IP({chksum})/{l4}()/('X'*50)", "PKT_RX_IP_CKSUM_", f"{l4}", should_pass=(chksum == "")) if vf is not None: @@ -846,14 +846,13 @@ class TestChecksumOffload(TestCase): # if vf is not None: # verification_errors.append(vf) - # tunneled inner + self.tester.send_expect("quit", "#") + self.dut.send_expect("stop", "testpmd>") for err in verification_errors: self.logger.error(str(err)) self.verify(len(verification_errors) == 0, "See previous output") - self.tester.send_expect("quit", "#") - self.dut.send_expect("stop", "testpmd>") def test_hardware_checksum_check_l4_tx(self): self.checksum_enablehw(self.dut_ports[0]) @@ -887,7 +886,9 @@ class TestChecksumOffload(TestCase): error_messages = self.validate_packet_list_checksums(captured_packets) + self.tester.send_expect("quit", "#") self.dut.send_expect("stop", "testpmd>") + if len(error_messages) != 0: for error_msg in error_messages: self.logger.error(error_msg) -- 2.25.1
With regards to the failed test cases, that is expected behavior for the machine I was running it on. The NIC in the dev machine the IOL team is using is running i40e and the support is P in the compatibility table, and I'm fairly sure our NIC doesn't support inner checksum offloads but does support outer checksum offloads. I'll try to remember to increment the version number if I need more than 1 patch again. Thanks, Owen Hilyard On Wed, Sep 9, 2020 at 9:51 PM Ma, LihongX <lihongx.ma@intel.com> wrote: > BTW, it is better increase the version number when we submit a new version > of the patch, it will easy to know the latest version of the patch. eg: V1 > ,V2, V3 …. > > > > Regards, > > Ma,lihong > > > > *From:* Ma, LihongX > *Sent:* Thursday, September 10, 2020 9:46 AM > *To:* Owen Hilyard <ohilyard@iol.unh.edu>; dts@dpdk.org > *Cc:* Lincoln Lavoie <lylavoie@iol.unh.edu> > *Subject:* RE: [PATCH V1] tests/checksum_offload: Bugfix for bug 529 > > > > Thanks response of that, in the log file, I find the result of new cases > test_hardware_checksum_check_l4_rx and test_hardware_checksum_check_l4_tx > are failed, > > Is it expected result of now or there is bug of it ? > > > > Regards, > > Ma,lihong > > > > *From:* Owen Hilyard <ohilyard@iol.unh.edu> > *Sent:* Thursday, September 10, 2020 5:14 AM > *To:* dts@dpdk.org; Ma, LihongX <lihongx.ma@intel.com> > *Cc:* Lincoln Lavoie <lylavoie@iol.unh.edu> > *Subject:* Re: [PATCH V1] tests/checksum_offload: Bugfix for bug 529 > > > > Hello Ma,lihong, > > > > While I was re-testing the entire suite to get the test log file for you, > I found a few more issues that occur when running the entire test suite at > once. I've included fixes for these but apparently checkpatch doesn't like > something about the patch, so I'll resubmit. Sorry about that. I've > included the log file after stripping some of the output. Due to how the > test was constructed, I wasn't able to use the normal method to run scapy > and had to do it through send_expect, which means that all of the colorings > in the shell were logged. I've done my best to remove all of the lines with > color symbols in them since they aren't needed to understand the output. > > > > Sorry about messing up the submission again, > > Owen > > > > On Wed, Sep 9, 2020 at 5:08 PM Owen Hilyard <ohilyard@iol.unh.edu> wrote: > > added missing quote in template for scapy packets. > rearraged closing down scapy and testpmd to avoid issues with other test > cases. > > Signed-off-by: Owen Hilyard <ohilyard@iol.unh.edu> > --- > tests/TestSuite_checksum_offload.py | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/tests/TestSuite_checksum_offload.py > b/tests/TestSuite_checksum_offload.py > index c4a877d..f2e9878 100644 > --- a/tests/TestSuite_checksum_offload.py > +++ b/tests/TestSuite_checksum_offload.py > @@ -374,7 +374,7 @@ class TestChecksumOffload(TestCase): > def replay_pcap_file_on_tester(self, iface, packet_file_path): > self.tester.send_expect("scapy", ">>>") > self.scapy_exec(f"packets = rdpcap('{packet_file_path}')") > - self.scapy_exec(f"sendp(packets, iface={iface})") > + self.scapy_exec(f"sendp(packets, iface='{iface}')") > self.tester.send_expect("quit()", "# ") > > def validate_packet_list_checksums(self, packets): > @@ -703,7 +703,7 @@ class TestChecksumOffload(TestCase): > for l4 in l4_protos: > for chksum in "", "chksum=0xf": > vf = > self.send_pkt_expect_good_bad_from_flag_catch_failure( > - f"eth/IP({chksum})/{l4}()/(X'*50)", > + f"eth/IP({chksum})/{l4}()/('X'*50)", > "PKT_RX_IP_CKSUM_", f"{l4}", > should_pass=(chksum == "")) > if vf is not None: > @@ -846,14 +846,13 @@ class TestChecksumOffload(TestCase): > # if vf is not None: > # verification_errors.append(vf) > > - # tunneled inner > + self.tester.send_expect("quit", "#") > + self.dut.send_expect("stop", "testpmd>") > > for err in verification_errors: > self.logger.error(str(err)) > self.verify(len(verification_errors) == 0, "See previous output") > > - self.tester.send_expect("quit", "#") > - self.dut.send_expect("stop", "testpmd>") > > def test_hardware_checksum_check_l4_tx(self): > self.checksum_enablehw(self.dut_ports[0]) > @@ -887,7 +886,9 @@ class TestChecksumOffload(TestCase): > > error_messages = > self.validate_packet_list_checksums(captured_packets) > > + self.tester.send_expect("quit", "#") > self.dut.send_expect("stop", "testpmd>") > + > if len(error_messages) != 0: > for error_msg in error_messages: > self.logger.error(error_msg) > -- > 2.25.1 > >
diff --git a/tests/TestSuite_checksum_offload.py b/tests/TestSuite_checksum_offload.py index c4a877d..f2e9878 100644 --- a/tests/TestSuite_checksum_offload.py +++ b/tests/TestSuite_checksum_offload.py @@ -374,7 +374,7 @@ class TestChecksumOffload(TestCase): def replay_pcap_file_on_tester(self, iface, packet_file_path): self.tester.send_expect("scapy", ">>>") self.scapy_exec(f"packets = rdpcap('{packet_file_path}')") - self.scapy_exec(f"sendp(packets, iface={iface})") + self.scapy_exec(f"sendp(packets, iface='{iface}')") self.tester.send_expect("quit()", "# ") def validate_packet_list_checksums(self, packets): @@ -703,7 +703,7 @@ class TestChecksumOffload(TestCase): for l4 in l4_protos: for chksum in "", "chksum=0xf": vf = self.send_pkt_expect_good_bad_from_flag_catch_failure( - f"eth/IP({chksum})/{l4}()/(X'*50)", + f"eth/IP({chksum})/{l4}()/('X'*50)", "PKT_RX_IP_CKSUM_", f"{l4}", should_pass=(chksum == "")) if vf is not None: @@ -846,14 +846,13 @@ class TestChecksumOffload(TestCase): # if vf is not None: # verification_errors.append(vf) - # tunneled inner + self.tester.send_expect("quit", "#") + self.dut.send_expect("stop", "testpmd>") for err in verification_errors: self.logger.error(str(err)) self.verify(len(verification_errors) == 0, "See previous output") - self.tester.send_expect("quit", "#") - self.dut.send_expect("stop", "testpmd>") def test_hardware_checksum_check_l4_tx(self): self.checksum_enablehw(self.dut_ports[0]) @@ -887,7 +886,9 @@ class TestChecksumOffload(TestCase): error_messages = self.validate_packet_list_checksums(captured_packets) + self.tester.send_expect("quit", "#") self.dut.send_expect("stop", "testpmd>") + if len(error_messages) != 0: for error_msg in error_messages: self.logger.error(error_msg)