devtools: add llx format specifier check
Checks
Commit Message
%llx tends to be wrong when used for fixed size, like uint64_t,
variables, adding a warning to double check them.
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
Cc: David Marchand <david.marchand@redhat.com>
Cc: Aaron Conole <aconole@redhat.com>
---
devtools/checkpatches.sh | 8 ++++++++
1 file changed, 8 insertions(+)
Comments
09/02/2021 16:26, Ferruh Yigit:
> %llx tends to be wrong when used for fixed size, like uint64_t,
> variables, adding a warning to double check them.
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> + # check %llx usage
> + awk -v FOLDERS='lib drivers app examples' \
> + -v EXPRESSIONS='%ll*[xud]' \
> + -v RET_ON_FAIL=1 \
> + -v MESSAGE='Please check %llx usage which tends to be wrong most of the times' \
+1
It reminds me this old email:
http://mails.dpdk.org/archives/dev/2018-February/091483.html
The title mentions llx, but it should be %ll in general:
devtools: check %ll format specifier
@@ -118,6 +118,14 @@ check_forbidden_additions() { # <patch>
-f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \
"$1" || res=1
+ # check %llx usage
+ awk -v FOLDERS='lib drivers app examples' \
+ -v EXPRESSIONS='%ll*[xud]' \
+ -v RET_ON_FAIL=1 \
+ -v MESSAGE='Please check %llx usage which tends to be wrong most of the times' \
+ -f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \
+ "$1" || res=1
+
# svg figures must be included with wildcard extension
# because of png conversion for pdf docs
awk -v FOLDERS='doc' \