drivers: add missing headers
Checks
Commit Message
These headers are used but not included explicitly, including them.
"arpa/inet.h" is included for 'htons' and friends.
"netinet/in.h" is included for 'IPPROTO_IP'.
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
drivers/crypto/dpaa_sec/dpaa_sec.c | 1 +
drivers/event/octeontx/ssovf_worker.h | 2 ++
drivers/net/bnx2x/bnx2x.c | 1 +
drivers/net/igc/igc_ethdev.h | 1 +
drivers/net/igc/igc_txrx.c | 1 +
drivers/net/netvsc/hn_ethdev.c | 1 +
drivers/net/nfb/nfb_rx.h | 1 +
drivers/net/pcap/rte_eth_pcap.c | 1 +
drivers/net/pfe/pfe_hal.c | 2 ++
drivers/net/pfe/pfe_hif.c | 1 +
drivers/net/sfc/sfc_tso.h | 2 ++
drivers/net/vmxnet3/vmxnet3_ethdev.h | 1 +
12 files changed, 15 insertions(+)
Comments
On 3/26/2021 4:46 PM, Ferruh Yigit wrote:
> These headers are used but not included explicitly, including them.
>
> "arpa/inet.h" is included for 'htons' and friends.
> "netinet/in.h" is included for 'IPPROTO_IP'.
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Any comment/review?
On 3/26/21 7:46 PM, Ferruh Yigit wrote:
> These headers are used but not included explicitly, including them.
>
> "arpa/inet.h" is included for 'htons' and friends.
> "netinet/in.h" is included for 'IPPROTO_IP'.
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Sent: Tuesday, April 13, 2021 3:34 PM
>
> External Email
>
> ----------------------------------------------------------------------
> On 3/26/2021 4:46 PM, Ferruh Yigit wrote:
> > These headers are used but not included explicitly, including them.
> >
> > "arpa/inet.h" is included for 'htons' and friends.
> > "netinet/in.h" is included for 'IPPROTO_IP'.
> >
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> Any comment/review?
Acked-by: Rasesh Mody <rmody@marvell.com>
On 4/13/2021 11:31 AM, Andrew Rybchenko wrote:
> On 3/26/21 7:46 PM, Ferruh Yigit wrote:
>> These headers are used but not included explicitly, including them.
>>
>> "arpa/inet.h" is included for 'htons' and friends.
>> "netinet/in.h" is included for 'IPPROTO_IP'.
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
>
Applied to dpdk-next-net/main, thanks.
@@ -20,6 +20,7 @@
#endif
#include <rte_cycles.h>
#include <rte_dev.h>
+#include <rte_ip.h>
#include <rte_kvargs.h>
#include <rte_malloc.h>
#include <rte_mbuf.h>
@@ -2,6 +2,8 @@
* Copyright(c) 2017 Cavium, Inc
*/
+#include <arpa/inet.h>
+
#include <rte_common.h>
#include <rte_branch_prediction.h>
@@ -23,6 +23,7 @@
#include <sys/types.h>
#include <sys/stat.h>
+#include <arpa/inet.h>
#include <fcntl.h>
#include <zlib.h>
#include <rte_bitops.h>
@@ -6,6 +6,7 @@
#define _IGC_ETHDEV_H_
#include <rte_ethdev.h>
+#include <rte_flow.h>
#include "base/igc_osdep.h"
#include "base/igc_hw.h"
@@ -3,6 +3,7 @@
*/
#include <rte_config.h>
+#include <rte_flow.h>
#include <rte_malloc.h>
#include <ethdev_driver.h>
#include <rte_net.h>
@@ -12,6 +12,7 @@
#include <dirent.h>
#include <net/if.h>
#include <net/if_arp.h>
+#include <netinet/in.h>
#include <sys/ioctl.h>
#include <rte_ethdev.h>
@@ -11,6 +11,7 @@
#include <nfb/ndp.h>
#include <rte_mbuf.h>
+#include <rte_mbuf_dyn.h>
#include <rte_ethdev.h>
#define NFB_TIMESTAMP_FLAG (1 << 0)
@@ -24,6 +24,7 @@
#include <rte_kvargs.h>
#include <rte_malloc.h>
#include <rte_mbuf.h>
+#include <rte_mbuf_dyn.h>
#include <rte_bus_vdev.h>
#include <rte_string_fns.h>
@@ -2,6 +2,8 @@
* Copyright 2018-2019 NXP
*/
+#include <arpa/inet.h>
+
#include "pfe_logs.h"
#include "pfe_mod.h"
@@ -7,6 +7,7 @@
#include <sys/ioctl.h>
#include <sys/epoll.h>
#include <sys/eventfd.h>
+#include <arpa/inet.h>
static int
pfe_hif_alloc_descr(struct pfe_hif *hif)
@@ -10,6 +10,8 @@
#ifndef _SFC_TSO_H
#define _SFC_TSO_H
+#include <rte_udp.h>
+
#ifdef __cplusplus
extern "C" {
#endif
@@ -6,6 +6,7 @@
#define _VMXNET3_ETHDEV_H_
#include <rte_io.h>
+#include <rte_mbuf_dyn.h>
#define VMXNET3_MAX_MAC_ADDRS 1