[v4,0/6] net: ngbe PMD

  This patch set provides a skeleton of ngbe PMD,
which adapted to Wangxun WX1860 series NICs.

v4:
- Fix compile error.

v3:
- Use rte_ether functions to define marcos.

v2:
- Correct some clerical errors.
- Use ethdev debug flags instead of driver own.

Jiawen Wu (6):
  net/ngbe: add build and doc infrastructure
  net/ngbe: add device IDs
  net/ngbe: support probe and remove
  net/ngbe: add device init and uninit
  net/ngbe: add log type and error type
  net/ngbe: define registers

 MAINTAINERS                            |    6 +
 doc/guides/nics/features/ngbe.ini      |   11 +
 doc/guides/nics/index.rst              |    1 +
 doc/guides/nics/ngbe.rst               |   48 +
 doc/guides/rel_notes/release_21_05.rst |    6 +
 drivers/net/meson.build                |    1 +
 drivers/net/ngbe/base/meson.build      |   20 +
 drivers/net/ngbe/base/ngbe.h           |   11 +
 drivers/net/ngbe/base/ngbe_devids.h    |   83 ++
 drivers/net/ngbe/base/ngbe_hw.c        |   59 +
 drivers/net/ngbe/base/ngbe_hw.h        |   12 +
 drivers/net/ngbe/base/ngbe_osdep.h     |  174 +++
 drivers/net/ngbe/base/ngbe_regs.h      | 1489 ++++++++++++++++++++++++
 drivers/net/ngbe/base/ngbe_status.h    |  124 ++
 drivers/net/ngbe/base/ngbe_type.h      |   30 +
 drivers/net/ngbe/meson.build           |   18 +
 drivers/net/ngbe/ngbe_ethdev.c         |  156 +++
 drivers/net/ngbe/ngbe_ethdev.h         |   21 +
 drivers/net/ngbe/ngbe_logs.h           |   45 +
 drivers/net/ngbe/version.map           |    3 +
 20 files changed, 2318 insertions(+)
 create mode 100644 doc/guides/nics/features/ngbe.ini
 create mode 100644 doc/guides/nics/ngbe.rst
 create mode 100644 drivers/net/ngbe/base/meson.build
 create mode 100644 drivers/net/ngbe/base/ngbe.h
 create mode 100644 drivers/net/ngbe/base/ngbe_devids.h
 create mode 100644 drivers/net/ngbe/base/ngbe_hw.c
 create mode 100644 drivers/net/ngbe/base/ngbe_hw.h
 create mode 100644 drivers/net/ngbe/base/ngbe_osdep.h
 create mode 100644 drivers/net/ngbe/base/ngbe_regs.h
 create mode 100644 drivers/net/ngbe/base/ngbe_status.h
 create mode 100644 drivers/net/ngbe/base/ngbe_type.h
 create mode 100644 drivers/net/ngbe/meson.build
 create mode 100644 drivers/net/ngbe/ngbe_ethdev.c
 create mode 100644 drivers/net/ngbe/ngbe_ethdev.h
 create mode 100644 drivers/net/ngbe/ngbe_logs.h
 create mode 100644 drivers/net/ngbe/version.map
  

On 4/6/2021 10:30 AM, Jiawen Wu wrote:
> This patch set provides a skeleton of ngbe PMD,
> which adapted to Wangxun WX1860 series NICs.
> 
> v4:
> - Fix compile error.
> 
> v3:
> - Use rte_ether functions to define marcos.
> 
> v2:
> - Correct some clerical errors.
> - Use ethdev debug flags instead of driver own.
> 
> Jiawen Wu (6):
>    net/ngbe: add build and doc infrastructure
>    net/ngbe: add device IDs
>    net/ngbe: support probe and remove
>    net/ngbe: add device init and uninit
>    net/ngbe: add log type and error type
>    net/ngbe: define registers
> 

Hi Jiawen,

I put some comments on some patches, but as far as I can see the device is not 
functional yet after this set, I assume rest of the support will be submitted later.
But I think the device should have at least bare minimum functionality when it 
is upstreamed, like proper device initialization and primitive Rx/Tx, also it 
would be good to have basic control functions.
More control and datapath functionality can be added gradually later.

What do you think extending this set to have base minimum functionality?

Thanks,
ferruh
  

On Friday, April 9, 2021 10:47 PM, Ferruh Yigit wrote:
> On 4/6/2021 10:30 AM, Jiawen Wu wrote:
> > This patch set provides a skeleton of ngbe PMD, which adapted to
> > Wangxun WX1860 series NICs.
> >
> > v4:
> > - Fix compile error.
> >
> > v3:
> > - Use rte_ether functions to define marcos.
> >
> > v2:
> > - Correct some clerical errors.
> > - Use ethdev debug flags instead of driver own.
> >
> > Jiawen Wu (6):
> >    net/ngbe: add build and doc infrastructure
> >    net/ngbe: add device IDs
> >    net/ngbe: support probe and remove
> >    net/ngbe: add device init and uninit
> >    net/ngbe: add log type and error type
> >    net/ngbe: define registers
> >
> 
> Hi Jiawen,
> 
> I put some comments on some patches, but as far as I can see the device is not
> functional yet after this set, I assume rest of the support will be submitted
> later.
> But I think the device should have at least bare minimum functionality when it
> is upstreamed, like proper device initialization and primitive Rx/Tx, also it would
> be good to have basic control functions.
> More control and datapath functionality can be added gradually later.
> 
> What do you think extending this set to have base minimum functionality?
> 
> Thanks,
> ferruh

Hi Ferruh,

Unfortunately, this driver may not be merged in 21.05, to follow the roadmap.
There is not enough time for me to improve the patches, because I was busy with other works in these weeks.

I'll try my best to submit the driver in this release cycle, and hope it will be merged nicely in next release.

Thanks.
  

On 4/29/2021 11:52 AM, Jiawen Wu wrote:
> On Friday, April 9, 2021 10:47 PM, Ferruh Yigit wrote:
>> On 4/6/2021 10:30 AM, Jiawen Wu wrote:
>>> This patch set provides a skeleton of ngbe PMD, which adapted to
>>> Wangxun WX1860 series NICs.
>>>
>>> v4:
>>> - Fix compile error.
>>>
>>> v3:
>>> - Use rte_ether functions to define marcos.
>>>
>>> v2:
>>> - Correct some clerical errors.
>>> - Use ethdev debug flags instead of driver own.
>>>
>>> Jiawen Wu (6):
>>>    net/ngbe: add build and doc infrastructure
>>>    net/ngbe: add device IDs
>>>    net/ngbe: support probe and remove
>>>    net/ngbe: add device init and uninit
>>>    net/ngbe: add log type and error type
>>>    net/ngbe: define registers
>>>
>>
>> Hi Jiawen,
>>
>> I put some comments on some patches, but as far as I can see the device is not
>> functional yet after this set, I assume rest of the support will be submitted
>> later.
>> But I think the device should have at least bare minimum functionality when it
>> is upstreamed, like proper device initialization and primitive Rx/Tx, also it would
>> be good to have basic control functions.
>> More control and datapath functionality can be added gradually later.
>>
>> What do you think extending this set to have base minimum functionality?
>>
>> Thanks,
>> ferruh
> 
> Hi Ferruh,
> 
> Unfortunately, this driver may not be merged in 21.05, to follow the roadmap.
> There is not enough time for me to improve the patches, because I was busy with other works in these weeks.
> 
> I'll try my best to submit the driver in this release cycle, and hope it will be merged nicely in next release.
> 

That is OK, thanks for heads up.