[v9,08/10] app/testpmd: fix headers inclusion
Checks
Commit Message
- Include rte_os_shim.h in testpmd.h
- Remove redundant headers
Signed-off-by: Jie Zhou <jizh@microsoft.com>
Signed-off-by: Jie Zhou <jizh@linux.microsoft.com>
---
app/test-pmd/cmdline.c | 3 ---
app/test-pmd/cmdline_flow.c | 2 --
app/test-pmd/parameters.c | 1 -
app/test-pmd/testpmd.h | 1 +
4 files changed, 1 insertion(+), 6 deletions(-)
Comments
> Subject: [PATCH v9 08/10] app/testpmd: fix headers inclusion
>
> External email: Use caution opening links or attachments
>
>
> - Include rte_os_shim.h in testpmd.h
> - Remove redundant headers
>
> Signed-off-by: Jie Zhou <jizh@microsoft.com>
> Signed-off-by: Jie Zhou <jizh@linux.microsoft.com>
> ---
> app/test-pmd/cmdline.c | 3 ---
> app/test-pmd/cmdline_flow.c | 2 --
> app/test-pmd/parameters.c | 1 -
> app/test-pmd/testpmd.h | 1 +
> 4 files changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index
> f0636ca9b..2fbef3320 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -10,9 +10,6 @@
> #include <string.h>
> #include <unistd.h>
> #include <inttypes.h>
> -#include <sys/socket.h>
> -#include <netinet/in.h>
> -
> #include <sys/queue.h>
>
> #include <rte_common.h>
> diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
> index 888b9179b..a3cd4773a 100644
> --- a/app/test-pmd/cmdline_flow.c
> +++ b/app/test-pmd/cmdline_flow.c
> @@ -10,8 +10,6 @@
> #include <errno.h>
> #include <ctype.h>
> #include <string.h>
> -#include <arpa/inet.h>
> -#include <sys/socket.h>
>
> #include <rte_string_fns.h>
> #include <rte_common.h>
> diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c index
> 4c3cbbac3..5e69d2aa8 100644
> --- a/app/test-pmd/parameters.c
> +++ b/app/test-pmd/parameters.c
> @@ -19,7 +19,6 @@
> #include <stdint.h>
> #include <unistd.h>
> #include <inttypes.h>
> -#include <arpa/inet.h>
>
> #include <rte_common.h>
> #include <rte_byteorder.h>
> diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h index
> a4115861b..f96eec71a 100644
> --- a/app/test-pmd/testpmd.h
> +++ b/app/test-pmd/testpmd.h
> @@ -11,6 +11,7 @@
> #include <rte_bus_pci.h>
> #include <rte_gro.h>
> #include <rte_gso.h>
> +#include <rte_os_shim.h>
> #include <cmdline.h>
> #include <sys/queue.h>
>
> --
> 2.30.0.vfs.0.2
Acked-by: Tal Shnaiderman <talshn@nvidia.com>
@@ -10,9 +10,6 @@
#include <string.h>
#include <unistd.h>
#include <inttypes.h>
-#include <sys/socket.h>
-#include <netinet/in.h>
-
#include <sys/queue.h>
#include <rte_common.h>
@@ -10,8 +10,6 @@
#include <errno.h>
#include <ctype.h>
#include <string.h>
-#include <arpa/inet.h>
-#include <sys/socket.h>
#include <rte_string_fns.h>
#include <rte_common.h>
@@ -19,7 +19,6 @@
#include <stdint.h>
#include <unistd.h>
#include <inttypes.h>
-#include <arpa/inet.h>
#include <rte_common.h>
#include <rte_byteorder.h>
@@ -11,6 +11,7 @@
#include <rte_bus_pci.h>
#include <rte_gro.h>
#include <rte_gso.h>
+#include <rte_os_shim.h>
#include <cmdline.h>
#include <sys/queue.h>