[v4] doc: remove event crypto metadata deprecation note
Checks
Commit Message
Proposed change to event crypto metadata is not done as per deprecation
note. Instead, comments are updated in spec to improve readability.
Signed-off-by: Shijith Thotton <sthotton@marvell.com>
---
v4:
* Removed changes as per deprecation note.
* Updated spec comments.
v3:
* Updated ABI section of release notes.
v2:
* Updated deprecation notice.
v1:
* Rebased.
doc/guides/rel_notes/deprecation.rst | 6 ------
lib/eventdev/rte_event_crypto_adapter.h | 1 +
2 files changed, 1 insertion(+), 6 deletions(-)
Comments
Acked-by: Abhinandan Gujjar <Abhinandan.gujjar@intel.com>
> -----Original Message-----
> From: Shijith Thotton <sthotton@marvell.com>
> Sent: Monday, September 27, 2021 8:53 PM
> To: dev@dpdk.org
> Cc: Shijith Thotton <sthotton@marvell.com>; Gujjar, Abhinandan S
> <abhinandan.gujjar@intel.com>; adwivedi@marvell.com;
> anoobj@marvell.com; gakhil@marvell.com; jerinj@marvell.com;
> pbhagavatula@marvell.com
> Subject: [PATCH v4] doc: remove event crypto metadata deprecation note
>
> Proposed change to event crypto metadata is not done as per deprecation
> note. Instead, comments are updated in spec to improve readability.
>
> Signed-off-by: Shijith Thotton <sthotton@marvell.com>
> ---
> v4:
> * Removed changes as per deprecation note.
> * Updated spec comments.
>
> v3:
> * Updated ABI section of release notes.
>
> v2:
> * Updated deprecation notice.
>
> v1:
> * Rebased.
>
> doc/guides/rel_notes/deprecation.rst | 6 ------
> lib/eventdev/rte_event_crypto_adapter.h | 1 +
> 2 files changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst
> b/doc/guides/rel_notes/deprecation.rst
> index bf1e07c0a8..fae3abd282 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -254,12 +254,6 @@ Deprecation Notices
> An 8-byte reserved field will be added to the structure ``rte_event_timer``
> to
> support future extensions.
>
> -* eventdev: Reserved bytes of ``rte_event_crypto_request`` is a space
> holder
> - for ``response_info``. Both should be decoupled for better clarity.
> - New space for ``response_info`` can be made by changing
> - ``rte_event_crypto_metadata`` type to structure from union.
> - This change is targeted for DPDK 21.11.
> -
> * metrics: The function ``rte_metrics_init`` will have a non-void return
> in order to notify errors instead of calling ``rte_exit``.
>
> diff --git a/lib/eventdev/rte_event_crypto_adapter.h
> b/lib/eventdev/rte_event_crypto_adapter.h
> index 27fb628eef..edbd5c61a3 100644
> --- a/lib/eventdev/rte_event_crypto_adapter.h
> +++ b/lib/eventdev/rte_event_crypto_adapter.h
> @@ -227,6 +227,7 @@ union rte_event_crypto_metadata {
> struct rte_event_crypto_request request_info;
> /**< Request information to be filled in by application
> * for RTE_EVENT_CRYPTO_ADAPTER_OP_FORWARD mode.
> + * First 8 bytes of request_info is reserved for response_info.
> */
> struct rte_event response_info;
> /**< Response information to be filled in by application
> --
> 2.25.1
> Acked-by: Abhinandan Gujjar <Abhinandan.gujjar@intel.com>
>
Applied to dpdk-next-crypto
Thanks.
@@ -254,12 +254,6 @@ Deprecation Notices
An 8-byte reserved field will be added to the structure ``rte_event_timer`` to
support future extensions.
-* eventdev: Reserved bytes of ``rte_event_crypto_request`` is a space holder
- for ``response_info``. Both should be decoupled for better clarity.
- New space for ``response_info`` can be made by changing
- ``rte_event_crypto_metadata`` type to structure from union.
- This change is targeted for DPDK 21.11.
-
* metrics: The function ``rte_metrics_init`` will have a non-void return
in order to notify errors instead of calling ``rte_exit``.
@@ -227,6 +227,7 @@ union rte_event_crypto_metadata {
struct rte_event_crypto_request request_info;
/**< Request information to be filled in by application
* for RTE_EVENT_CRYPTO_ADAPTER_OP_FORWARD mode.
+ * First 8 bytes of request_info is reserved for response_info.
*/
struct rte_event response_info;
/**< Response information to be filled in by application