hash: fix use after free in thash
Checks
Commit Message
This patch fixes use after free in thash library, reported by ASAN.
Bugzilla ID: 868
Fixes: 28ebff11c2dc ("hash: add predictable RSS")
Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
---
lib/hash/rte_thash.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Comments
On Fri, Oct 29, 2021 at 4:55 PM Vladimir Medvedkin
<vladimir.medvedkin@intel.com> wrote:
>
> This patch fixes use after free in thash library, reported by ASAN.
>
> Bugzilla ID: 868
> Fixes: 28ebff11c2dc ("hash: add predictable RSS")
>
> Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
Reviewed-by: David Marchand <david.marchand@redhat.com>
03/11/2021 16:41, David Marchand:
> On Fri, Oct 29, 2021 at 4:55 PM Vladimir Medvedkin
> <vladimir.medvedkin@intel.com> wrote:
> >
> > This patch fixes use after free in thash library, reported by ASAN.
> >
> > Bugzilla ID: 868
> > Fixes: 28ebff11c2dc ("hash: add predictable RSS")
> >
> > Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
>
> Reviewed-by: David Marchand <david.marchand@redhat.com>
Applied, thanks.
@@ -416,10 +416,10 @@ insert_before(struct rte_thash_ctx *ctx,
return ret;
}
} else if ((next_ent != NULL) && (end > next_ent->offset)) {
- rte_free(ent);
RTE_LOG(ERR, HASH,
"Can't add helper %s due to conflict with existing"
" helper %s\n", ent->name, next_ent->name);
+ rte_free(ent);
return -ENOSPC;
}
attach_lfsr(ent, cur_ent->lfsr);
@@ -465,10 +465,10 @@ insert_after(struct rte_thash_ctx *ctx,
int ret;
if ((next_ent != NULL) && (end > next_ent->offset)) {
- rte_free(ent);
RTE_LOG(ERR, HASH,
"Can't add helper %s due to conflict with existing"
" helper %s\n", ent->name, next_ent->name);
+ rte_free(ent);
return -EEXIST;
}