diff mbox series

[v2] ip_frag: promote APIs to stable

Message ID 20211028115100.10556-1-konstantin.ananyev@intel.com (mailing list archive)
State Changes Requested, archived
Delegated to: Thomas Monjalon
Headers
Series [v2] ip_frag: promote APIs to stable |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/github-robot: build success github build: passed
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional fail Functional Testing issues

Commit Message

Ananyev, Konstantin Oct. 28, 2021, 11:51 a.m. UTC 
  Promote rte_frag_table_del_expired_entries() function to stable.
It was around for few years by now without any changes.

Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
---
 lib/ip_frag/rte_ip_frag.h | 1 -
 lib/ip_frag/version.map   | 7 +------
 2 files changed, 1 insertion(+), 7 deletions(-)

Comments

Thomas Monjalon Nov. 4, 2021, 6:24 p.m. UTC | #1 
28/10/2021 13:51, Konstantin Ananyev:
> Promote rte_frag_table_del_expired_entries() function to stable.
> It was around for few years by now without any changes.
> 
> Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> ---
>  lib/ip_frag/rte_ip_frag.h | 1 -

In general, the namespace in this file is wrong.
A lot of structs and enum don't have the correct name prefix.


> --- a/lib/ip_frag/version.map
> +++ b/lib/ip_frag/version.map
> @@ -1,6 +1,7 @@
>  DPDK_22 {
>  	global:
>  
> +	rte_frag_table_del_expired_entries;

It seems that the right name should be rte_ip_frag_table_del_expired_entries.

>  	rte_ip_frag_free_death_row;
>  	rte_ip_frag_table_create;
>  	rte_ip_frag_table_destroy;
> @@ -12,9 +13,3 @@ DPDK_22 {
>  
>  	local: *;
>  };
> -
> -EXPERIMENTAL {
> -	global:
> -
> -	rte_frag_table_del_expired_entries;
> -};

We could keep this name as experimental during an expiration period.
diff mbox series

Patch

diff --git a/lib/ip_frag/rte_ip_frag.h b/lib/ip_frag/rte_ip_frag.h
index 08555fde6a..d856f87e6c 100644
--- a/lib/ip_frag/rte_ip_frag.h
+++ b/lib/ip_frag/rte_ip_frag.h
@@ -326,7 +326,6 @@  rte_ip_frag_table_statistics_dump(FILE * f, const struct rte_ip_frag_tbl *tbl);
  * @param tms
  *   Current timestamp
  */
-__rte_experimental
 void
 rte_frag_table_del_expired_entries(struct rte_ip_frag_tbl *tbl,
 	struct rte_ip_frag_death_row *dr, uint64_t tms);
diff --git a/lib/ip_frag/version.map b/lib/ip_frag/version.map
index 33f231fb31..2e13bef645 100644
--- a/lib/ip_frag/version.map
+++ b/lib/ip_frag/version.map
@@ -1,6 +1,7 @@ 
 DPDK_22 {
 	global:
 
+	rte_frag_table_del_expired_entries;
 	rte_ip_frag_free_death_row;
 	rte_ip_frag_table_create;
 	rte_ip_frag_table_destroy;
@@ -12,9 +13,3 @@  DPDK_22 {
 
 	local: *;
 };
-
-EXPERIMENTAL {
-	global:
-
-	rte_frag_table_del_expired_entries;
-};