diff mbox series

[v2] app/testpmd: fix gtp psc extension header length

Message ID 20211104094027.9329-1-rasland@nvidia.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers
Series [v2] app/testpmd: fix gtp psc extension header length |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/github-robot: build success github build: passed
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS

Commit Message

Raslan Darawsheh Nov. 4, 2021, 9:40 a.m. UTC 
  Current implementation for raw encap sets the length to be in bytes,
but, GTP 'extension' header length is an 8-bit field in 4-octet units.

This fixes the length calculation of the header length.

Fixes: 9213c50e36fa ("app/testpmd: support GTP PSC option in raw sets")
Cc: viacheslavo@nvidia.com
Cc: stable@dpdk.org

Signed-off-by: Raslan Darawsheh <rasland@nvidia.com>
---
v2: fix spelling issues
---
 app/test-pmd/cmdline_flow.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ferruh Yigit Nov. 15, 2021, 7:02 p.m. UTC | #1 
On 11/4/2021 9:40 AM, Raslan Darawsheh wrote:
> Current implementation for raw encap sets the length to be in bytes,
> but, GTP 'extension' header length is an 8-bit field in 4-octet units.
> 
> This fixes the length calculation of the header length.
> 
> Fixes: 9213c50e36fa ("app/testpmd: support GTP PSC option in raw sets")
> Cc: viacheslavo@nvidia.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Raslan Darawsheh <rasland@nvidia.com>
> ---
> v2: fix spelling issues
> ---
>   app/test-pmd/cmdline_flow.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
> index 24b224e632..b4c5aacdbe 100644
> --- a/app/test-pmd/cmdline_flow.c
> +++ b/app/test-pmd/cmdline_flow.c
> @@ -9213,7 +9213,7 @@ cmd_set_raw_parsed(const struct buffer *in)
>   					uint8_t qfi:6;
>   					uint8_t next;
>   				} psc;
> -				psc.len = sizeof(psc);
> +				psc.len = sizeof(psc) / 4;
>   				psc.pdu_type = opt->hdr.type;
>   				psc.qfi = opt->hdr.qfi;
>   				psc.next = 0;
> 

Hi Ori, Slava,

Can you please review this patch?
Slava Ovsiienko Nov. 16, 2021, 1:42 p.m. UTC | #2 
> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Sent: Monday, November 15, 2021 21:02
> To: Raslan Darawsheh <rasland@nvidia.com>; Ori Kam <orika@nvidia.com>;
> Slava Ovsiienko <viacheslavo@nvidia.com>
> Cc: stable@dpdk.org; Xiaoyun Li <xiaoyun.li@intel.com>; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: fix gtp psc extension header
> length
> 
> On 11/4/2021 9:40 AM, Raslan Darawsheh wrote:
> > Current implementation for raw encap sets the length to be in bytes,
> > but, GTP 'extension' header length is an 8-bit field in 4-octet units.
> >
> > This fixes the length calculation of the header length.
> >
> > Fixes: 9213c50e36fa ("app/testpmd: support GTP PSC option in raw
> > sets")
> > Cc: viacheslavo@nvidia.com
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Raslan Darawsheh <rasland@nvidia.com>
> > ---
> > v2: fix spelling issues
> > ---
> >   app/test-pmd/cmdline_flow.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
> > index 24b224e632..b4c5aacdbe 100644
> > --- a/app/test-pmd/cmdline_flow.c
> > +++ b/app/test-pmd/cmdline_flow.c
> > @@ -9213,7 +9213,7 @@ cmd_set_raw_parsed(const struct buffer *in)
> >   					uint8_t qfi:6;
> >   					uint8_t next;
> >   				} psc;
> > -				psc.len = sizeof(psc);
> > +				psc.len = sizeof(psc) / 4;
> >   				psc.pdu_type = opt->hdr.type;
> >   				psc.qfi = opt->hdr.qfi;
> >   				psc.next = 0;
> >
> 
> Hi Ori, Slava,
> 
> Can you please review this patch?
Looks good to me.

Reviewed-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Ferruh Yigit Nov. 16, 2021, 2:27 p.m. UTC | #3 
On 11/16/2021 1:42 PM, Slava Ovsiienko wrote:
>> -----Original Message-----
>> From: Ferruh Yigit <ferruh.yigit@intel.com>
>> Sent: Monday, November 15, 2021 21:02
>> To: Raslan Darawsheh <rasland@nvidia.com>; Ori Kam <orika@nvidia.com>;
>> Slava Ovsiienko <viacheslavo@nvidia.com>
>> Cc: stable@dpdk.org; Xiaoyun Li <xiaoyun.li@intel.com>; dev@dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: fix gtp psc extension header
>> length
>>
>> On 11/4/2021 9:40 AM, Raslan Darawsheh wrote:
>>> Current implementation for raw encap sets the length to be in bytes,
>>> but, GTP 'extension' header length is an 8-bit field in 4-octet units.
>>>
>>> This fixes the length calculation of the header length.
>>>
>>> Fixes: 9213c50e36fa ("app/testpmd: support GTP PSC option in raw
>>> sets")
>>> Cc: viacheslavo@nvidia.com
>>> Cc: stable@dpdk.org
>>>
>>> Signed-off-by: Raslan Darawsheh <rasland@nvidia.com>
> 
> 
> Reviewed-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> 

Applied to dpdk-next-net/main, thanks.
diff mbox series

Patch

diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index 24b224e632..b4c5aacdbe 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c
@@ -9213,7 +9213,7 @@  cmd_set_raw_parsed(const struct buffer *in)
 					uint8_t qfi:6;
 					uint8_t next;
 				} psc;
-				psc.len = sizeof(psc);
+				psc.len = sizeof(psc) / 4;
 				psc.pdu_type = opt->hdr.type;
 				psc.qfi = opt->hdr.qfi;
 				psc.next = 0;