[v1] config/arm: add armv7 native config
Checks
Commit Message
Arvm7 native build fails with this error:
../config/meson.build:364:1: ERROR: Problem encountered:
Number of CPU cores not specified.
This is because RTE_MAX_LCORE is not set. We also need to set
RTE_MAX_NUMA_NODES in armv7 native builds.
Fixes: 8ef09fdc506b ("build: add optional NUMA and CPU counts detection")
Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
---
config/arm/meson.build | 2 ++
1 file changed, 2 insertions(+)
Comments
> -----Original Message-----
> From: Juraj Linkeš <juraj.linkes@pantheon.tech>
> Sent: Thursday, November 18, 2021 6:46 PM
> To: thomas@monjalon.net; david.marchand@redhat.com;
> bruce.richardson@intel.com; Honnappa Nagarahalli
> <Honnappa.Nagarahalli@arm.com>; Ruifeng Wang
> <Ruifeng.Wang@arm.com>; ferruh.yigit@intel.com;
> christian.ehrhardt@canonical.com
> Cc: dev@dpdk.org; Juraj Linkeš <juraj.linkes@pantheon.tech>
> Subject: [PATCH v1] config/arm: add armv7 native config
>
> Arvm7 native build fails with this error:
Typo, 'Armv7'
> ../config/meson.build:364:1: ERROR: Problem encountered:
> Number of CPU cores not specified.
>
> This is because RTE_MAX_LCORE is not set. We also need to set
> RTE_MAX_NUMA_NODES in armv7 native builds.
>
> Fixes: 8ef09fdc506b ("build: add optional NUMA and CPU counts detection")
>
> Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
> ---
> config/arm/meson.build | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/config/arm/meson.build b/config/arm/meson.build index
> 213324d262..57980661b2 100644
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -432,6 +432,8 @@ if dpdk_conf.get('RTE_ARCH_32')
> else
> # armv7 build
> dpdk_conf.set('RTE_ARCH_ARMv7', true)
> + dpdk_conf.set('RTE_MAX_LCORE', 128)
> + dpdk_conf.set('RTE_MAX_NUMA_NODES', 8)
> # the minimum architecture supported, armv7-a, needs the following,
> machine_args += '-mfpu=neon'
> endif
> --
> 2.20.1
Acked-by: Ruifeng Wang <ruifeng.wang@arm.com>
On Thu, 18 Nov 2021 11:45:51 +0100
Juraj Linkeš <juraj.linkes@pantheon.tech> wrote:
> Arvm7 native build fails with this error:
> ../config/meson.build:364:1: ERROR: Problem encountered:
> Number of CPU cores not specified.
>
> This is because RTE_MAX_LCORE is not set. We also need to set
> RTE_MAX_NUMA_NODES in armv7 native builds.
>
> Fixes: 8ef09fdc506b ("build: add optional NUMA and CPU counts detection")
>
> Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
> ---
> config/arm/meson.build | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/config/arm/meson.build b/config/arm/meson.build
> index 213324d262..57980661b2 100644
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -432,6 +432,8 @@ if dpdk_conf.get('RTE_ARCH_32')
> else
> # armv7 build
> dpdk_conf.set('RTE_ARCH_ARMv7', true)
> + dpdk_conf.set('RTE_MAX_LCORE', 128)
> + dpdk_conf.set('RTE_MAX_NUMA_NODES', 8)
In DPDK 19.11 the ARMv7 config says armv7 does not support NUMA.
Pleas set NUMA_NODES to 1
@@ -432,6 +432,8 @@ if dpdk_conf.get('RTE_ARCH_32')
else
# armv7 build
dpdk_conf.set('RTE_ARCH_ARMv7', true)
+ dpdk_conf.set('RTE_MAX_LCORE', 128)
+ dpdk_conf.set('RTE_MAX_NUMA_NODES', 8)
# the minimum architecture supported, armv7-a, needs the following,
machine_args += '-mfpu=neon'
endif