Message ID | cover.1648549553.git.sthotton@marvell.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0DA17A0508; Tue, 29 Mar 2022 15:11:49 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ED35340691; Tue, 29 Mar 2022 15:11:48 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id D1EB940141 for <dev@dpdk.org>; Tue, 29 Mar 2022 15:11:46 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 22T9PUrM009654 for <dev@dpdk.org>; Tue, 29 Mar 2022 06:11:46 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding : content-type; s=pfpt0220; bh=vZdUajwkbib8eDlh5vFEqHolF/U6V+EmDEuFbHE9nHk=; b=EkPMEh8TU02e9pZUZtOk9TWwW5Z01GgEKDfLmZoA4dQFZRqT0lbc3yNmnXUlKu4bceck xsRX6z3ip9Xt+m/gWciAimERKs0rcMUplGzXsfHTtycR3OoqX7INOYvJlNlsdOR7YlZx KDWPqEouGCA8Ib/mtqBEfxyGfgH9SSYzoklLt8uF9ArDUTau34b01TCyS8lG8M0V2u0E teRsk4w5CD1yZunIUWpvahZs+QbeoDEhO2ZINZ9vBaEcjtrHZQWzDKotT0AimEkAgKhc JLGUnlEzzf7cyt9+MoLPG0buWKlH6kVZUpPKtty7HD51/P1110SXstJWmEH62l7tD8Dp 2Q== Received: from dc5-exch01.marvell.com ([199.233.59.181]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3f3yf3rwjf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for <dev@dpdk.org>; Tue, 29 Mar 2022 06:11:45 -0700 Received: from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 29 Mar 2022 06:11:44 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 29 Mar 2022 06:11:44 -0700 Received: from localhost.localdomain (unknown [10.28.34.29]) by maili.marvell.com (Postfix) with ESMTP id 116823F7062; Tue, 29 Mar 2022 06:11:42 -0700 (PDT) From: Shijith Thotton <sthotton@marvell.com> To: <dev@dpdk.org>, <jerinj@marvell.com> CC: Shijith Thotton <sthotton@marvell.com>, <pbhagavatula@marvell.com> Subject: [PATCH 0/6] Extend and set event queue attributes at runtime Date: Tue, 29 Mar 2022 18:40:59 +0530 Message-ID: <cover.1648549553.git.sthotton@marvell.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Proofpoint-ORIG-GUID: AkptrmpCyWga8nrlbHNLO3_CZq5bv6Ji X-Proofpoint-GUID: AkptrmpCyWga8nrlbHNLO3_CZq5bv6Ji X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.850,Hydra:6.0.425,FMLib:17.11.64.514 definitions=2022-03-29_04,2022-03-29_01,2022-02-23_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org |
Series |
Extend and set event queue attributes at runtime
|
|
Message
Shijith Thotton
March 29, 2022, 1:10 p.m. UTC
This series adds support for setting event queue attributes at runtime and adds two new event queue attributes weight and affinity. Eventdev capability RTE_EVENT_DEV_CAP_RUNTIME_QUEUE_ATTR is added to expose the capability to set attributes at runtime and rte_event_queue_attr_set() API is used to set the attributes. Attributes weight and affinity are not yet added to rte_event_queue_conf structure to avoid ABI break and will be added in 22.11. Till then, PMDs using the new attributes are expected to manage them. Test application changes and example implementation are added as last three patches. Pavan Nikhilesh (1): common/cnxk: use lock when accessing mbox of SSO Shijith Thotton (5): eventdev: support to set queue attributes at runtime eventdev: add weight and affinity to queue attributes doc: announce change in event queue conf structure test/event: test cases to test runtime queue attribute event/cnxk: support to set runtime queue attributes app/test/test_eventdev.c | 146 ++++++++++++++++++ doc/guides/eventdevs/features/cnxk.ini | 1 + doc/guides/eventdevs/features/default.ini | 1 + doc/guides/rel_notes/deprecation.rst | 3 + drivers/common/cnxk/roc_sso.c | 174 ++++++++++++++++------ drivers/common/cnxk/roc_sso_priv.h | 1 + drivers/common/cnxk/roc_tim.c | 134 +++++++++++------ drivers/event/cnxk/cn10k_eventdev.c | 4 + drivers/event/cnxk/cn9k_eventdev.c | 4 + drivers/event/cnxk/cnxk_eventdev.c | 81 +++++++++- drivers/event/cnxk/cnxk_eventdev.h | 16 ++ lib/eventdev/eventdev_pmd.h | 44 ++++++ lib/eventdev/rte_eventdev.c | 43 ++++++ lib/eventdev/rte_eventdev.h | 75 +++++++++- lib/eventdev/version.map | 3 + 15 files changed, 627 insertions(+), 103 deletions(-)
Comments
On Tue, Mar 29, 2022 at 6:42 PM Shijith Thotton <sthotton@marvell.com> wrote: > > This series adds support for setting event queue attributes at runtime > and adds two new event queue attributes weight and affinity. Eventdev > capability RTE_EVENT_DEV_CAP_RUNTIME_QUEUE_ATTR is added to expose the > capability to set attributes at runtime and rte_event_queue_attr_set() > API is used to set the attributes. > > Attributes weight and affinity are not yet added to rte_event_queue_conf > structure to avoid ABI break and will be added in 22.11. Till then, PMDs > using the new attributes are expected to manage them. > > Test application changes and example implementation are added as last > three patches. + @Van Haaren, Harry @Jayatheerthan, Jay @Erik Gabriel Carrillo @Gujjar, Abhinandan S @McDaniel, Timothy @Hemant Agrawal @Nipun Gupta @Mattias Rönnblom @lingma @Ray Kinsella > Pavan Nikhilesh (1): > common/cnxk: use lock when accessing mbox of SSO > > Shijith Thotton (5): > eventdev: support to set queue attributes at runtime > eventdev: add weight and affinity to queue attributes > doc: announce change in event queue conf structure > test/event: test cases to test runtime queue attribute > event/cnxk: support to set runtime queue attributes > > app/test/test_eventdev.c | 146 ++++++++++++++++++ > doc/guides/eventdevs/features/cnxk.ini | 1 + > doc/guides/eventdevs/features/default.ini | 1 + > doc/guides/rel_notes/deprecation.rst | 3 + > drivers/common/cnxk/roc_sso.c | 174 ++++++++++++++++------ > drivers/common/cnxk/roc_sso_priv.h | 1 + > drivers/common/cnxk/roc_tim.c | 134 +++++++++++------ > drivers/event/cnxk/cn10k_eventdev.c | 4 + > drivers/event/cnxk/cn9k_eventdev.c | 4 + > drivers/event/cnxk/cnxk_eventdev.c | 81 +++++++++- > drivers/event/cnxk/cnxk_eventdev.h | 16 ++ > lib/eventdev/eventdev_pmd.h | 44 ++++++ > lib/eventdev/rte_eventdev.c | 43 ++++++ > lib/eventdev/rte_eventdev.h | 75 +++++++++- > lib/eventdev/version.map | 3 + > 15 files changed, 627 insertions(+), 103 deletions(-) > > -- > 2.25.1 >
> -----Original Message----- > From: Jerin Jacob <jerinjacobk@gmail.com> > Sent: Tuesday, March 29, 2022 7:50 PM > To: Shijith Thotton <sthotton@marvell.com>; Van Haaren, Harry > <harry.van.haaren@intel.com>; Jayatheerthan, Jay > <jay.jayatheerthan@intel.com>; Carrillo, Erik G <erik.g.carrillo@intel.com>; > Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>; McDaniel, Timothy > <timothy.mcdaniel@intel.com>; Hemant Agrawal <hemant.agrawal@nxp.com>; > Nipun Gupta <nipun.gupta@nxp.com>; mattias.ronnblom > <mattias.ronnblom@ericsson.com>; Ray Kinsella <mdr@ashroe.eu> > Cc: dpdk-dev <dev@dpdk.org>; Jerin Jacob <jerinj@marvell.com>; Pavan > Nikhilesh <pbhagavatula@marvell.com>; Liang Ma <liangma@liangbit.com> > Subject: Re: [PATCH 0/6] Extend and set event queue attributes at runtime > > On Tue, Mar 29, 2022 at 6:42 PM Shijith Thotton <sthotton@marvell.com> wrote: > > > > This series adds support for setting event queue attributes at runtime > > and adds two new event queue attributes weight and affinity. Eventdev > > capability RTE_EVENT_DEV_CAP_RUNTIME_QUEUE_ATTR is added to expose > the > > capability to set attributes at runtime and rte_event_queue_attr_set() > > API is used to set the attributes. > > > > Attributes weight and affinity are not yet added to rte_event_queue_conf > > structure to avoid ABI break and will be added in 22.11. Till then, PMDs > > using the new attributes are expected to manage them. When the new attributes are added to queue_conf structure in 22.11, will the attr_get() function have any real use? If the attr_get() function is not useful post 22.11 (aka, returns const-integers?), we should consider if waiting for ABI-break in 22.11 is a better solution as it doesn't add public API/ABI functions that only have limited time value..? <snip> > + @Van Haaren, Harry @Jayatheerthan, Jay @Erik Gabriel Carrillo > @Gujjar, Abhinandan S @McDaniel, Timothy @Hemant Agrawal @Nipun > Gupta @Mattias Rönnblom @lingma @Ray Kinsella Thanks for flagging Jerin, indeed I hadn't looked at this patchset yet. From event/sw point of view, the new runtime queue attribute capability is not available, so the feature flag will not be set. <snip> Some code comments inline on the impl patches comping up. Regards, -Harry
>> > >> > This series adds support for setting event queue attributes at runtime >> > and adds two new event queue attributes weight and affinity. Eventdev >> > capability RTE_EVENT_DEV_CAP_RUNTIME_QUEUE_ATTR is added to expose >> the >> > capability to set attributes at runtime and rte_event_queue_attr_set() >> > API is used to set the attributes. >> > >> > Attributes weight and affinity are not yet added to rte_event_queue_conf >> > structure to avoid ABI break and will be added in 22.11. Till then, PMDs >> > using the new attributes are expected to manage them. > >When the new attributes are added to queue_conf structure in 22.11, will the >attr_get() function have any real use? > >If the attr_get() function is not useful post 22.11 (aka, returns const-integers?), we >should consider if waiting >for ABI-break in 22.11 is a better solution as it doesn't add public API/ABI functions >that only have limited time value..? > queue_attr_get is an internal op and is not called if the op is not set by the PMD. So no changes are needed from other PMDs to incorporate this. It is useful to the PMDs needing the new attributes before they are added to rte_event_queue_conf struct in 22.11. ><snip> > >> + @Van Haaren, Harry @Jayatheerthan, Jay @Erik Gabriel Carrillo >> @Gujjar, Abhinandan S @McDaniel, Timothy @Hemant Agrawal @Nipun >> Gupta @Mattias Rönnblom @lingma @Ray Kinsella > >Thanks for flagging Jerin, indeed I hadn't looked at this patchset yet. > >From event/sw point of view, the new runtime queue attribute capability is not >available, so the feature flag will not be set. > ><snip> > >Some code comments inline on the impl patches comping up. Regards, -Harry