[v1,5/5] baseband/fpga_5gnr_fec: remove filler from HARQ
Checks
Commit Message
Removed dec->n_filler from harq_out_length calculation.
Signed-off-by: Hernan <hernan.vargas@intel.com>
---
drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
> Removed dec->n_filler from harq_out_length calculation.
>
Please provide a better description describing the reason to remove it.
Hernan,
Please be more explicit on the commit description in the next patch version, suggesting below:
The computation of the HARQ output length should not include the filler bits on the N3000 HW implementation as these are already taken out by the deratematching step.
The change is only an optimization (no functional impact), no change required on stable branches.
Thanks
Nic
> -----Original Message-----
> From: Akhil Goyal <gakhil@marvell.com>
> Sent: Monday, May 16, 2022 11:07 AM
> To: Vargas, Hernan <hernan.vargas@intel.com>; dev@dpdk.org;
> trix@redhat.com
> Cc: Chautru, Nicolas <nicolas.chautru@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>
> Subject: RE: [EXT] [PATCH v1 5/5] baseband/fpga_5gnr_fec: remove filler
> from HARQ
>
> > Removed dec->n_filler from harq_out_length calculation.
> >
> Please provide a better description describing the reason to remove it.
@@ -1844,7 +1844,7 @@ enqueue_ldpc_dec_one_op_cb(struct fpga_queue *q, struct rte_bbdev_dec_op *op,
else
l = k0 + e + dec->n_filler;
harq_out_length = RTE_MIN(RTE_MAX(harq_in_length, l),
- dec->n_cb - dec->n_filler);
+ dec->n_cb);
dec->harq_combined_output.length = harq_out_length;
}