[v2,21/70] net/ice/base: add E822 generic PCI device ID

Message ID 20220815073206.2917968-22-qi.z.zhang@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Qi Zhang
Headers
Series ice base code update |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Qi Zhang Aug. 15, 2022, 7:31 a.m. UTC
  The E822 has a generic PCI device ID that can be used in the PLDM
header when updating the device so add it.

Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
 drivers/net/ice/base/ice_devids.h | 3 ++-
 drivers/net/ice/ice_ethdev.c      | 1 +
 2 files changed, 3 insertions(+), 1 deletion(-)
  

Comments

Qiming Yang Aug. 15, 2022, 6:45 a.m. UTC | #1
> -----Original Message-----
> From: Zhang, Qi Z <qi.z.zhang@intel.com>
> Sent: Monday, August 15, 2022 3:31 PM
> To: Yang, Qiming <qiming.yang@intel.com>
> Cc: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>
> Subject: [PATCH v2 21/70] net/ice/base: add E822 generic PCI device ID
> 
> The E822 has a generic PCI device ID that can be used in the PLDM header
> when updating the device so add it.
> 
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> ---
>  drivers/net/ice/base/ice_devids.h | 3 ++-
>  drivers/net/ice/ice_ethdev.c      | 1 +
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ice/base/ice_devids.h
> b/drivers/net/ice/base/ice_devids.h
> index 96f2528c5e..96dbb92e0a 100644
> --- a/drivers/net/ice/base/ice_devids.h
> +++ b/drivers/net/ice/base/ice_devids.h
> @@ -6,7 +6,6 @@
>  #define _ICE_DEVIDS_H_
> 
>  /* Device IDs */
> -/* Intel(R) Ethernet Connection E823-L for backplane */
>  #define ICE_DEV_ID_E823L_BACKPLANE	0x124C
>  /* Intel(R) Ethernet Connection E823-L for SFP */
>  #define ICE_DEV_ID_E823L_SFP		0x124D
> @@ -31,6 +30,8 @@
>  /* Intel(R) Ethernet Controller E810-XXV for SFP */
>  #define ICE_DEV_ID_E810_XXV_SFP		0x159B
>  /* Intel(R) Ethernet Connection E823-C for backplane */
> +#define ICE_DEV_ID_E822_SI_DFLT		0x1888
> +/* Intel(R) Ethernet Connection E823-L for backplane */
>  #define ICE_DEV_ID_E823C_BACKPLANE	0x188A
>  /* Intel(R) Ethernet Connection E823-C for QSFP */
>  #define ICE_DEV_ID_E823C_QSFP		0x188B
> diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index
> 2e522376e3..551be3566f 100644
> --- a/drivers/net/ice/ice_ethdev.c
> +++ b/drivers/net/ice/ice_ethdev.c
> @@ -187,6 +187,7 @@ static const struct rte_pci_id pci_id_ice_map[] = {
>  	{ RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_E823C_SFP) },
>  	{ RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID,
> ICE_DEV_ID_E823C_10G_BASE_T) },
>  	{ RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID,
> ICE_DEV_ID_E823C_SGMII) },
> +	{ RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID,
> ICE_DEV_ID_E822_SI_DFLT) },
>  	{ RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID,
> ICE_DEV_ID_E822C_BACKPLANE) },
>  	{ RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID,
> ICE_DEV_ID_E822C_QSFP) },
>  	{ RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_E822C_SFP) },
> --
> 2.31.1

21/70-32/70
Acked-by: Qiming Yang <qiming.yang@intel.com>
  

Patch

diff --git a/drivers/net/ice/base/ice_devids.h b/drivers/net/ice/base/ice_devids.h
index 96f2528c5e..96dbb92e0a 100644
--- a/drivers/net/ice/base/ice_devids.h
+++ b/drivers/net/ice/base/ice_devids.h
@@ -6,7 +6,6 @@ 
 #define _ICE_DEVIDS_H_
 
 /* Device IDs */
-/* Intel(R) Ethernet Connection E823-L for backplane */
 #define ICE_DEV_ID_E823L_BACKPLANE	0x124C
 /* Intel(R) Ethernet Connection E823-L for SFP */
 #define ICE_DEV_ID_E823L_SFP		0x124D
@@ -31,6 +30,8 @@ 
 /* Intel(R) Ethernet Controller E810-XXV for SFP */
 #define ICE_DEV_ID_E810_XXV_SFP		0x159B
 /* Intel(R) Ethernet Connection E823-C for backplane */
+#define ICE_DEV_ID_E822_SI_DFLT		0x1888
+/* Intel(R) Ethernet Connection E823-L for backplane */
 #define ICE_DEV_ID_E823C_BACKPLANE	0x188A
 /* Intel(R) Ethernet Connection E823-C for QSFP */
 #define ICE_DEV_ID_E823C_QSFP		0x188B
diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
index 2e522376e3..551be3566f 100644
--- a/drivers/net/ice/ice_ethdev.c
+++ b/drivers/net/ice/ice_ethdev.c
@@ -187,6 +187,7 @@  static const struct rte_pci_id pci_id_ice_map[] = {
 	{ RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_E823C_SFP) },
 	{ RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_E823C_10G_BASE_T) },
 	{ RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_E823C_SGMII) },
+	{ RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_E822_SI_DFLT) },
 	{ RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_E822C_BACKPLANE) },
 	{ RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_E822C_QSFP) },
 	{ RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_E822C_SFP) },