mbox series

[0/2] IPsec on Arm

Message ID 20220727081352.1333695-1-ruifeng.wang@arm.com (mailing list archive)
Headers
Series IPsec on Arm |

Message

Ruifeng Wang July 27, 2022, 8:13 a.m. UTC 
  This patch set integrates Arm port of ipsec_mb library.
ZUC and SNOW3g PMDs are available on Arm platform with this integration.

This series depends on:
http://patches.dpdk.org/project/dpdk/patch/20220630154123.2565439-1-asekhar@marvell.com/

Depends-on: patch-113578 ("crypto/ipsec_mb: enable support for arm64")

Ruifeng Wang (2):
  crypto/ipsec_mb: remove redundant includes
  crypto/ipsec_mb: enable IPsec on Arm platform

 app/test/test_cryptodev_hash_test_vectors.h  |  4 ++++
 doc/guides/cryptodevs/snow3g.rst             | 14 ++++++++++----
 doc/guides/cryptodevs/zuc.rst                | 14 ++++++++++----
 drivers/common/qat/meson.build               |  6 +++++-
 drivers/crypto/ipsec_mb/ipsec_mb_private.c   |  6 ++++++
 drivers/crypto/ipsec_mb/ipsec_mb_private.h   |  4 ++++
 drivers/crypto/ipsec_mb/meson.build          |  6 +++++-
 drivers/crypto/ipsec_mb/pmd_aesni_gcm_priv.h |  2 --
 drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h  |  2 --
 drivers/crypto/qat/qat_sym_session.c         |  4 ++++
 10 files changed, 48 insertions(+), 14 deletions(-)

Comments

Akhil Goyal Aug. 16, 2022, 3:57 p.m. UTC | #1 
Hi Fan/Pablo,

Do you have comments on this patchset?

> This patch set integrates Arm port of ipsec_mb library.
> ZUC and SNOW3g PMDs are available on Arm platform with this integration.
> 
> This series depends on:
> http://patches.dpdk.org/project/dpdk/patch/20220630154123.2565439-1-asekhar@marvell.com/
> 
> Depends-on: patch-113578 ("crypto/ipsec_mb: enable support for arm64")
> 
> Ruifeng Wang (2):
>   crypto/ipsec_mb: remove redundant includes
>   crypto/ipsec_mb: enable IPsec on Arm platform
> 
>  app/test/test_cryptodev_hash_test_vectors.h  |  4 ++++
>  doc/guides/cryptodevs/snow3g.rst             | 14 ++++++++++----
>  doc/guides/cryptodevs/zuc.rst                | 14 ++++++++++----
>  drivers/common/qat/meson.build               |  6 +++++-
>  drivers/crypto/ipsec_mb/ipsec_mb_private.c   |  6 ++++++
>  drivers/crypto/ipsec_mb/ipsec_mb_private.h   |  4 ++++
>  drivers/crypto/ipsec_mb/meson.build          |  6 +++++-
>  drivers/crypto/ipsec_mb/pmd_aesni_gcm_priv.h |  2 --
>  drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h  |  2 --
>  drivers/crypto/qat/qat_sym_session.c         |  4 ++++
>  10 files changed, 48 insertions(+), 14 deletions(-)
> 
> --
> 2.25.1
Fan Zhang Aug. 22, 2022, 7:54 a.m. UTC | #2 
Hi Ruifeng,

We have no technical issues with these patches based on their current functionality. However, it is worth pointing out that we are planning some changes to the Intel® Multi-Buffer Crypto for IPSec library which will require API changes in the future. These changes are, but not limited to, to consolidate some of the crypto PMDs into a single PMD, which will simplify the code and reduce future maintenance effort. When these changes are made, your library will need to be updated too in order to take advantage of the consolidation. We can provide further details of the changes that we’re considering separately, so that you’re not taken by surprise when these change occurs.

We also want you to know, for any change we will make to these PMDs, we do not guarantee it works on ARM platform. We advise you to do necessary testing/verification in necessary testing/verification to the future patches for the PMDs based on ipsec-mb on your platform.

Regards,
Fan

> -----Original Message-----
> From: Ruifeng Wang <ruifeng.wang@arm.com>
> Sent: Wednesday, July 27, 2022 9:14 AM
> To: Zhang, Roy Fan <roy.fan.zhang@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>; Wang, Yipeng1
> <yipeng1.wang@intel.com>; Gobriel, Sameh <sameh.gobriel@intel.com>;
> Richardson, Bruce <bruce.richardson@intel.com>; Medvedkin, Vladimir
> <vladimir.medvedkin@intel.com>; gakhil@marvell.com
> Cc: dev@dpdk.org; honnappa.nagarahalli@arm.com; nd@arm.com; Ruifeng
> Wang <ruifeng.wang@arm.com>
> Subject: [PATCH 0/2] IPsec on Arm
> 
> This patch set integrates Arm port of ipsec_mb library.
> ZUC and SNOW3g PMDs are available on Arm platform with this integration.
> 
> This series depends on:
> http://patches.dpdk.org/project/dpdk/patch/20220630154123.2565439-1-
> asekhar@marvell.com/
> 
> Depends-on: patch-113578 ("crypto/ipsec_mb: enable support for arm64")
> 
> Ruifeng Wang (2):
>   crypto/ipsec_mb: remove redundant includes
>   crypto/ipsec_mb: enable IPsec on Arm platform
> 
>  app/test/test_cryptodev_hash_test_vectors.h  |  4 ++++
>  doc/guides/cryptodevs/snow3g.rst             | 14 ++++++++++----
>  doc/guides/cryptodevs/zuc.rst                | 14 ++++++++++----
>  drivers/common/qat/meson.build               |  6 +++++-
>  drivers/crypto/ipsec_mb/ipsec_mb_private.c   |  6 ++++++
>  drivers/crypto/ipsec_mb/ipsec_mb_private.h   |  4 ++++
>  drivers/crypto/ipsec_mb/meson.build          |  6 +++++-
>  drivers/crypto/ipsec_mb/pmd_aesni_gcm_priv.h |  2 --
>  drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h  |  2 --
>  drivers/crypto/qat/qat_sym_session.c         |  4 ++++
>  10 files changed, 48 insertions(+), 14 deletions(-)
> 
> --
> 2.25.1
Ruifeng Wang Aug. 22, 2022, 8:38 a.m. UTC | #3 
> -----Original Message-----
> From: Zhang, Roy Fan <roy.fan.zhang@intel.com>
> Sent: Monday, August 22, 2022 3:54 PM
> To: Ruifeng Wang <Ruifeng.Wang@arm.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>; Wang, Yipeng1 <yipeng1.wang@intel.com>; Gobriel, Sameh
> <sameh.gobriel@intel.com>; Richardson, Bruce <bruce.richardson@intel.com>; Medvedkin,
> Vladimir <vladimir.medvedkin@intel.com>; gakhil@marvell.com
> Cc: dev@dpdk.org; Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>; nd <nd@arm.com>
> Subject: RE: [PATCH 0/2] IPsec on Arm
> 
> Hi Ruifeng,
Hi Fan,

> 
> We have no technical issues with these patches based on their current functionality.
> However, it is worth pointing out that we are planning some changes to the Intel(r) Multi-
> Buffer Crypto for IPSec library which will require API changes in the future. These
> changes are, but not limited to, to consolidate some of the crypto PMDs into a single PMD,
> which will simplify the code and reduce future maintenance effort. When these changes are
> made, your library will need to be updated too in order to take advantage of the
Thanks for the heads-up. Really appreciate it.

> consolidation. We can provide further details of the changes that we're considering
> separately, so that you're not taken by surprise when these change occurs.
Yep, let's communicate this in a separate thread.

> 
> We also want you to know, for any change we will make to these PMDs, we do not guarantee
> it works on ARM platform. We advise you to do necessary testing/verification in necessary
> testing/verification to the future patches for the PMDs based on ipsec-mb on your platform.
Yes, I will verify ZUC/SNOW3g PMD patches on Arm platform.

> 
> Regards,
> Fan
> 
> > -----Original Message-----
> > From: Ruifeng Wang <ruifeng.wang@arm.com>
> > Sent: Wednesday, July 27, 2022 9:14 AM
> > To: Zhang, Roy Fan <roy.fan.zhang@intel.com>; De Lara Guarch, Pablo
> > <pablo.de.lara.guarch@intel.com>; Wang, Yipeng1
> > <yipeng1.wang@intel.com>; Gobriel, Sameh <sameh.gobriel@intel.com>;
> > Richardson, Bruce <bruce.richardson@intel.com>; Medvedkin, Vladimir
> > <vladimir.medvedkin@intel.com>; gakhil@marvell.com
> > Cc: dev@dpdk.org; honnappa.nagarahalli@arm.com; nd@arm.com; Ruifeng
> > Wang <ruifeng.wang@arm.com>
> > Subject: [PATCH 0/2] IPsec on Arm
> >
> > This patch set integrates Arm port of ipsec_mb library.
> > ZUC and SNOW3g PMDs are available on Arm platform with this integration.
> >
> > This series depends on:
> > http://patches.dpdk.org/project/dpdk/patch/20220630154123.2565439-1-
> > asekhar@marvell.com/
> >
> > Depends-on: patch-113578 ("crypto/ipsec_mb: enable support for arm64")
> >
> > Ruifeng Wang (2):
> >   crypto/ipsec_mb: remove redundant includes
> >   crypto/ipsec_mb: enable IPsec on Arm platform
> >
> >  app/test/test_cryptodev_hash_test_vectors.h  |  4 ++++
> >  doc/guides/cryptodevs/snow3g.rst             | 14 ++++++++++----
> >  doc/guides/cryptodevs/zuc.rst                | 14 ++++++++++----
> >  drivers/common/qat/meson.build               |  6 +++++-
> >  drivers/crypto/ipsec_mb/ipsec_mb_private.c   |  6 ++++++
> >  drivers/crypto/ipsec_mb/ipsec_mb_private.h   |  4 ++++
> >  drivers/crypto/ipsec_mb/meson.build          |  6 +++++-
> >  drivers/crypto/ipsec_mb/pmd_aesni_gcm_priv.h |  2 --
> > drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h  |  2 --
> >  drivers/crypto/qat/qat_sym_session.c         |  4 ++++
> >  10 files changed, 48 insertions(+), 14 deletions(-)
> >
> > --
> > 2.25.1
Akhil Goyal Aug. 26, 2022, 8:47 a.m. UTC | #4 
> Hi Ruifeng,
> 
> We have no technical issues with these patches based on their current
> functionality. However, it is worth pointing out that we are planning some
> changes to the Intel(r) Multi-Buffer Crypto for IPSec library which will require API
> changes in the future. These changes are, but not limited to, to consolidate
> some of the crypto PMDs into a single PMD, which will simplify the code and
> reduce future maintenance effort. When these changes are made, your library
> will need to be updated too in order to take advantage of the consolidation. We
> can provide further details of the changes that we're considering separately, so
> that you're not taken by surprise when these change occurs.
> 
> We also want you to know, for any change we will make to these PMDs, we do
> not guarantee it works on ARM platform. We advise you to do necessary
> testing/verification in necessary testing/verification to the future patches for
> the PMDs based on ipsec-mb on your platform.


> > This patch set integrates Arm port of ipsec_mb library.
> > ZUC and SNOW3g PMDs are available on Arm platform with this integration.
> >
> > This series depends on:
> > https://urldefense.proofpoint.com/v2/url?u=http-
> 3A__patches.dpdk.org_project_dpdk_patch_20220630154123.2565439-2D1-
> 2D&d=DwIF-
> g&c=nKjWec2b6R0mOyPaz7xtfQ&r=DnL7Si2wl_PRwpZ9TWey3eu68gBzn7DkPw
> uqhd6WNyo&m=MSflaO84SEZbIx1iRuPLHdFCx1Tt55MDafiMzZITc2CEoY-
> Zid36my-fIfMSmooi&s=rLK324Pjv9lI3_LVXCQaQ6-Yb7fT9y1kE6_S68741Ec&e=
> > asekhar@marvell.com/
> >
> > Depends-on: patch-113578 ("crypto/ipsec_mb: enable support for arm64")
> >
> > Ruifeng Wang (2):
> >   crypto/ipsec_mb: remove redundant includes
> >   crypto/ipsec_mb: enable IPsec on Arm platform
> >
> >  app/test/test_cryptodev_hash_test_vectors.h  |  4 ++++
> >  doc/guides/cryptodevs/snow3g.rst             | 14 ++++++++++----
> >  doc/guides/cryptodevs/zuc.rst                | 14 ++++++++++----
> >  drivers/common/qat/meson.build               |  6 +++++-
> >  drivers/crypto/ipsec_mb/ipsec_mb_private.c   |  6 ++++++
> >  drivers/crypto/ipsec_mb/ipsec_mb_private.h   |  4 ++++
> >  drivers/crypto/ipsec_mb/meson.build          |  6 +++++-
> >  drivers/crypto/ipsec_mb/pmd_aesni_gcm_priv.h |  2 --
> >  drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h  |  2 --
> >  drivers/crypto/qat/qat_sym_session.c         |  4 ++++
> >  10 files changed, 48 insertions(+), 14 deletions(-)
Series applied to dpdk-next-crypto

Thanks