[v2] lib/eal/linux: update lcore-worker name due to high number of cores
Checks
Commit Message
In this patch we suggest a new name for lcore-worker.
In case of more than 99 logical cores, name is truncated
(length is restricted to 16 characters, including the
terminating null byte ('\0')) and it makes hard to follow threads.
Signed-off-by: Abdullah Ömer Yamaç <omer.yamac@ceng.metu.edu.tr>
---
Cc: David Marchand <david.marchand@redhat.com>
---
lib/eal/linux/eal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Thu, 22 Sep 2022 13:30:23 +0300
Abdullah Ömer Yamaç <omer.yamac@ceng.metu.edu.tr> wrote:
> In this patch we suggest a new name for lcore-worker.
> In case of more than 99 logical cores, name is truncated
> (length is restricted to 16 characters, including the
> terminating null byte ('\0')) and it makes hard to follow threads.
>
> Signed-off-by: Abdullah Ömer Yamaç <omer.yamac@ceng.metu.edu.tr>
>
> ---
> Cc: David Marchand <david.marchand@redhat.com>
> ---
> lib/eal/linux/eal.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c
> index 46bf52cef0..9a168b7773 100644
> --- a/lib/eal/linux/eal.c
> +++ b/lib/eal/linux/eal.c
> @@ -1248,7 +1248,7 @@ rte_eal_init(int argc, char **argv)
>
> /* Set thread_name for aid in debugging. */
> snprintf(thread_name, sizeof(thread_name),
> - "lcore-worker-%d", i);
> + "rte-worker-%d", i);
> ret = rte_thread_setname(lcore_config[i].thread_id,
> thread_name);
> if (ret != 0)
BSD should be setting name as well.
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
@@ -1248,7 +1248,7 @@ rte_eal_init(int argc, char **argv)
/* Set thread_name for aid in debugging. */
snprintf(thread_name, sizeof(thread_name),
- "lcore-worker-%d", i);
+ "rte-worker-%d", i);
ret = rte_thread_setname(lcore_config[i].thread_id,
thread_name);
if (ret != 0)