Message ID | 20220929102936.5490-1-adwivedi@marvell.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9C863A00C4; Thu, 29 Sep 2022 12:32:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 80C3C40694; Thu, 29 Sep 2022 12:32:41 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 7A15B40395 for <dev@dpdk.org>; Thu, 29 Sep 2022 12:32:40 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 28T1UlbW022921; Thu, 29 Sep 2022 03:30:16 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=pfpt0220; bh=VaCjT8pOxOmMQWtJZW5g9D3T7M3ZSyt0WLzLAwLhpdc=; b=alvPrOTDS19i+e4oMIKSev30xXhmpc8/rVQPcL7Td/dqnvn7+NGBwZRrK/YOCYb+YDCq UQz4k2M2UugMA2dVwdCPUjPBZuxYx+i8zBLz5MWcgbXyZ5xHLuZDK96dqy8Q1oULR0HJ aK1+VeHik4u7FdGpMOpdVlIdD7jmcTrFxifUZVXK+trLP+B7f3oapufpbAFik6GSRaMf ndhiaCLh44c+5JCGoGlGI30VsmRzvAh/rDZYLJua3oQx8HGs61KmgtaB3Hl4tHLx//n+ PKYKDCmZJihpA1RNLpUXR2CI8xs59S2OOFRRE3ojn0sRalSPHS5OzB/N1ZUAtvi8QFO4 Rw== Received: from dc5-exch02.marvell.com ([199.233.59.182]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3jw1rt1s2w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 29 Sep 2022 03:30:15 -0700 Received: from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Thu, 29 Sep 2022 03:30:04 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 29 Sep 2022 03:30:04 -0700 Received: from hyd1349.t110.caveonetworks.com.com (unknown [10.29.45.13]) by maili.marvell.com (Postfix) with ESMTP id D096A3F705C; Thu, 29 Sep 2022 03:29:42 -0700 (PDT) From: Ankur Dwivedi <adwivedi@marvell.com> To: <dev@dpdk.org> CC: <thomas@monjalon.net>, <mdr@ashroe.eu>, <orika@nvidia.com>, <ferruh.yigit@xilinx.com>, <chas3@att.com>, <humin29@huawei.com>, <linville@tuxdriver.com>, <ciara.loftus@intel.com>, <qi.z.zhang@intel.com>, <mw@semihalf.com>, <mk@semihalf.com>, <shaibran@amazon.com>, <evgenys@amazon.com>, <igorch@amazon.com>, <chandu@amd.com>, <irusskikh@marvell.com>, <shepard.siegel@atomicrules.com>, <ed.czeck@atomicrules.com>, <john.miller@atomicrules.com>, <ajit.khaparde@broadcom.com>, <somnath.kotur@broadcom.com>, <jerinj@marvell.com>, <mczekaj@marvell.com>, <sthotton@marvell.com>, <srinivasan@marvell.com>, <hkalra@marvell.com>, <rahul.lakkireddy@chelsio.com>, <johndale@cisco.com>, <hyonkim@cisco.com>, <liudongdong3@huawei.com>, <yisen.zhuang@huawei.com>, <xuanziyang2@huawei.com>, <cloud.wangxiaoyun@huawei.com>, <zhouguoyang@huawei.com>, <simei.su@intel.com>, <wenjun1.wu@intel.com>, <qiming.yang@intel.com>, <Yuying.Zhang@intel.com>, <beilei.xing@intel.com>, <xiao.w.wang@intel.com>, <jingjing.wu@intel.com>, <junfeng.guo@intel.com>, <rosen.xu@intel.com>, <ndabilpuram@marvell.com>, <kirankumark@marvell.com>, <skori@marvell.com>, <skoteshwar@marvell.com>, <lironh@marvell.com>, <zr@semihalf.com>, <radhac@marvell.com>, <vburru@marvell.com>, <sedara@marvell.com>, <matan@nvidia.com>, <viacheslavo@nvidia.com>, <sthemmin@microsoft.com>, <longli@microsoft.com>, <spinler@cesnet.cz>, <chaoyong.he@corigine.com>, <niklas.soderlund@corigine.com>, <hemant.agrawal@nxp.com>, <sachin.saxena@oss.nxp.com>, <g.singh@nxp.com>, <apeksha.gupta@nxp.com>, <sachin.saxena@nxp.com>, <aboyer@pensando.io>, <rmody@marvell.com>, <shshaikh@marvell.com>, <dsinghrawat@marvell.com>, <andrew.rybchenko@oktetlabs.ru>, <jiawenwu@trustnetic.com>, <jianwang@trustnetic.com>, <jbehrens@vmware.com>, <maxime.coquelin@redhat.com>, <chenbo.xia@intel.com>, <steven.webster@windriver.com>, <matt.peters@windriver.com>, <bruce.richardson@intel.com>, <mtetsuyah@gmail.com>, <grive@u256.net>, <jasvinder.singh@intel.com>, <cristian.dumitrescu@intel.com>, <jgrajcia@cisco.com>, Ankur Dwivedi <adwivedi@marvell.com> Subject: [PATCH v2 0/4] add trace points in ethdev library Date: Thu, 29 Sep 2022 15:59:32 +0530 Message-ID: <20220929102936.5490-1-adwivedi@marvell.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20220804134430.6192-1-adwivedi@marvell.com> References: <20220804134430.6192-1-adwivedi@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Proofpoint-GUID: d1Mi43zxYuVv07YewXUJQkYsJMuWlxfx X-Proofpoint-ORIG-GUID: d1Mi43zxYuVv07YewXUJQkYsJMuWlxfx X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1 definitions=2022-09-29_06,2022-09-29_03,2022-06-22_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org |
Series |
add trace points in ethdev library
|
|
Message
Ankur Dwivedi
Sept. 29, 2022, 10:29 a.m. UTC
This series adds trace points for functions in the ethdev library. The trace points are added in ethdev, flow, mtr and tm files. v2: - Made rte_eth_trace_call_rx_callbacks and rte_eth_trace_call_tx_callbacks as fastpath trace functions. - Moved some trace functions call to the end to capture return value and data. - Removed rte_eth_trace_tx_queue_setup as it is not required. rte_ethdev_trace_txq_setup() is already present in rte_eth_tx_queue_setup(). - Removed trace in ethdev_driver.c - Removed trace function check patch. Ankur Dwivedi (4): ethdev: add trace points ethdev: add trace points for flow ethdev: add trace points for mtr ethdev: add trace points for tm lib/ethdev/ethdev_private.c | 3 + lib/ethdev/ethdev_trace_points.c | 699 ++++++++++ lib/ethdev/rte_ethdev.c | 148 +++ lib/ethdev/rte_ethdev_trace.h | 2062 ++++++++++++++++++++++++++++++ lib/ethdev/rte_ethdev_trace_fp.h | 19 + lib/ethdev/rte_flow.c | 54 + lib/ethdev/rte_mtr.c | 27 + lib/ethdev/rte_tm.c | 40 + lib/ethdev/version.map | 232 ++++ 9 files changed, 3284 insertions(+)
Comments
On 9/29/22 13:29, Ankur Dwivedi wrote: > This series adds trace points for functions in the ethdev library. > The trace points are added in ethdev, flow, mtr and tm files. > > v2: > - Made rte_eth_trace_call_rx_callbacks and rte_eth_trace_call_tx_callbacks > as fastpath trace functions. > - Moved some trace functions call to the end to capture return value and > data. Looking at the patch series I still see many-many places where tracing happens on entry point. Intentional? > - Removed rte_eth_trace_tx_queue_setup as it is not required. > rte_ethdev_trace_txq_setup() is already present in > rte_eth_tx_queue_setup(). > - Removed trace in ethdev_driver.c > - Removed trace function check patch. > > Ankur Dwivedi (4): > ethdev: add trace points > ethdev: add trace points for flow > ethdev: add trace points for mtr > ethdev: add trace points for tm > > lib/ethdev/ethdev_private.c | 3 + > lib/ethdev/ethdev_trace_points.c | 699 ++++++++++ > lib/ethdev/rte_ethdev.c | 148 +++ > lib/ethdev/rte_ethdev_trace.h | 2062 ++++++++++++++++++++++++++++++ > lib/ethdev/rte_ethdev_trace_fp.h | 19 + > lib/ethdev/rte_flow.c | 54 + > lib/ethdev/rte_mtr.c | 27 + > lib/ethdev/rte_tm.c | 40 + > lib/ethdev/version.map | 232 ++++ > 9 files changed, 3284 insertions(+) >
Hi Andrew, >-----Original Message----- >From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru> >Sent: Thursday, October 6, 2022 12:40 PM >To: Ankur Dwivedi <adwivedi@marvell.com>; dev@dpdk.org >Cc: thomas@monjalon.net; mdr@ashroe.eu; orika@nvidia.com; >ferruh.yigit@xilinx.com; chas3@att.com; humin29@huawei.com; >linville@tuxdriver.com; ciara.loftus@intel.com; qi.z.zhang@intel.com; >mw@semihalf.com; mk@semihalf.com; shaibran@amazon.com; >evgenys@amazon.com; igorch@amazon.com; chandu@amd.com; Igor >Russkikh <irusskikh@marvell.com>; shepard.siegel@atomicrules.com; >ed.czeck@atomicrules.com; john.miller@atomicrules.com; >ajit.khaparde@broadcom.com; somnath.kotur@broadcom.com; Jerin Jacob >Kollanukkaran <jerinj@marvell.com>; Maciej Czekaj [C] ><mczekaj@marvell.com>; Shijith Thotton <sthotton@marvell.com>; >Srisivasubramanian Srinivasan <srinivasan@marvell.com>; Harman Kalra ><hkalra@marvell.com>; rahul.lakkireddy@chelsio.com; johndale@cisco.com; >hyonkim@cisco.com; liudongdong3@huawei.com; >yisen.zhuang@huawei.com; xuanziyang2@huawei.com; >cloud.wangxiaoyun@huawei.com; zhouguoyang@huawei.com; >simei.su@intel.com; wenjun1.wu@intel.com; qiming.yang@intel.com; >Yuying.Zhang@intel.com; beilei.xing@intel.com; xiao.w.wang@intel.com; >jingjing.wu@intel.com; junfeng.guo@intel.com; rosen.xu@intel.com; Nithin >Kumar Dabilpuram <ndabilpuram@marvell.com>; Kiran Kumar Kokkilagadda ><kirankumark@marvell.com>; Sunil Kumar Kori <skori@marvell.com>; Satha >Koteswara Rao Kottidi <skoteshwar@marvell.com>; Liron Himi ><lironh@marvell.com>; zr@semihalf.com; Radha Chintakuntla ><radhac@marvell.com>; Veerasenareddy Burru <vburru@marvell.com>; >Sathesh B Edara <sedara@marvell.com>; matan@nvidia.com; >viacheslavo@nvidia.com; sthemmin@microsoft.com; longli@microsoft.com; >spinler@cesnet.cz; chaoyong.he@corigine.com; >niklas.soderlund@corigine.com; hemant.agrawal@nxp.com; >sachin.saxena@oss.nxp.com; g.singh@nxp.com; apeksha.gupta@nxp.com; >sachin.saxena@nxp.com; aboyer@pensando.io; Rasesh Mody ><rmody@marvell.com>; Shahed Shaikh <shshaikh@marvell.com>; Devendra >Singh Rawat <dsinghrawat@marvell.com>; jiawenwu@trustnetic.com; >jianwang@trustnetic.com; jbehrens@vmware.com; >maxime.coquelin@redhat.com; chenbo.xia@intel.com; >steven.webster@windriver.com; matt.peters@windriver.com; >bruce.richardson@intel.com; mtetsuyah@gmail.com; grive@u256.net; >jasvinder.singh@intel.com; cristian.dumitrescu@intel.com; >jgrajcia@cisco.com >Subject: [EXT] Re: [PATCH v2 0/4] add trace points in ethdev library > >External Email > >---------------------------------------------------------------------- >On 9/29/22 13:29, Ankur Dwivedi wrote: >> This series adds trace points for functions in the ethdev library. >> The trace points are added in ethdev, flow, mtr and tm files. >> >> v2: >> - Made rte_eth_trace_call_rx_callbacks and rte_eth_trace_call_tx_callbacks >> as fastpath trace functions. >> - Moved some trace functions call to the end to capture return value and >> data. > >Looking at the patch series I still see many-many places where tracing happens >on entry point. Intentional? Yes , because the return values are not there to be captured. > >> - Removed rte_eth_trace_tx_queue_setup as it is not required. >> rte_ethdev_trace_txq_setup() is already present in >> rte_eth_tx_queue_setup(). >> - Removed trace in ethdev_driver.c >> - Removed trace function check patch. >> >> Ankur Dwivedi (4): >> ethdev: add trace points >> ethdev: add trace points for flow >> ethdev: add trace points for mtr >> ethdev: add trace points for tm >> >> lib/ethdev/ethdev_private.c | 3 + >> lib/ethdev/ethdev_trace_points.c | 699 ++++++++++ >> lib/ethdev/rte_ethdev.c | 148 +++ >> lib/ethdev/rte_ethdev_trace.h | 2062 >++++++++++++++++++++++++++++++ >> lib/ethdev/rte_ethdev_trace_fp.h | 19 + >> lib/ethdev/rte_flow.c | 54 + >> lib/ethdev/rte_mtr.c | 27 + >> lib/ethdev/rte_tm.c | 40 + >> lib/ethdev/version.map | 232 ++++ >> 9 files changed, 3284 insertions(+) >>
On 10/6/22 10:26, Ankur Dwivedi wrote: > Hi Andrew, > >> -----Original Message----- >> From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru> >> Sent: Thursday, October 6, 2022 12:40 PM >> To: Ankur Dwivedi <adwivedi@marvell.com>; dev@dpdk.org >> Cc: thomas@monjalon.net; mdr@ashroe.eu; orika@nvidia.com; >> ferruh.yigit@xilinx.com; chas3@att.com; humin29@huawei.com; >> linville@tuxdriver.com; ciara.loftus@intel.com; qi.z.zhang@intel.com; >> mw@semihalf.com; mk@semihalf.com; shaibran@amazon.com; >> evgenys@amazon.com; igorch@amazon.com; chandu@amd.com; Igor >> Russkikh <irusskikh@marvell.com>; shepard.siegel@atomicrules.com; >> ed.czeck@atomicrules.com; john.miller@atomicrules.com; >> ajit.khaparde@broadcom.com; somnath.kotur@broadcom.com; Jerin Jacob >> Kollanukkaran <jerinj@marvell.com>; Maciej Czekaj [C] >> <mczekaj@marvell.com>; Shijith Thotton <sthotton@marvell.com>; >> Srisivasubramanian Srinivasan <srinivasan@marvell.com>; Harman Kalra >> <hkalra@marvell.com>; rahul.lakkireddy@chelsio.com; johndale@cisco.com; >> hyonkim@cisco.com; liudongdong3@huawei.com; >> yisen.zhuang@huawei.com; xuanziyang2@huawei.com; >> cloud.wangxiaoyun@huawei.com; zhouguoyang@huawei.com; >> simei.su@intel.com; wenjun1.wu@intel.com; qiming.yang@intel.com; >> Yuying.Zhang@intel.com; beilei.xing@intel.com; xiao.w.wang@intel.com; >> jingjing.wu@intel.com; junfeng.guo@intel.com; rosen.xu@intel.com; Nithin >> Kumar Dabilpuram <ndabilpuram@marvell.com>; Kiran Kumar Kokkilagadda >> <kirankumark@marvell.com>; Sunil Kumar Kori <skori@marvell.com>; Satha >> Koteswara Rao Kottidi <skoteshwar@marvell.com>; Liron Himi >> <lironh@marvell.com>; zr@semihalf.com; Radha Chintakuntla >> <radhac@marvell.com>; Veerasenareddy Burru <vburru@marvell.com>; >> Sathesh B Edara <sedara@marvell.com>; matan@nvidia.com; >> viacheslavo@nvidia.com; sthemmin@microsoft.com; longli@microsoft.com; >> spinler@cesnet.cz; chaoyong.he@corigine.com; >> niklas.soderlund@corigine.com; hemant.agrawal@nxp.com; >> sachin.saxena@oss.nxp.com; g.singh@nxp.com; apeksha.gupta@nxp.com; >> sachin.saxena@nxp.com; aboyer@pensando.io; Rasesh Mody >> <rmody@marvell.com>; Shahed Shaikh <shshaikh@marvell.com>; Devendra >> Singh Rawat <dsinghrawat@marvell.com>; jiawenwu@trustnetic.com; >> jianwang@trustnetic.com; jbehrens@vmware.com; >> maxime.coquelin@redhat.com; chenbo.xia@intel.com; >> steven.webster@windriver.com; matt.peters@windriver.com; >> bruce.richardson@intel.com; mtetsuyah@gmail.com; grive@u256.net; >> jasvinder.singh@intel.com; cristian.dumitrescu@intel.com; >> jgrajcia@cisco.com >> Subject: [EXT] Re: [PATCH v2 0/4] add trace points in ethdev library >> >> External Email >> >> ---------------------------------------------------------------------- >> On 9/29/22 13:29, Ankur Dwivedi wrote: >>> This series adds trace points for functions in the ethdev library. >>> The trace points are added in ethdev, flow, mtr and tm files. >>> >>> v2: >>> - Made rte_eth_trace_call_rx_callbacks and rte_eth_trace_call_tx_callbacks >>> as fastpath trace functions. >>> - Moved some trace functions call to the end to capture return value and >>> data. >> >> Looking at the patch series I still see many-many places where tracing happens >> on entry point. Intentional? > Yes , because the return values are not there to be captured. Isn't it the reason to move trace point to have return value there and capture it? >> >>> - Removed rte_eth_trace_tx_queue_setup as it is not required. >>> rte_ethdev_trace_txq_setup() is already present in >>> rte_eth_tx_queue_setup(). >>> - Removed trace in ethdev_driver.c >>> - Removed trace function check patch. >>> >>> Ankur Dwivedi (4): >>> ethdev: add trace points >>> ethdev: add trace points for flow >>> ethdev: add trace points for mtr >>> ethdev: add trace points for tm >>> >>> lib/ethdev/ethdev_private.c | 3 + >>> lib/ethdev/ethdev_trace_points.c | 699 ++++++++++ >>> lib/ethdev/rte_ethdev.c | 148 +++ >>> lib/ethdev/rte_ethdev_trace.h | 2062 >> ++++++++++++++++++++++++++++++ >>> lib/ethdev/rte_ethdev_trace_fp.h | 19 + >>> lib/ethdev/rte_flow.c | 54 + >>> lib/ethdev/rte_mtr.c | 27 + >>> lib/ethdev/rte_tm.c | 40 + >>> lib/ethdev/version.map | 232 ++++ >>> 9 files changed, 3284 insertions(+) >>> >
>-----Original Message----- >From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru> >Sent: Thursday, October 6, 2022 12:59 PM >To: Ankur Dwivedi <adwivedi@marvell.com>; dev@dpdk.org >Cc: thomas@monjalon.net; mdr@ashroe.eu; orika@nvidia.com; >ferruh.yigit@xilinx.com; chas3@att.com; humin29@huawei.com; >linville@tuxdriver.com; ciara.loftus@intel.com; qi.z.zhang@intel.com; >mw@semihalf.com; mk@semihalf.com; shaibran@amazon.com; >evgenys@amazon.com; igorch@amazon.com; chandu@amd.com; Igor >Russkikh <irusskikh@marvell.com>; shepard.siegel@atomicrules.com; >ed.czeck@atomicrules.com; john.miller@atomicrules.com; >ajit.khaparde@broadcom.com; somnath.kotur@broadcom.com; Jerin Jacob >Kollanukkaran <jerinj@marvell.com>; Maciej Czekaj [C] ><mczekaj@marvell.com>; Shijith Thotton <sthotton@marvell.com>; >Srisivasubramanian Srinivasan <srinivasan@marvell.com>; Harman Kalra ><hkalra@marvell.com>; rahul.lakkireddy@chelsio.com; johndale@cisco.com; >hyonkim@cisco.com; liudongdong3@huawei.com; >yisen.zhuang@huawei.com; xuanziyang2@huawei.com; >cloud.wangxiaoyun@huawei.com; zhouguoyang@huawei.com; >simei.su@intel.com; wenjun1.wu@intel.com; qiming.yang@intel.com; >Yuying.Zhang@intel.com; beilei.xing@intel.com; xiao.w.wang@intel.com; >jingjing.wu@intel.com; junfeng.guo@intel.com; rosen.xu@intel.com; Nithin >Kumar Dabilpuram <ndabilpuram@marvell.com>; Kiran Kumar Kokkilagadda ><kirankumark@marvell.com>; Sunil Kumar Kori <skori@marvell.com>; Satha >Koteswara Rao Kottidi <skoteshwar@marvell.com>; Liron Himi ><lironh@marvell.com>; zr@semihalf.com; Radha Chintakuntla ><radhac@marvell.com>; Veerasenareddy Burru <vburru@marvell.com>; >Sathesh B Edara <sedara@marvell.com>; matan@nvidia.com; >viacheslavo@nvidia.com; sthemmin@microsoft.com; longli@microsoft.com; >spinler@cesnet.cz; chaoyong.he@corigine.com; >niklas.soderlund@corigine.com; hemant.agrawal@nxp.com; >sachin.saxena@oss.nxp.com; g.singh@nxp.com; apeksha.gupta@nxp.com; >sachin.saxena@nxp.com; aboyer@pensando.io; Rasesh Mody ><rmody@marvell.com>; Shahed Shaikh <shshaikh@marvell.com>; Devendra >Singh Rawat <dsinghrawat@marvell.com>; jiawenwu@trustnetic.com; >jianwang@trustnetic.com; jbehrens@vmware.com; >maxime.coquelin@redhat.com; chenbo.xia@intel.com; >steven.webster@windriver.com; matt.peters@windriver.com; >bruce.richardson@intel.com; mtetsuyah@gmail.com; grive@u256.net; >jasvinder.singh@intel.com; cristian.dumitrescu@intel.com; >jgrajcia@cisco.com >Subject: Re: [EXT] Re: [PATCH v2 0/4] add trace points in ethdev library > >On 10/6/22 10:26, Ankur Dwivedi wrote: >> Hi Andrew, >> >>> -----Original Message----- >>> From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru> >>> Sent: Thursday, October 6, 2022 12:40 PM >>> To: Ankur Dwivedi <adwivedi@marvell.com>; dev@dpdk.org >>> Cc: thomas@monjalon.net; mdr@ashroe.eu; orika@nvidia.com; >>> ferruh.yigit@xilinx.com; chas3@att.com; humin29@huawei.com; >>> linville@tuxdriver.com; ciara.loftus@intel.com; qi.z.zhang@intel.com; >>> mw@semihalf.com; mk@semihalf.com; shaibran@amazon.com; >>> evgenys@amazon.com; igorch@amazon.com; chandu@amd.com; Igor >Russkikh >>> <irusskikh@marvell.com>; shepard.siegel@atomicrules.com; >>> ed.czeck@atomicrules.com; john.miller@atomicrules.com; >>> ajit.khaparde@broadcom.com; somnath.kotur@broadcom.com; Jerin >Jacob >>> Kollanukkaran <jerinj@marvell.com>; Maciej Czekaj [C] >>> <mczekaj@marvell.com>; Shijith Thotton <sthotton@marvell.com>; >>> Srisivasubramanian Srinivasan <srinivasan@marvell.com>; Harman Kalra >>> <hkalra@marvell.com>; rahul.lakkireddy@chelsio.com; >>> johndale@cisco.com; hyonkim@cisco.com; liudongdong3@huawei.com; >>> yisen.zhuang@huawei.com; xuanziyang2@huawei.com; >>> cloud.wangxiaoyun@huawei.com; zhouguoyang@huawei.com; >>> simei.su@intel.com; wenjun1.wu@intel.com; qiming.yang@intel.com; >>> Yuying.Zhang@intel.com; beilei.xing@intel.com; xiao.w.wang@intel.com; >>> jingjing.wu@intel.com; junfeng.guo@intel.com; rosen.xu@intel.com; >>> Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>; Kiran Kumar >>> Kokkilagadda <kirankumark@marvell.com>; Sunil Kumar Kori >>> <skori@marvell.com>; Satha Koteswara Rao Kottidi >>> <skoteshwar@marvell.com>; Liron Himi <lironh@marvell.com>; >>> zr@semihalf.com; Radha Chintakuntla <radhac@marvell.com>; >>> Veerasenareddy Burru <vburru@marvell.com>; Sathesh B Edara >>> <sedara@marvell.com>; matan@nvidia.com; viacheslavo@nvidia.com; >>> sthemmin@microsoft.com; longli@microsoft.com; spinler@cesnet.cz; >>> chaoyong.he@corigine.com; niklas.soderlund@corigine.com; >>> hemant.agrawal@nxp.com; sachin.saxena@oss.nxp.com; >g.singh@nxp.com; >>> apeksha.gupta@nxp.com; sachin.saxena@nxp.com; aboyer@pensando.io; >>> Rasesh Mody <rmody@marvell.com>; Shahed Shaikh >>> <shshaikh@marvell.com>; Devendra Singh Rawat >>> <dsinghrawat@marvell.com>; jiawenwu@trustnetic.com; >>> jianwang@trustnetic.com; jbehrens@vmware.com; >>> maxime.coquelin@redhat.com; chenbo.xia@intel.com; >>> steven.webster@windriver.com; matt.peters@windriver.com; >>> bruce.richardson@intel.com; mtetsuyah@gmail.com; grive@u256.net; >>> jasvinder.singh@intel.com; cristian.dumitrescu@intel.com; >>> jgrajcia@cisco.com >>> Subject: [EXT] Re: [PATCH v2 0/4] add trace points in ethdev library >>> >>> External Email >>> >>> --------------------------------------------------------------------- >>> - On 9/29/22 13:29, Ankur Dwivedi wrote: >>>> This series adds trace points for functions in the ethdev library. >>>> The trace points are added in ethdev, flow, mtr and tm files. >>>> >>>> v2: >>>> - Made rte_eth_trace_call_rx_callbacks and >rte_eth_trace_call_tx_callbacks >>>> as fastpath trace functions. >>>> - Moved some trace functions call to the end to capture return value and >>>> data. >>> >>> Looking at the patch series I still see many-many places where >>> tracing happens on entry point. Intentional? >> Yes , because the return values are not there to be captured. > >Isn't it the reason to move trace point to have return value there and capture >it? [Ankur] For some function the return value was there to be captured. But for some functions the return values are not possible to get unless some more changes are made in code, like the rte_eth_rx_metadata_negotiate() you mentioned in earlier mail. I have not modified the existing code of library, just added trace to capture what can be captured. > >>> >>>> - Removed rte_eth_trace_tx_queue_setup as it is not required. >>>> rte_ethdev_trace_txq_setup() is already present in >>>> rte_eth_tx_queue_setup(). >>>> - Removed trace in ethdev_driver.c >>>> - Removed trace function check patch. >>>> >>>> Ankur Dwivedi (4): >>>> ethdev: add trace points >>>> ethdev: add trace points for flow >>>> ethdev: add trace points for mtr >>>> ethdev: add trace points for tm >>>> >>>> lib/ethdev/ethdev_private.c | 3 + >>>> lib/ethdev/ethdev_trace_points.c | 699 ++++++++++ >>>> lib/ethdev/rte_ethdev.c | 148 +++ >>>> lib/ethdev/rte_ethdev_trace.h | 2062 >>> ++++++++++++++++++++++++++++++ >>>> lib/ethdev/rte_ethdev_trace_fp.h | 19 + >>>> lib/ethdev/rte_flow.c | 54 + >>>> lib/ethdev/rte_mtr.c | 27 + >>>> lib/ethdev/rte_tm.c | 40 + >>>> lib/ethdev/version.map | 232 ++++ >>>> 9 files changed, 3284 insertions(+) >>>> >>
Hi Andrew, >-----Original Message----- >From: Ankur Dwivedi >Sent: Thursday, October 6, 2022 1:18 PM >To: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>; dev@dpdk.org >Cc: thomas@monjalon.net; mdr@ashroe.eu; orika@nvidia.com; >ferruh.yigit@xilinx.com; chas3@att.com; humin29@huawei.com; >linville@tuxdriver.com; ciara.loftus@intel.com; qi.z.zhang@intel.com; >mw@semihalf.com; mk@semihalf.com; shaibran@amazon.com; >evgenys@amazon.com; igorch@amazon.com; chandu@amd.com; Igor >Russkikh <irusskikh@marvell.com>; shepard.siegel@atomicrules.com; >ed.czeck@atomicrules.com; john.miller@atomicrules.com; >ajit.khaparde@broadcom.com; somnath.kotur@broadcom.com; Jerin Jacob >Kollanukkaran <jerinj@marvell.com>; Maciej Czekaj [C] ><mczekaj@marvell.com>; Shijith Thotton <sthotton@marvell.com>; >Srisivasubramanian Srinivasan <srinivasan@marvell.com>; Harman Kalra ><hkalra@marvell.com>; rahul.lakkireddy@chelsio.com; johndale@cisco.com; >hyonkim@cisco.com; liudongdong3@huawei.com; >yisen.zhuang@huawei.com; xuanziyang2@huawei.com; >cloud.wangxiaoyun@huawei.com; zhouguoyang@huawei.com; >simei.su@intel.com; wenjun1.wu@intel.com; qiming.yang@intel.com; >Yuying.Zhang@intel.com; beilei.xing@intel.com; xiao.w.wang@intel.com; >jingjing.wu@intel.com; junfeng.guo@intel.com; rosen.xu@intel.com; Nithin >Kumar Dabilpuram <ndabilpuram@marvell.com>; Kiran Kumar Kokkilagadda ><kirankumark@marvell.com>; Sunil Kumar Kori <skori@marvell.com>; Satha >Koteswara Rao Kottidi <skoteshwar@marvell.com>; Liron Himi ><lironh@marvell.com>; zr@semihalf.com; Radha Chintakuntla ><radhac@marvell.com>; Veerasenareddy Burru <vburru@marvell.com>; >Sathesh B Edara <sedara@marvell.com>; matan@nvidia.com; >viacheslavo@nvidia.com; sthemmin@microsoft.com; longli@microsoft.com; >spinler@cesnet.cz; chaoyong.he@corigine.com; >niklas.soderlund@corigine.com; hemant.agrawal@nxp.com; >sachin.saxena@oss.nxp.com; g.singh@nxp.com; apeksha.gupta@nxp.com; >sachin.saxena@nxp.com; aboyer@pensando.io; Rasesh Mody ><rmody@marvell.com>; Shahed Shaikh <shshaikh@marvell.com>; Devendra >Singh Rawat <dsinghrawat@marvell.com>; jiawenwu@trustnetic.com; >jianwang@trustnetic.com; jbehrens@vmware.com; >maxime.coquelin@redhat.com; chenbo.xia@intel.com; >steven.webster@windriver.com; matt.peters@windriver.com; >bruce.richardson@intel.com; mtetsuyah@gmail.com; grive@u256.net; >jasvinder.singh@intel.com; cristian.dumitrescu@intel.com; >jgrajcia@cisco.com >Subject: RE: [EXT] Re: [PATCH v2 0/4] add trace points in ethdev library > > > >>-----Original Message----- >>From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru> >>Sent: Thursday, October 6, 2022 12:59 PM >>To: Ankur Dwivedi <adwivedi@marvell.com>; dev@dpdk.org >>Cc: thomas@monjalon.net; mdr@ashroe.eu; orika@nvidia.com; >>ferruh.yigit@xilinx.com; chas3@att.com; humin29@huawei.com; >>linville@tuxdriver.com; ciara.loftus@intel.com; qi.z.zhang@intel.com; >>mw@semihalf.com; mk@semihalf.com; shaibran@amazon.com; >>evgenys@amazon.com; igorch@amazon.com; chandu@amd.com; Igor >Russkikh >><irusskikh@marvell.com>; shepard.siegel@atomicrules.com; >>ed.czeck@atomicrules.com; john.miller@atomicrules.com; >>ajit.khaparde@broadcom.com; somnath.kotur@broadcom.com; Jerin Jacob >>Kollanukkaran <jerinj@marvell.com>; Maciej Czekaj [C] >><mczekaj@marvell.com>; Shijith Thotton <sthotton@marvell.com>; >>Srisivasubramanian Srinivasan <srinivasan@marvell.com>; Harman Kalra >><hkalra@marvell.com>; rahul.lakkireddy@chelsio.com; >johndale@cisco.com; >>hyonkim@cisco.com; liudongdong3@huawei.com; >yisen.zhuang@huawei.com; >>xuanziyang2@huawei.com; cloud.wangxiaoyun@huawei.com; >>zhouguoyang@huawei.com; simei.su@intel.com; wenjun1.wu@intel.com; >>qiming.yang@intel.com; Yuying.Zhang@intel.com; beilei.xing@intel.com; >>xiao.w.wang@intel.com; jingjing.wu@intel.com; junfeng.guo@intel.com; >>rosen.xu@intel.com; Nithin Kumar Dabilpuram ><ndabilpuram@marvell.com>; >>Kiran Kumar Kokkilagadda <kirankumark@marvell.com>; Sunil Kumar Kori >><skori@marvell.com>; Satha Koteswara Rao Kottidi >><skoteshwar@marvell.com>; Liron Himi <lironh@marvell.com>; >>zr@semihalf.com; Radha Chintakuntla <radhac@marvell.com>; >>Veerasenareddy Burru <vburru@marvell.com>; Sathesh B Edara >><sedara@marvell.com>; matan@nvidia.com; viacheslavo@nvidia.com; >>sthemmin@microsoft.com; longli@microsoft.com; spinler@cesnet.cz; >>chaoyong.he@corigine.com; niklas.soderlund@corigine.com; >>hemant.agrawal@nxp.com; sachin.saxena@oss.nxp.com; g.singh@nxp.com; >>apeksha.gupta@nxp.com; sachin.saxena@nxp.com; aboyer@pensando.io; >>Rasesh Mody <rmody@marvell.com>; Shahed Shaikh ><shshaikh@marvell.com>; >>Devendra Singh Rawat <dsinghrawat@marvell.com>; >>jiawenwu@trustnetic.com; jianwang@trustnetic.com; >jbehrens@vmware.com; >>maxime.coquelin@redhat.com; chenbo.xia@intel.com; >>steven.webster@windriver.com; matt.peters@windriver.com; >>bruce.richardson@intel.com; mtetsuyah@gmail.com; grive@u256.net; >>jasvinder.singh@intel.com; cristian.dumitrescu@intel.com; >>jgrajcia@cisco.com >>Subject: Re: [EXT] Re: [PATCH v2 0/4] add trace points in ethdev >>library >> >>On 10/6/22 10:26, Ankur Dwivedi wrote: >>> Hi Andrew, >>> >>>> -----Original Message----- >>>> From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru> >>>> Sent: Thursday, October 6, 2022 12:40 PM >>>> To: Ankur Dwivedi <adwivedi@marvell.com>; dev@dpdk.org >>>> Cc: thomas@monjalon.net; mdr@ashroe.eu; orika@nvidia.com; >>>> ferruh.yigit@xilinx.com; chas3@att.com; humin29@huawei.com; >>>> linville@tuxdriver.com; ciara.loftus@intel.com; >>>> qi.z.zhang@intel.com; mw@semihalf.com; mk@semihalf.com; >>>> shaibran@amazon.com; evgenys@amazon.com; igorch@amazon.com; >>>> chandu@amd.com; Igor >>Russkikh >>>> <irusskikh@marvell.com>; shepard.siegel@atomicrules.com; >>>> ed.czeck@atomicrules.com; john.miller@atomicrules.com; >>>> ajit.khaparde@broadcom.com; somnath.kotur@broadcom.com; Jerin >>Jacob >>>> Kollanukkaran <jerinj@marvell.com>; Maciej Czekaj [C] >>>> <mczekaj@marvell.com>; Shijith Thotton <sthotton@marvell.com>; >>>> Srisivasubramanian Srinivasan <srinivasan@marvell.com>; Harman Kalra >>>> <hkalra@marvell.com>; rahul.lakkireddy@chelsio.com; >>>> johndale@cisco.com; hyonkim@cisco.com; liudongdong3@huawei.com; >>>> yisen.zhuang@huawei.com; xuanziyang2@huawei.com; >>>> cloud.wangxiaoyun@huawei.com; zhouguoyang@huawei.com; >>>> simei.su@intel.com; wenjun1.wu@intel.com; qiming.yang@intel.com; >>>> Yuying.Zhang@intel.com; beilei.xing@intel.com; >>>> xiao.w.wang@intel.com; jingjing.wu@intel.com; junfeng.guo@intel.com; >>>> rosen.xu@intel.com; Nithin Kumar Dabilpuram >>>> <ndabilpuram@marvell.com>; Kiran Kumar Kokkilagadda >>>> <kirankumark@marvell.com>; Sunil Kumar Kori <skori@marvell.com>; >>>> Satha Koteswara Rao Kottidi <skoteshwar@marvell.com>; Liron Himi >>>> <lironh@marvell.com>; zr@semihalf.com; Radha Chintakuntla >>>> <radhac@marvell.com>; Veerasenareddy Burru <vburru@marvell.com>; >>>> Sathesh B Edara <sedara@marvell.com>; matan@nvidia.com; >>>> viacheslavo@nvidia.com; sthemmin@microsoft.com; >>>> longli@microsoft.com; spinler@cesnet.cz; chaoyong.he@corigine.com; >>>> niklas.soderlund@corigine.com; hemant.agrawal@nxp.com; >>>> sachin.saxena@oss.nxp.com; >>g.singh@nxp.com; >>>> apeksha.gupta@nxp.com; sachin.saxena@nxp.com; >aboyer@pensando.io; >>>> Rasesh Mody <rmody@marvell.com>; Shahed Shaikh >>>> <shshaikh@marvell.com>; Devendra Singh Rawat >>>> <dsinghrawat@marvell.com>; jiawenwu@trustnetic.com; >>>> jianwang@trustnetic.com; jbehrens@vmware.com; >>>> maxime.coquelin@redhat.com; chenbo.xia@intel.com; >>>> steven.webster@windriver.com; matt.peters@windriver.com; >>>> bruce.richardson@intel.com; mtetsuyah@gmail.com; grive@u256.net; >>>> jasvinder.singh@intel.com; cristian.dumitrescu@intel.com; >>>> jgrajcia@cisco.com >>>> Subject: [EXT] Re: [PATCH v2 0/4] add trace points in ethdev library >>>> >>>> External Email >>>> >>>> -------------------------------------------------------------------- >>>> - >>>> - On 9/29/22 13:29, Ankur Dwivedi wrote: >>>>> This series adds trace points for functions in the ethdev library. >>>>> The trace points are added in ethdev, flow, mtr and tm files. >>>>> >>>>> v2: >>>>> - Made rte_eth_trace_call_rx_callbacks and >>rte_eth_trace_call_tx_callbacks >>>>> as fastpath trace functions. >>>>> - Moved some trace functions call to the end to capture return value >and >>>>> data. >>>> >>>> Looking at the patch series I still see many-many places where >>>> tracing happens on entry point. Intentional? >>> Yes , because the return values are not there to be captured. >> >>Isn't it the reason to move trace point to have return value there and >>capture it? >[Ankur] For some function the return value was there to be captured. But for >some functions the return values are not possible to get unless some more >changes are made in code, like the rte_eth_rx_metadata_negotiate() you >mentioned in earlier mail. I have not modified the existing code of library, just >added trace to capture what can be captured. [Ankur] Identified few more functions for which trace can be shift towards the end of a function. Will send the changes in v3. >> >>>> >>>>> - Removed rte_eth_trace_tx_queue_setup as it is not required. >>>>> rte_ethdev_trace_txq_setup() is already present in >>>>> rte_eth_tx_queue_setup(). >>>>> - Removed trace in ethdev_driver.c >>>>> - Removed trace function check patch. >>>>> >>>>> Ankur Dwivedi (4): >>>>> ethdev: add trace points >>>>> ethdev: add trace points for flow >>>>> ethdev: add trace points for mtr >>>>> ethdev: add trace points for tm >>>>> >>>>> lib/ethdev/ethdev_private.c | 3 + >>>>> lib/ethdev/ethdev_trace_points.c | 699 ++++++++++ >>>>> lib/ethdev/rte_ethdev.c | 148 +++ >>>>> lib/ethdev/rte_ethdev_trace.h | 2062 >>>> ++++++++++++++++++++++++++++++ >>>>> lib/ethdev/rte_ethdev_trace_fp.h | 19 + >>>>> lib/ethdev/rte_flow.c | 54 + >>>>> lib/ethdev/rte_mtr.c | 27 + >>>>> lib/ethdev/rte_tm.c | 40 + >>>>> lib/ethdev/version.map | 232 ++++ >>>>> 9 files changed, 3284 insertions(+) >>>>> >>>