diff mbox series

app/testpmd: fix incorrect flow arguments name

Message ID 20220930113950.833-1-suanmingm@nvidia.com (mailing list archive)
State Accepted, archived
Delegated to: Andrew Rybchenko
Headers
Series app/testpmd: fix incorrect flow arguments name |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/github-robot: build success github build: passed
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/intel-Testing success Testing PASS

Commit Message

Suanming Mou Sept. 30, 2022, 11:39 a.m. UTC 
  There should be no spaces in flow command arguments name.
This commit removes incorrect arguments name in queue based table
template.

Fixes: ecdc927b99f2 ("app/testpmd: add async flow create/destroy operations")
Cc: akozyrev@nvidia.com

Signed-off-by: Suanming Mou <suanmingm@nvidia.com>
---
 app/test-pmd/cmdline_flow.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Singh, Aman Deep Oct. 6, 2022, 7:59 a.m. UTC | #1 
On 9/30/2022 5:09 PM, Suanming Mou wrote:
> There should be no spaces in flow command arguments name.
> This commit removes incorrect arguments name in queue based table
> template.
>
> Fixes: ecdc927b99f2 ("app/testpmd: add async flow create/destroy operations")
> Cc: akozyrev@nvidia.com
>
> Signed-off-by: Suanming Mou <suanmingm@nvidia.com>
> Acked-by: Aman Singh<aman.deep.singh@intel.com>
>
> ---
>   app/test-pmd/cmdline_flow.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
> index 148dbc082d..e59d64ffa9 100644
> --- a/app/test-pmd/cmdline_flow.c
> +++ b/app/test-pmd/cmdline_flow.c
> @@ -2968,7 +2968,7 @@ static const struct token token_list[] = {
>   	},
>   	/* Queue  arguments. */
>   	[QUEUE_TEMPLATE_TABLE] = {
> -		.name = "template table",
> +		.name = "template_table",
>   		.help = "specify table id",
>   		.next = NEXT(NEXT_ENTRY(QUEUE_PATTERN_TEMPLATE),
>   			     NEXT_ENTRY(COMMON_TABLE_ID)),
Ori Kam Oct. 11, 2022, 6:55 a.m. UTC | #2 
> -----Original Message-----
> From: Singh, Aman Deep <aman.deep.singh@intel.com>
> Sent: Thursday, 6 October 2022 10:59
> 
> 
> 
> On 9/30/2022 5:09 PM, Suanming Mou wrote:
> > There should be no spaces in flow command arguments name.
> > This commit removes incorrect arguments name in queue based table
> > template.
> >
> > Fixes: ecdc927b99f2 ("app/testpmd: add async flow create/destroy
> operations")
> > Cc: akozyrev@nvidia.com
> >
> > Signed-off-by: Suanming Mou <suanmingm@nvidia.com>
> > Acked-by: Aman Singh<aman.deep.singh@intel.com>
> >
> > ---


Acked-by: Ori Kam <orika@nvidia.com>
Thanks,
Ori
Andrew Rybchenko Oct. 17, 2022, 7:53 a.m. UTC | #3 
On 10/11/22 09:55, Ori Kam wrote:
> 
> 
>> -----Original Message-----
>> From: Singh, Aman Deep <aman.deep.singh@intel.com>
>> Sent: Thursday, 6 October 2022 10:59
>>
>>
>>
>> On 9/30/2022 5:09 PM, Suanming Mou wrote:
>>> There should be no spaces in flow command arguments name.
>>> This commit removes incorrect arguments name in queue based table
>>> template.
>>>
>>> Fixes: ecdc927b99f2 ("app/testpmd: add async flow create/destroy
>> operations")
>>> Cc: akozyrev@nvidia.com
>>>
>>> Signed-off-by: Suanming Mou <suanmingm@nvidia.com>
>>> Acked-by: Aman Singh<aman.deep.singh@intel.com>

Acked-by: Aman Singh <aman.deep.singh@intel.com>

>>>
>>> ---
> 
> 
> Acked-by: Ori Kam <orika@nvidia.com>
> Thanks,
> Ori


Applied to dpdk-next-net/main, thanks.
diff mbox series

Patch

diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index 148dbc082d..e59d64ffa9 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c
@@ -2968,7 +2968,7 @@  static const struct token token_list[] = {
 	},
 	/* Queue  arguments. */
 	[QUEUE_TEMPLATE_TABLE] = {
-		.name = "template table",
+		.name = "template_table",
 		.help = "specify table id",
 		.next = NEXT(NEXT_ENTRY(QUEUE_PATTERN_TEMPLATE),
 			     NEXT_ENTRY(COMMON_TABLE_ID)),