diff mbox series

test/mbuf: fix mbuf_autotest retest fail

Message ID 20230131024851.11121-1-haijie1@huawei.com (mailing list archive)
State Accepted, archived
Delegated to: David Marchand
Headers
Series test/mbuf: fix mbuf_autotest retest fail |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/github-robot: build success github build: passed
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/intel-Testing success Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-testing fail Testing issues
ci/iol-x86_64-unit-testing fail Testing issues
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS

Commit Message

Jie Hai Jan. 31, 2023, 2:48 a.m. UTC 
  Retest "mbuf_autotest" will fail because the mbuf pool was
not freed after previous test successful done.
This patch fixes it.

Fixes: efc6f9104c80 ("mbuf: fix reset on mbuf free")
Cc: stable@dpdk.org

Signed-off-by: Jie Hai <haijie1@huawei.com>
---
 app/test/test_mbuf.c | 1 +
 1 file changed, 1 insertion(+)

Comments

David Marchand Feb. 7, 2023, 1:21 p.m. UTC | #1 
On Tue, Jan 31, 2023 at 3:52 AM Jie Hai <haijie1@huawei.com> wrote:
>
> Retest "mbuf_autotest" will fail because the mbuf pool was
> not freed after previous test successful done.
> This patch fixes it.

Good catch.

>
> Fixes: efc6f9104c80 ("mbuf: fix reset on mbuf free")
> Cc: stable@dpdk.org
>
> Signed-off-by: Jie Hai <haijie1@huawei.com>

Reviewed-by: David Marchand <david.marchand@redhat.com>
David Marchand Feb. 10, 2023, 11:57 a.m. UTC | #2 
On Tue, Feb 7, 2023 at 2:21 PM David Marchand <david.marchand@redhat.com> wrote:
> On Tue, Jan 31, 2023 at 3:52 AM Jie Hai <haijie1@huawei.com> wrote:
> >
> > Retest "mbuf_autotest" will fail because the mbuf pool was
> > not freed after previous test successful done.
> > This patch fixes it.
> >
> > Fixes: efc6f9104c80 ("mbuf: fix reset on mbuf free")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Jie Hai <haijie1@huawei.com>
> Reviewed-by: David Marchand <david.marchand@redhat.com>

Applied, thanks.
diff mbox series

Patch

diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c
index 53fe898a384c..6cbb03b0afaa 100644
--- a/app/test/test_mbuf.c
+++ b/app/test/test_mbuf.c
@@ -2764,6 +2764,7 @@  test_nb_segs_and_next_reset(void)
 			m2->nb_segs != 1 || m2->next != NULL)
 		GOTO_FAIL("nb_segs or next was not reset properly");
 
+	rte_mempool_free(pool);
 	return 0;
 
 fail: