ci: fix build for Arm cross compilation in GHA
Checks
Commit Message
We are hitting a storage limit when linking binaries statically.
On the other hand, native builds are tested in other part of the CI and
the chance of breaking static linking only is relatively low, so let's
simply test linking against shared libraries.
Cc: stable@dpdk.org
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
.github/workflows/build.yml | 1 +
1 file changed, 1 insertion(+)
Comments
On Tue, Jun 06, 2023 at 12:52:47PM +0200, David Marchand wrote:
> We are hitting a storage limit when linking binaries statically.
> On the other hand, native builds are tested in other part of the CI and
> the chance of breaking static linking only is relatively low, so let's
> simply test linking against shared libraries.
>
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> .github/workflows/build.yml | 1 +
> 1 file changed, 1 insertion(+)
Yep, with the number of "test" apps now in each build, our build
directories get rather massive!
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
On 6/6/2023 12:00 PM, Bruce Richardson wrote:
> On Tue, Jun 06, 2023 at 12:52:47PM +0200, David Marchand wrote:
>> We are hitting a storage limit when linking binaries statically.
>> On the other hand, native builds are tested in other part of the CI and
>> the chance of breaking static linking only is relatively low, so let's
>> simply test linking against shared libraries.
>>
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: David Marchand <david.marchand@redhat.com>
>> ---
>> .github/workflows/build.yml | 1 +
>> 1 file changed, 1 insertion(+)
>
> Yep, with the number of "test" apps now in each build, our build
> directories get rather massive!
>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
>
Confirmed that this solves the "running out of disk space" issue seen on
'ubuntu-20.04-gcc-aarch64',
Tested-by: Ferruh Yigit <ferruh.yigit@amd.com>
06/06/2023 15:02, Ferruh Yigit:
> On 6/6/2023 12:00 PM, Bruce Richardson wrote:
> > On Tue, Jun 06, 2023 at 12:52:47PM +0200, David Marchand wrote:
> >> We are hitting a storage limit when linking binaries statically.
> >> On the other hand, native builds are tested in other part of the CI and
> >> the chance of breaking static linking only is relatively low, so let's
> >> simply test linking against shared libraries.
> >>
> >> Cc: stable@dpdk.org
> >>
> >> Signed-off-by: David Marchand <david.marchand@redhat.com>
> >> ---
> >> .github/workflows/build.yml | 1 +
> >> 1 file changed, 1 insertion(+)
> >
> > Yep, with the number of "test" apps now in each build, our build
> > directories get rather massive!
> >
> > Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> >
>
> Confirmed that this solves the "running out of disk space" issue seen on
> 'ubuntu-20.04-gcc-aarch64',
>
> Tested-by: Ferruh Yigit <ferruh.yigit@amd.com>
Applied, thanks.
@@ -53,6 +53,7 @@ jobs:
cross: mingw
- os: ubuntu-20.04
compiler: gcc
+ library: shared
cross: aarch64
- os: ubuntu-20.04
compiler: gcc