Message ID | 20231220064502.2830-6-sivaprasad.tummala@amd.com (mailing list archive) |
---|---|
State | Superseded, archived |
Delegated to: | Thomas Monjalon |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F0F444372F; Wed, 20 Dec 2023 07:46:08 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B901D42E7C; Wed, 20 Dec 2023 07:46:04 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2089.outbound.protection.outlook.com [40.107.244.89]) by mails.dpdk.org (Postfix) with ESMTP id 533C640EF1; Wed, 20 Dec 2023 07:46:03 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ECg94l86VPiH5lQO2svUSsyeKTbOLA+LqvkFKvNzaW7hw2iDKh6a5F3eduJgBSu1l1MS1Ir9MIPv4UqbdCzBj+8t6yLQhK8kawfyj/CmkekyfIA90Y0j2s97zsGkZBya8UYDkXDYi5+kd/p4rqxKC6dv1msRKqyVysRqScSsCe9cyDUTQBgu+/b/zdXVlVS48kV8X2oLA44omMcDxzKGfN4kZ/WQ9GbeQdvbxsfJ0+CbQRycUpsVqXButMGuUdEnTNMwwAlZQDno2T/oW6ySKtRqPIGOAeUMPWdX5fOOAhKZLXx+PzLrhf8a57YY/MjkE1rSndDkmRK6WMJk7wXUOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jD6y2+mVBnTppD6Uln3qKfA7bxRgibnJHITerqEztrQ=; b=JXW1wgAhybdRcsqBYpeWX7YG0kiROWiVLLOWf1/ZBQXdJGYdRlsRJsQ/KWuQCMSu5MVO6aPX44hU2NZmobhgkXuoD1AmIl86HN6mDPmaoKOQ4VCjsGnEjmCmfhgzohbSpcNIMuv86T6kV9sZP3kU1Qpizaq4ek7UWkGAaWZWaCNsKYXBo/lI2y36gaMp8kf8xSVPvRLxBrzJo14uZZFUeJuxB5vGuAhde/VRvC6VkSRE7P3/IyAaKCpWhcDHi+eecHWo5bGxkSyw1NgJClSa6sCz7zj6SyfBp+hk9f3WEK0jTKEW+ZMbyM5MqG1kbhUk+Ws2wkkGreP5wj7YLgehJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jD6y2+mVBnTppD6Uln3qKfA7bxRgibnJHITerqEztrQ=; b=hPDuaI0zn+pZlQKhRSxs1HOTLGt379PXizoEyxEYfTJ8tLZiUcaSBIJbcXgrKA6WBLMtjIfvYp1nRj4Kq70L+VDziWWm8qTyPkR91GHr4No1R/v/98wfuBNs+Y/0f8UfKXQwodL1GlvGjMo6eJmeirMcBGoRv0Vwa+OHiax9Zjg= Received: from BL6PEPF00013E09.NAMP222.PROD.OUTLOOK.COM (2603:10b6:22e:400:0:1001:0:6) by IA0PR12MB7775.namprd12.prod.outlook.com (2603:10b6:208:431::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.38; Wed, 20 Dec 2023 06:46:00 +0000 Received: from BL6PEPF0001AB50.namprd04.prod.outlook.com (2a01:111:f403:f902::) by BL6PEPF00013E09.outlook.office365.com (2603:1036:903:4::4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.29 via Frontend Transport; Wed, 20 Dec 2023 06:46:00 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BL6PEPF0001AB50.mail.protection.outlook.com (10.167.242.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7113.14 via Frontend Transport; Wed, 20 Dec 2023 06:46:00 +0000 Received: from ubuntu2004.linuxvmimages.local (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Wed, 20 Dec 2023 00:45:42 -0600 From: Sivaprasad Tummala <sivaprasad.tummala@amd.com> To: <david.hunt@intel.com>, <anatoly.burakov@intel.com>, <jerinj@marvell.com>, <radu.nicolau@intel.com>, <gakhil@marvell.com>, <cristian.dumitrescu@intel.com>, <ferruh.yigit@amd.com>, <konstantin.ananyev@huawei.com> CC: <dev@dpdk.org>, <stable@dpdk.org> Subject: [PATCH v3 5/6] examples/qos_sched: fix lcore ID restriction Date: Wed, 20 Dec 2023 07:45:00 +0100 Message-ID: <20231220064502.2830-6-sivaprasad.tummala@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231220064502.2830-1-sivaprasad.tummala@amd.com> References: <20231219032826.4814-1-sivaprasad.tummala@amd.com> <20231220064502.2830-1-sivaprasad.tummala@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF0001AB50:EE_|IA0PR12MB7775:EE_ X-MS-Office365-Filtering-Correlation-Id: 2a38c117-49aa-4273-5dad-08dc0127543c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: r/2vnCLmsf91fq06l2WPdTNqfGLrByYXN4xodajyISaNYve8BzgLWWhB1UzsUlMtUssvqkkHOBBMZaDiNIM0WQHEWjPs2f/v/69uO3OXZTro+q65/BHahuAlfkhARG+PcmRUHutgmo0XrtiLM6aY7KyECs29kMdAHGXVVA6i4hyuU/yibPBfZiuEWmP8VY1SmmWLNtyq2wO6qTwJozSv0mkVE9SWYminlBkzbvAKtCd11kFJteV9Ahg/kRmxKDEtTTrYbL1b6tgKIA03Fkb1MnArSbAbBZIM7viYPfMwMGxAGCjHT+Q2VpWcXJh+x8pTWRbGF8qwRrEsLwzXHVdlaJCjELAKhMfCMK86leTGidgdnb+TZ2vAfgorI5qFF8xrpGFwqTFrh9i/wDf2vnyX06ooNPGfTD6bk1n7DkpNtaoeSVB5nPaROFdNC0Uz2IY1B+Wfk5JyzafYvF+Xr7i8S94AmfepyqjUMGWW98ITcBQRQkLiRJwnd1j6poXn2DBa3cU8QNY6vB0aq8+xOUnDIWzjTKeOaT3lYJnxaXb8Oj/WiVrZx0bwpwmq721AYozSfw5ttzHRyvZ4MtbY/rESgdC8eBIpuRKoluUW23HliIS8Yxeg/IwDd144k9TMdV8qLrEMOC88iSlaeQNb41qXcUd9zVpmQJ0rBEJWNbEl3xwKi9iyR8uvhJtX2IsEgy0LFsllW5r82uG5k0nwQr1Pxu4tbJDXwEYyQS6z8WCeFhLG8BTtF22PUTZSf9Lj7szOE6IY8l3ei8FaATWGhQ5qnA== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(4636009)(376002)(346002)(396003)(39860400002)(136003)(230922051799003)(451199024)(186009)(82310400011)(1800799012)(64100799003)(36840700001)(46966006)(40470700004)(40480700001)(40460700003)(336012)(1076003)(2616005)(16526019)(6666004)(26005)(426003)(82740400003)(83380400001)(356005)(81166007)(2906002)(36756003)(86362001)(478600001)(41300700001)(8936002)(4326008)(110136005)(36860700001)(8676002)(5660300002)(47076005)(4744005)(70206006)(44832011)(54906003)(70586007)(316002)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Dec 2023 06:46:00.7893 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2a38c117-49aa-4273-5dad-08dc0127543c X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF0001AB50.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB7775 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org |
Series |
fix lcore ID restriction
|
|
Checks
Context | Check | Description |
---|---|---|
ci/checkpatch | success | coding style OK |
Commit Message
Sivaprasad Tummala
Dec. 20, 2023, 6:45 a.m. UTC
Currently the config option allows lcore IDs up to 255,
irrespective of RTE_MAX_LCORES and needs to be fixed.
The patch allows config options based on DPDK config.
Fixes: de3cfa2c9823 ("sched: initial import")
Cc: stable@dpdk.org
Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>
---
examples/qos_sched/args.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Comments
On Wed, 20 Dec 2023 07:45:00 +0100 Sivaprasad Tummala <sivaprasad.tummala@amd.com> wrote: > diff --git a/examples/qos_sched/args.c b/examples/qos_sched/args.c > index e97273152a..22fe76eeb5 100644 > --- a/examples/qos_sched/args.c > +++ b/examples/qos_sched/args.c > @@ -182,10 +182,10 @@ app_parse_flow_conf(const char *conf_str) > > pconf->rx_port = vals[0]; > pconf->tx_port = vals[1]; > - pconf->rx_core = (uint8_t)vals[2]; > - pconf->wt_core = (uint8_t)vals[3]; > + pconf->rx_core = (uint16_t)vals[2]; > + pconf->wt_core = (uint16_t)vals[3]; > if (ret == 5) > - pconf->tx_core = (uint8_t)vals[4]; > + pconf->tx_core = (uint16_t)vals[4]; > else > pconf->tx_core = pconf->wt_core; > > -- Not sure why cast is even needed, assigning uint32_t to uint16_t is not going to generate a warning with current compiler settings.
On 12/20/2023 4:31 PM, Stephen Hemminger wrote: > On Wed, 20 Dec 2023 07:45:00 +0100 > Sivaprasad Tummala <sivaprasad.tummala@amd.com> wrote: > >> diff --git a/examples/qos_sched/args.c b/examples/qos_sched/args.c >> index e97273152a..22fe76eeb5 100644 >> --- a/examples/qos_sched/args.c >> +++ b/examples/qos_sched/args.c >> @@ -182,10 +182,10 @@ app_parse_flow_conf(const char *conf_str) >> >> pconf->rx_port = vals[0]; >> pconf->tx_port = vals[1]; >> - pconf->rx_core = (uint8_t)vals[2]; >> - pconf->wt_core = (uint8_t)vals[3]; >> + pconf->rx_core = (uint16_t)vals[2]; >> + pconf->wt_core = (uint16_t)vals[3]; >> if (ret == 5) >> - pconf->tx_core = (uint8_t)vals[4]; >> + pconf->tx_core = (uint16_t)vals[4]; >> else >> pconf->tx_core = pconf->wt_core; >> >> -- > > Not sure why cast is even needed, assigning uint32_t to uint16_t > is not going to generate a warning with current compiler settings. > I was assuming compiler will complain when assigning uint32_t to uint16_t, but it seems '-Wconversion' compiler flag is required for this warning. Enabling this flag for DPDK build causes lots of warnings, I wonder if we should add a new buildtype in meson that enables this flag. And except from compiler warning, I think it is good to keep explicit cast where assignment can cause change of value. This at worst can work as documentation that assignment between different types done intentionally.
[AMD Official Use Only - General] Hi Stephen, > -----Original Message----- > From: Yigit, Ferruh <Ferruh.Yigit@amd.com> > Sent: Tuesday, January 9, 2024 8:47 PM > To: Stephen Hemminger <stephen@networkplumber.org>; Tummala, Sivaprasad > <Sivaprasad.Tummala@amd.com> > Cc: david.hunt@intel.com; anatoly.burakov@intel.com; jerinj@marvell.com; > radu.nicolau@intel.com; gakhil@marvell.com; cristian.dumitrescu@intel.com; > konstantin.ananyev@huawei.com; dev@dpdk.org; stable@dpdk.org; Bruce > Richardson <bruce.richardson@intel.com> > Subject: Re: [PATCH v3 5/6] examples/qos_sched: fix lcore ID restriction > > On 12/20/2023 4:31 PM, Stephen Hemminger wrote: > > On Wed, 20 Dec 2023 07:45:00 +0100 > > Sivaprasad Tummala <sivaprasad.tummala@amd.com> wrote: > > > >> diff --git a/examples/qos_sched/args.c b/examples/qos_sched/args.c > >> index e97273152a..22fe76eeb5 100644 > >> --- a/examples/qos_sched/args.c > >> +++ b/examples/qos_sched/args.c > >> @@ -182,10 +182,10 @@ app_parse_flow_conf(const char *conf_str) > >> > >> pconf->rx_port = vals[0]; > >> pconf->tx_port = vals[1]; > >> - pconf->rx_core = (uint8_t)vals[2]; > >> - pconf->wt_core = (uint8_t)vals[3]; > >> + pconf->rx_core = (uint16_t)vals[2]; > >> + pconf->wt_core = (uint16_t)vals[3]; > >> if (ret == 5) > >> - pconf->tx_core = (uint8_t)vals[4]; > >> + pconf->tx_core = (uint16_t)vals[4]; > >> else > >> pconf->tx_core = pconf->wt_core; > >> > >> -- > > > > Not sure why cast is even needed, assigning uint32_t to uint16_t is > > not going to generate a warning with current compiler settings. > > > > I was assuming compiler will complain when assigning uint32_t to uint16_t, but it > seems '-Wconversion' compiler flag is required for this warning. > Enabling this flag for DPDK build causes lots of warnings, I wonder if we should add > a new buildtype in meson that enables this flag. > > > And except from compiler warning, I think it is good to keep explicit cast where > assignment can cause change of value. This at worst can work as documentation > that assignment between different types done intentionally. I would prefer to keep the explicit conversion for consistency. Please let me know if you think otherwise.
On Tue, 16 Jan 2024 12:33:48 +0000 "Tummala, Sivaprasad" <Sivaprasad.Tummala@amd.com> wrote: > > > Not sure why cast is even needed, assigning uint32_t to uint16_t is > > > not going to generate a warning with current compiler settings. > > > > > > > I was assuming compiler will complain when assigning uint32_t to uint16_t, but it > > seems '-Wconversion' compiler flag is required for this warning. > > Enabling this flag for DPDK build causes lots of warnings, I wonder if we should add > > a new buildtype in meson that enables this flag. > > > > > > And except from compiler warning, I think it is good to keep explicit cast where > > assignment can cause change of value. This at worst can work as documentation > > that assignment between different types done intentionally. > > I would prefer to keep the explicit conversion for consistency. > Please let me know if you think otherwise. Keep it, but casts are often a source of bug. They defeat type checking, and often not needed.
diff --git a/examples/qos_sched/args.c b/examples/qos_sched/args.c index e97273152a..22fe76eeb5 100644 --- a/examples/qos_sched/args.c +++ b/examples/qos_sched/args.c @@ -182,10 +182,10 @@ app_parse_flow_conf(const char *conf_str) pconf->rx_port = vals[0]; pconf->tx_port = vals[1]; - pconf->rx_core = (uint8_t)vals[2]; - pconf->wt_core = (uint8_t)vals[3]; + pconf->rx_core = (uint16_t)vals[2]; + pconf->wt_core = (uint16_t)vals[3]; if (ret == 5) - pconf->tx_core = (uint8_t)vals[4]; + pconf->tx_core = (uint16_t)vals[4]; else pconf->tx_core = pconf->wt_core;