bus/ifpga: remove dead code
Checks
Commit Message
This macro was never used.
Fixes: 05fa3d4a6539 ("bus/ifpga: add Intel FPGA bus library")
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
drivers/bus/ifpga/ifpga_logs.h | 4 ----
1 file changed, 4 deletions(-)
Comments
On Mon, Dec 18, 2023 at 04:45:26PM +0100, David Marchand wrote:
> This macro was never used.
>
> Fixes: 05fa3d4a6539 ("bus/ifpga: add Intel FPGA bus library")
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> drivers/bus/ifpga/ifpga_logs.h | 4 ----
> 1 file changed, 4 deletions(-)
>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Hi
> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Monday, December 18, 2023 11:45 PM
> To: dev@dpdk.org
> Cc: Xu, Rosen <rosen.xu@intel.com>; Tianfei Zhang
> <tianfei.zhang@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
> Subject: [PATCH] bus/ifpga: remove dead code
>
> This macro was never used.
>
> Fixes: 05fa3d4a6539 ("bus/ifpga: add Intel FPGA bus library")
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> drivers/bus/ifpga/ifpga_logs.h | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/bus/ifpga/ifpga_logs.h b/drivers/bus/ifpga/ifpga_logs.h
> index 873e0a4f2f..248bccba5d 100644
> --- a/drivers/bus/ifpga/ifpga_logs.h
> +++ b/drivers/bus/ifpga/ifpga_logs.h
> @@ -9,10 +9,6 @@
>
> extern int ifpga_bus_logtype;
>
> -#define IFPGA_LOG(level, fmt, args...) \
> - rte_log(RTE_LOG_ ## level, ifpga_bus_logtype, "%s(): " fmt "\n", \
> - __func__, ##args)
> -
> #define IFPGA_BUS_LOG(level, fmt, args...) \
> rte_log(RTE_LOG_ ## level, ifpga_bus_logtype, "%s(): " fmt "\n", \
> __func__, ##args)
> --
> 2.43.0
Acked-by: Rosen Xu <rosen.xu@intel.com>
On Mon, Dec 18, 2023 at 4:45 PM David Marchand
<david.marchand@redhat.com> wrote:
>
> This macro was never used.
>
> Fixes: 05fa3d4a6539 ("bus/ifpga: add Intel FPGA bus library")
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
Applied, thanks.
@@ -9,10 +9,6 @@
extern int ifpga_bus_logtype;
-#define IFPGA_LOG(level, fmt, args...) \
- rte_log(RTE_LOG_ ## level, ifpga_bus_logtype, "%s(): " fmt "\n", \
- __func__, ##args)
-
#define IFPGA_BUS_LOG(level, fmt, args...) \
rte_log(RTE_LOG_ ## level, ifpga_bus_logtype, "%s(): " fmt "\n", \
__func__, ##args)