Message ID | 1503491044-27863-2-git-send-email-hemant.agrawal@nxp.com (mailing list archive) |
---|---|
State | Changes Requested, archived |
Delegated to: | Pablo de Lara Guarch |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 2AE587D66; Wed, 23 Aug 2017 14:24:29 +0200 (CEST) Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-sn1nam01on0077.outbound.protection.outlook.com [104.47.32.77]) by dpdk.org (Postfix) with ESMTP id 50C037D4F for <dev@dpdk.org>; Wed, 23 Aug 2017 14:24:25 +0200 (CEST) Received: from BN6PR03CA0014.namprd03.prod.outlook.com (2603:10b6:404:23::24) by SN2PR03MB2270.namprd03.prod.outlook.com (2603:10b6:804:d::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1385.9; Wed, 23 Aug 2017 12:24:25 +0000 Received: from BL2FFO11FD011.protection.gbl (2a01:111:f400:7c09::155) by BN6PR03CA0014.outlook.office365.com (2603:10b6:404:23::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1385.8 via Frontend Transport; Wed, 23 Aug 2017 12:24:24 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; NXP1.onmicrosoft.com; dkim=none (message not signed) header.d=none;NXP1.onmicrosoft.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BL2FFO11FD011.mail.protection.outlook.com (10.173.161.17) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1341.15 via Frontend Transport; Wed, 23 Aug 2017 12:24:24 +0000 Received: from bf-netperf1.ap.freescale.net (bf-netperf1.ap.freescale.net [10.232.134.28]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v7NCOJVW032126; Wed, 23 Aug 2017 05:24:22 -0700 From: Hemant Agrawal <hemant.agrawal@nxp.com> To: <dev@dpdk.org> CC: <declan.doherty@intel.com>, <pablo.de.lara.guarch@intel.com>, <akhil.goyal@nxp.com> Date: Wed, 23 Aug 2017 17:54:04 +0530 Message-ID: <1503491044-27863-2-git-send-email-hemant.agrawal@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1503491044-27863-1-git-send-email-hemant.agrawal@nxp.com> References: <1503491044-27863-1-git-send-email-hemant.agrawal@nxp.com> X-EOPAttributedMessage: 0 X-Matching-Connectors: 131479646649599287; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(39860400002)(39380400002)(2980300002)(1109001)(1110001)(339900001)(189002)(199003)(106466001)(53936002)(104016004)(105606002)(33646002)(498600001)(50466002)(2351001)(48376002)(5660300001)(97736004)(356003)(305945005)(50226002)(68736007)(81156014)(8936002)(8676002)(81166006)(110136004)(2906002)(5003940100001)(36756003)(86362001)(76176999)(47776003)(77096006)(85426001)(50986999)(6916009)(2950100002)(6666003)(8656003)(189998001)(54906002)(4326008)(626005); DIR:OUT; SFP:1101; SCL:1; SRVR:SN2PR03MB2270; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11FD011; 1:Aw8zmQ6hNOR74h1NvR3DXIdb+T4k10hWx41qMJa7e7kQOJFJhf88nQD1t8kaXZqX+lg+4yRIpEloMISIj0apDJJ/HFVBBdQh2qTos7fvmYuXYE7Dwl7F1ZmgRh5aYrVG MIME-Version: 1.0 Content-Type: text/plain X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0c1cdac4-6c67-47c3-e3d6-08d4ea21e432 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(300000503095)(300135400095)(2017052603031)(201703131430075)(201703131517081)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:SN2PR03MB2270; X-Microsoft-Exchange-Diagnostics: 1; SN2PR03MB2270; 3:+XLht91xG9/P9QFxdGO78lFsDHd2xNJ5cHN/Sz5ug1ReysUcgVaBZBGyboGArlnv4LXxaXOIriLo7ngB1pz7VxCd+ZFHGyySqOTkPx034ps3DqQAgX6OxKAmg70kaqIplDLynnG99NeYa1UjDNojjNM48M8k/tf/HrKYbyqXyR2vMBzYHbXGflWkE8jMeYNLfFa+tWLoQoK1sPCL9VFyztHi2Ndkf5b/JV9luVDmrwEkU9wNY5Ih2ktHdUBN+ntXiEw8KTBiq5ztye5T5XpYQAXOaQlUEgWz6iMbu3RttgNr10Qdn9X3I6vMNHhnHT61uef59xEX0YxGAMXUPSG0bo8rvjRR+LQzCCEtQxLujpI=; 25:pP/vcEvbOLlH4JKlU1geY8ANbDcNXfDbw3hfwzF4p4FCeUdPqPqE5cXcXrocXvfEHtUPOJdDa9kOAHdQxdiTHlzz3kWGQXwBPGFbHkKAcehpSNQJPAqHXHmk1Qrt7jaQH5Ppn8JIilUhFhUHoiQO0f0dsVETAheXGKMABmaEGDQ8gJjq0SaV6pMhCrdVVXZ5LiiNseHcWIqFthm5ItSpTwwnpL13zmKzR1EFDFw5HORJGDvJlJy6KUhGvFnVKcmfhiH/Gx4jRamRqUL9Y1RZdrVKKvfYu43L/H4Pu0jBqR016FBcgFBm/YoLwMiH/WmryVGRVOKPF6pBEqCRKcavCg== X-MS-TrafficTypeDiagnostic: SN2PR03MB2270: X-Microsoft-Exchange-Diagnostics: 1; SN2PR03MB2270; 31:iY6a3v0DpyBrODlXe3rqJ4CNIzOvj5FFFDh66WbieAJVPKjm7GgFnO8wcy2+JiDTqOkKz5C935+YF3w2BBGJWOHQ9nCJnh/EXMz/4GqCc7x7WE6PzFxACrMm6psx17IGT3heHB5b0sxkSmnXFugS/NwCA6uXdqEm25GcKOsfAj8K6dphqbX7qAbQHVAt321pRuWvSXtoU3jeROqyzPwDMAE8EgsMuDypobWAo4t6JQU=; 4:PfDNcyv2J6+LzC44qyfwSs50+37TqBe4gy6LRUUK+mR4VRVeBsYMTPfa5Ecpnb/XTe6oXnTiC2lvSonzVKpwZsAbJnvW4l5oaq2pXHNDAJ1azyr+esJG4SU8SfjI0Wztt2g/klI85ngA2jf+mxxNKORn6yIaQI/lUJzIHcDlPMDueiKetXL75ICIyRoyfaaxtodRpWJbqdytZbCPGfGwTtb3+g6Zf7wHufhDORxhhb81BhJfgqlgorl0oMUPbea4fT4aH+CIbXjW9j8QPB6uQAWb5zrnLBy35yfNqApSy/Y= X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Microsoft-Antispam-PRVS: <SN2PR03MB2270A9BA4B953B4262A3BBA789850@SN2PR03MB2270.namprd03.prod.outlook.com> X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(601004)(2401047)(13018025)(8121501046)(13016025)(5005006)(93006095)(93001095)(10201501046)(3002001)(100000703101)(100105400095)(6055026)(6096035)(20161123563025)(20161123556025)(20161123565025)(201703131430075)(201703131433075)(201703131441075)(201703131448075)(201703161259150)(20161123561025)(20161123559100)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:SN2PR03MB2270; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:SN2PR03MB2270; X-Forefront-PRVS: 040866B734 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN2PR03MB2270; 23:8krwUX9rCVaGmceZQWfU2SMbYuvtCU0+Fcmxd6KXG?= +C3e4V7HzR7MiI0aQb6AWeCcp1tbPJMjpDIQ3jBE+BrPCJCVj8gAw7O3LsHCKI1jroBVQ/IMTtLk9zwXfegPDc2NA0cQBjSzbF0x+/1m+cIV3f9pOxHa18Sn7DOORzA9WDZaBxsQkcsaNNB6/RCwZbfHvowikbByLFK6gHTAhl6E4WjMhbhADNf8X/kec4xmH16Vg1Cd/4+vXG9huhL0ELWUFy06zIEfS8ufy+jqtovdUVI0zvNJc05lhwy+VDg5nN4BjKYWd3wOdizKdptC3k+ulW3HnIzbr/2996Nzls+BQ4LaJPZWjZx9T6Is+LlQkcJyBgfQbl0gAcE94FZFJkMKLmzwMhKYIXye+hIlwUfJegkW/RcZGEJUs29Jln+vHiBx/0yE54kowEJ3q6D1cq56k9tFNLE+Wnh3CncfSzj/v+pDChwU4Eu0tEGsS7Kl5MHviIamxzxNIYIzgsyYtAcaydXcos5pWPXYFdOv6jHSYKLUpnIYyXdgCO6assLvmZGLdCcrFL/RMZDUtTcEup5YVpUBdF6DClZ8pJCxlWAH+trh1ZE71Nc6pFPlSldfNaxDs0OTh8CAP7OV4JbiD7SDxe1lxG91H5l2q/4xOHDHrgVgxBeMu8NQHTlhJnjYmpp3Th1wokw3B7pTcpST2Y/clDtAKiPOfIRBAgO23COs0gVvNVnjYWB/MgsFLe0qC2SrZzSuXiZjbfbcvo61jrZB94JCpKKzdt7sk7IPaamZz0GNR956CSV9MOAacc6Y/dMem+tI6kXju2nIYaSidRK4VyfisgHIC+7NvWVHvw/NLLHbFaHkIFntjMfs4uBHrGxnnh4tQM1AvD8Ui53cigTxH1KY6rmtZU9+O9X8t6BVnDwamf9uxwqjxvdPC4PFOCemzjumfJJCc8/bWI0zeC1hlS1ssRd+y/mfbsMbH8iREfaLSlcukkROkGksgq2k6DUxqOzVrqThCv7h883FoVzNMz+mOr4cDSUfLBuHFWL/0AO9xIAQ37q84aJ87Hk0mLo5SKcJg1i7uoRx2pjDIPH6t1+/UGpNH7bbAqfQfbXGc0kUT/JNrMm2+aAdiDcJVBacoYy7kiQdlfNvga7cg9r X-Microsoft-Exchange-Diagnostics: 1; SN2PR03MB2270; 6:NWgwLvonTOGIZ4s4vOU58KCZVMR7TrLbsCrlYHYRPok5YFZ9pPSCy6BQm7q5TvX+pM3qmIT4LNL49MjuWQ7RXUrude1pMzmq9BjLZblounaW85ApWk40Emg7286buddA2b2U4x5r/OevnIsF0mBHNPOw1TnDs5lInMvKq6aXE6YCiJZ17ZIHxVXUWbeYT58TN9xlhE6X5jryycScDzQzDtUKFzdwfhld3w27FsTx3Y14wUpXCLR6emMdoD9ZsXkqvOFSO8SPSo2nOLPInhRCGbku9kynsFL7YJUWcRXPQ/qkVO9q7JZYPUtTQSwMvNqFPidbb31TfPmRnLM0lynN8A==; 5:lqV4NcCK0fFw0P3jRh2qE9qix0GJD36YFkodE6hFkho/nGAZTpDf4A2QKTM4xbuO4lEayU0Eo7yeXvT2gBgGRG7pxCYsY4aVn9Ib+AtXRjUVyMr59j7SbIKNWEbtNtiP8j6R2wW7iDQ/qw3QFstEJg==; 24:YL+8xq5ZZVGs0QsyIEdcjWZT+jevaps4xs0QtLfo0ZeE/DGI4RO1Aqd1JGBAD1eI/Y7EZceu0ulbLDtuM+mbqcfAckqKxLBNSaLaAtXUQjA=; 7:UR5fb3GylxxaWY0oA19N19Th06lP8N35flQpYPT8cWZ21ClDhbN2ewK2WeEUd8bESR6KEyuJ64S/LkX+PxBRGGlzi2S9LRtk+aHQsglGk7/eXd9KEQkloANfloIQdGroEEYoXlZEftQ76zZfEAyhcYCUVToYo7aqFdsN+pjOGfIj2Y0PZgIA2Gh8IKlYGFzspy+1/eEmR/Nyp6peTXjAAlalwRMdw+AEzYwUziLXTx0= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Aug 2017 12:24:24.7883 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR03MB2270 Subject: [dpdk-dev] [PATCH] app/crypto-perf: fix uninitialized errno value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Checks
Context | Check | Description |
---|---|---|
ci/Intel-compilation | success | Compilation OK |
ci/checkpatch | success | coding style OK |
Commit Message
Hemant Agrawal
Aug. 23, 2017, 12:24 p.m. UTC
errno should be initialized to 0 before calling strtol
Fixes: f6cefe253cc8 ("app/crypto-perf: add range/list of sizes")
Cc: stable@dpdk.org
Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
app/test-crypto-perf/cperf_options_parsing.c | 1 +
1 file changed, 1 insertion(+)
Comments
> -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Hemant Agrawal > Sent: Wednesday 23 August 2017 13:24 > To: dev@dpdk.org > Cc: Doherty, Declan <declan.doherty@intel.com>; De Lara Guarch, Pablo > <pablo.de.lara.guarch@intel.com>; akhil.goyal@nxp.com > Subject: [dpdk-dev] [PATCH] app/crypto-perf: fix uninitialized errno value > > errno should be initialized to 0 before calling strtol > > Fixes: f6cefe253cc8 ("app/crypto-perf: add range/list of sizes") > Cc: stable@dpdk.org > Reviewed-by: Kirill Rybalchenko <kirill.rybalchenko@intel.com>
> -----Original Message----- > From: Hemant Agrawal [mailto:hemant.agrawal@nxp.com] > Sent: Wednesday, August 23, 2017 1:24 PM > To: dev@dpdk.org > Cc: Doherty, Declan <declan.doherty@intel.com>; De Lara Guarch, Pablo > <pablo.de.lara.guarch@intel.com>; akhil.goyal@nxp.com > Subject: [PATCH] app/crypto-perf: fix uninitialized errno value > > errno should be initialized to 0 before calling strtol > > Fixes: f6cefe253cc8 ("app/crypto-perf: add range/list of sizes") > Cc: stable@dpdk.org > > Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com> > --- > app/test-crypto-perf/cperf_options_parsing.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/app/test-crypto-perf/cperf_options_parsing.c b/app/test-crypto- > perf/cperf_options_parsing.c > index 085aa8f..77c405c 100644 > --- a/app/test-crypto-perf/cperf_options_parsing.c > +++ b/app/test-crypto-perf/cperf_options_parsing.c > @@ -137,6 +137,7 @@ parse_range(const char *arg, uint32_t *min, > uint32_t *max, uint32_t *inc) > if (copy_arg == NULL) > return -1; > > + errno = 0; > token = strtok(copy_arg, ":"); > > /* Parse minimum value */ > -- > 2.7.4 Could you extend this fix to the parse_list function? Thanks! Pablo
On 9/4/2017 8:26 PM, De Lara Guarch, Pablo wrote: > > >> -----Original Message----- >> From: Hemant Agrawal [mailto:hemant.agrawal@nxp.com] >> Sent: Wednesday, August 23, 2017 1:24 PM >> To: dev@dpdk.org >> Cc: Doherty, Declan <declan.doherty@intel.com>; De Lara Guarch, Pablo >> <pablo.de.lara.guarch@intel.com>; akhil.goyal@nxp.com >> Subject: [PATCH] app/crypto-perf: fix uninitialized errno value >> >> errno should be initialized to 0 before calling strtol >> >> Fixes: f6cefe253cc8 ("app/crypto-perf: add range/list of sizes") >> Cc: stable@dpdk.org >> >> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com> >> --- >> app/test-crypto-perf/cperf_options_parsing.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/app/test-crypto-perf/cperf_options_parsing.c b/app/test-crypto- >> perf/cperf_options_parsing.c >> index 085aa8f..77c405c 100644 >> --- a/app/test-crypto-perf/cperf_options_parsing.c >> +++ b/app/test-crypto-perf/cperf_options_parsing.c >> @@ -137,6 +137,7 @@ parse_range(const char *arg, uint32_t *min, >> uint32_t *max, uint32_t *inc) >> if (copy_arg == NULL) >> return -1; >> >> + errno = 0; >> token = strtok(copy_arg, ":"); >> >> /* Parse minimum value */ >> -- >> 2.7.4 > > Could you extend this fix to the parse_list function? > > Thanks! > Pablo > sure.
diff --git a/app/test-crypto-perf/cperf_options_parsing.c b/app/test-crypto-perf/cperf_options_parsing.c index 085aa8f..77c405c 100644 --- a/app/test-crypto-perf/cperf_options_parsing.c +++ b/app/test-crypto-perf/cperf_options_parsing.c @@ -137,6 +137,7 @@ parse_range(const char *arg, uint32_t *min, uint32_t *max, uint32_t *inc) if (copy_arg == NULL) return -1; + errno = 0; token = strtok(copy_arg, ":"); /* Parse minimum value */