[dpdk-dev,v3,20/40] drivers: enable compilation of DPAA Mempool driver
Checks
Commit Message
This patch also adds configuration necessary for compilation of DPAA
Mempool driver into the DPAA specific config file.
CONFIG_RTE_MBUF_DEFAULT_MEMPOOL_OPS=dpaa is also configured to allow
applications to use DPAA mempool as default.
Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
---
config/common_base | 1 +
config/defconfig_arm64-dpaa-linuxapp-gcc | 5 +++++
drivers/mempool/Makefile | 2 ++
3 files changed, 8 insertions(+)
Comments
23/08/2017 16:11, Shreyansh Jain:
> +CONFIG_RTE_LIBRTE_DPAA_MEMPOOL_DEBUG=n
Please could you try to remove this kind of option?
We are going to remove them from DPDK.
For control path, no need of removing logs at compilation time.
For data path, compilation of logs is controlled by CONFIG_RTE_LOG_DP_LEVEL.
For enabling/disabling logs at runtime in the component,
there is the dynamic log types.
On Friday 22 September 2017 03:25 AM, Thomas Monjalon wrote:
> 23/08/2017 16:11, Shreyansh Jain:
>> +CONFIG_RTE_LIBRTE_DPAA_MEMPOOL_DEBUG=n
>
> Please could you try to remove this kind of option?
> We are going to remove them from DPDK.
OK. I will revisit and remove which are not impacting the performance.
>
> For control path, no need of removing logs at compilation time.
> For data path, compilation of logs is controlled by CONFIG_RTE_LOG_DP_LEVEL.
> For enabling/disabling logs at runtime in the component,
> there is the dynamic log types.
>
I had already introduced dynamic log types for DPAA1. There weren't much
examples for me to identify 'best practice'. I preferred this toggling
so that I can be clear about when debugging is truly disabled.
@@ -305,6 +305,7 @@ CONFIG_RTE_LIBRTE_LIO_DEBUG_REGS=n
# NXP DPAA Bus
CONFIG_RTE_LIBRTE_DPAA_BUS=n
+CONFIG_RTE_LIBRTE_DPAA_MEMPOOL=n
#
# Compile NXP DPAA2 FSL-MC Bus
@@ -43,3 +43,8 @@ CONFIG_RTE_LIBRTE_DPAA_BUS=y
CONFIG_RTE_LIBRTE_DPAA_DEBUG_BUS=n
CONFIG_RTE_LIBRTE_DPAA_DEBUG_INIT=n
CONFIG_RTE_LIBRTE_DPAA_DEBUG_DRIVER=n
+
+# NXP DPAA Mempool
+CONFIG_RTE_LIBRTE_DPAA_MEMPOOL=y
+CONFIG_RTE_LIBRTE_DPAA_MEMPOOL_DEBUG=n
+CONFIG_RTE_MBUF_DEFAULT_MEMPOOL_OPS="dpaa"
@@ -32,6 +32,8 @@ include $(RTE_SDK)/mk/rte.vars.mk
core-libs := librte_eal librte_mempool librte_ring
+DIRS-$(CONFIG_RTE_LIBRTE_DPAA_MEMPOOL) += dpaa
+DEPDIRS-dpaa = $(core-libs)
DIRS-$(CONFIG_RTE_LIBRTE_DPAA2_MEMPOOL) += dpaa2
DEPDIRS-dpaa2 = $(core-libs)
DIRS-$(CONFIG_RTE_DRIVER_MEMPOOL_RING) += ring