Message ID | 20170823141213.25476-22-shreyansh.jain@nxp.com (mailing list archive) |
---|---|
State | Superseded, archived |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id A2A5E997D; Wed, 23 Aug 2017 16:03:13 +0200 (CEST) Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0057.outbound.protection.outlook.com [104.47.34.57]) by dpdk.org (Postfix) with ESMTP id 5E9799953 for <dev@dpdk.org>; Wed, 23 Aug 2017 16:03:11 +0200 (CEST) Received: from CY4PR03CA0005.namprd03.prod.outlook.com (10.168.162.15) by DM5PR03MB3322.namprd03.prod.outlook.com (10.174.241.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1362.18; Wed, 23 Aug 2017 14:03:09 +0000 Received: from BL2FFO11FD029.protection.gbl (2a01:111:f400:7c09::186) by CY4PR03CA0005.outlook.office365.com (2603:10b6:903:33::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1362.18 via Frontend Transport; Wed, 23 Aug 2017 14:03:09 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BL2FFO11FD029.mail.protection.outlook.com (10.173.160.69) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1341.15 via Frontend Transport; Wed, 23 Aug 2017 14:03:09 +0000 Received: from Tophie.ap.freescale.net ([10.232.14.39]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v7NE2Q37004389; Wed, 23 Aug 2017 07:03:06 -0700 From: Shreyansh Jain <shreyansh.jain@nxp.com> To: <dev@dpdk.org> CC: <ferruh.yigit@intel.com>, <hemant.agrawal@nxp.com> Date: Wed, 23 Aug 2017 19:41:54 +0530 Message-ID: <20170823141213.25476-22-shreyansh.jain@nxp.com> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170823141213.25476-1-shreyansh.jain@nxp.com> References: <1499179471-19145-1-git-send-email-shreyansh.jain@nxp.com> <20170823141213.25476-1-shreyansh.jain@nxp.com> X-EOPAttributedMessage: 0 X-Matching-Connectors: 131479705894474723; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(39380400002)(39860400002)(2980300002)(1109001)(1110001)(339900001)(199003)(189002)(356003)(5660300001)(8676002)(50986999)(54906002)(76176999)(8656003)(104016004)(36756003)(48376002)(50466002)(53936002)(305945005)(2950100002)(189998001)(6666003)(77096006)(6916009)(81156014)(50226002)(68736007)(498600001)(106466001)(2906002)(33646002)(85426001)(105606002)(47776003)(1076002)(2351001)(81166006)(86362001)(626005)(8936002)(97736004)(4326008)(5003940100001)(110136004); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR03MB3322; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11FD029; 1:sscVKU9TjqdXvuWwsl+3bkGVTcWvEX/0Id2YQeYPcrGnKASYQ8iuURIJwEIftLexVgDdMipJKPHcDG2tJbh+arnt26pY2yiG4cJ3Q3x5WsZCIxcckUVQBUyvKwDen7id MIME-Version: 1.0 Content-Type: text/plain X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 67a224b2-ed05-4aea-f282-08d4ea2faf77 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(300000503095)(300135400095)(2017052603031)(201703131430075)(201703131517081)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:DM5PR03MB3322; X-Microsoft-Exchange-Diagnostics: 1; DM5PR03MB3322; 3:kRqKxAJeodmwwdEkHbTH7WuhVWGGEHuA5EoVrEsPoqdWSAf6ujjkzDh3AApvC/UOMFbLWuFtyJRvWQQfXlW55LpJXWSBqPSVz6gcZM+Zqf4WeXgGxq7aJQ43LXEIUL5mTm5g9aThUl/uTKg5lc/miIlWew3B58oed7AavEgf1cr4ymhBFByLc2Npze6tS7HeilXl+w5yruSvlgbrTV2O3BlwA3BJkYkWS/37Ud/nHssYJIkaY/YvZch/wZdqJOAZftEjeOOeqSGlpIwhtIehgYuaCaVwNYAtqQ0usw0LT14UHdpZZUh0bCFWNtuSYj/WZuGmqShCFQN3cYqiwvQ/ycMODyGFjZ497ZPys9gn/MU=; 25:gyo2tO7snGQdaVVQUqSYtVqEdWRxMRjaomySRq4/eCQbwJZIxY3V8QByPf+PrJauEL2AG9+LaFXJvenDFG8mmgPIpFzW6p0TAof2DCIxFvrFq0dgPzOWumn0TVULFSV1NpgXcqae1dO2EH4nHxxyxLgGPy3+jals+A5G9fRZbYSA6XTd+7CK7+22ZwMO3DXQjCDfR3WTQ6CLWi1SCIoz0Nm93TaGFx2Qeq+PINbT2wjAFWaqFV7+gRQiFtyWWPep5+qbS95zD6GEdJ4XLJJiiDFahfYZk/nsiMY+kVA9kD2PI7V8P0ytvaAXi4V7mbFRdVQFtM5RU3w2w3fZGevcyQ== X-MS-TrafficTypeDiagnostic: DM5PR03MB3322: X-Microsoft-Exchange-Diagnostics: 1; DM5PR03MB3322; 31:RyI0TUQ0PN3L0XasG5l1/XiThrVmUPOs0OTUQreFxbPjJi+HOrEQe1REZU6UGL8QAkHyv/r8N0zkea6mEzRKa3ht03IHyyuprVxtxfOid92wp8SDiHAJCi3+pTLPgJo7xNaOEp66zHNfc0YQ2XLVIZ8WIy53AoZyDG/XcqtxsPCnhX4vxAfMWxge3Emx2s1fh8k3UgLrd0MMhvQF5Bp4gZCnphJKWpiJuQJ6afjF04U=; 4:9Ashxv8gWCyCE+cBZpJJ4acpXPqz2Fb5qHgWqNnHP+sWmQwwzKHwYRv86DyDyJZ0GnDa5OfuNp2k392DAibouXJymApL6zw5wutqqHd8eZQc69LHMybPgqiTkE0emHXD80/AOImI/N296M+dNRXrxNelxwWYqLiqgqPIs9p6XC040JmEURpzvelCyGkPc/EPF3a9FjydQuu/T+pBwUFb7Bk9BT55JIi1ue5A0ISMlzLGhgFWVuC7/6pJ5RUQANBOlu3kBJ28qfX3Ztv1SyZRuXVrKN7BuCt2ig1pDC65kTq3USa8KBfFovrWdwsdbBisu+dxdu00T7ucBd1q8yyooA== X-Exchange-Antispam-Report-Test: UriScan:(60795455431006)(185117386973197); X-Microsoft-Antispam-PRVS: <DM5PR03MB3322DD39576A6435EDCF53F590850@DM5PR03MB3322.namprd03.prod.outlook.com> X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(601004)(2401047)(13018025)(8121501046)(5005006)(13016025)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(3002001)(6055026)(6096035)(20161123561025)(20161123559100)(20161123563025)(20161123556025)(20161123565025)(201703131430075)(201703131433075)(201703131441075)(201703131448075)(201703161259150)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:DM5PR03MB3322; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DM5PR03MB3322; X-Forefront-PRVS: 040866B734 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM5PR03MB3322; 23:JZgtNnTUD1uDk8hUFeeG5oVVLeyd5qSwuabjrjCff?= YUXzMFQz58hzFTNikEP1ZiljQqdsKVpNq3u50RHixwxh31AY4WTJByUqvkVTHLvjC4fAphY6tT1+uWIaTqRBkJAHD5ys7zPjusc0e/WQa/JACGFeou90FvNsHgEnI8YjboIW2dInRj05+EUD0ns56U7PxciLmSltI/rYoAd71XUKq7VZ2o/CBrz92OVpW7NxWZLPOnc6jG5P/UNdvnrApM22jUKqbgQ8Piaw+kJ1Uh1ygdg4Nt+oZ43RFvwkpsGQolwEFLHtyBxMZw7X2epWoAZrWpoGCTnfQMM+wz/tWVLmt5sj+rgkyXEwq3b1riDh31PtR6uJuDdlmj0jP5lcH95lF2zjApswPp9H1eOVUrxuKJ7EFuwbwxS4u2XC4qotFy9787wRoAuw/W7ad/+uRcrwlHKrPdLNDCHwLljKkwShhlfJ7iPbCeSAMpH7E8/hT2wXLceTbBCNqugCBZA/iWG+IXFCf3j0UpPTwbo1Z+uzvwx0WgrUbSSlvWi0AISX3fkfFEfrhApV0qhr0/joWX3ZvnvIuurj+ir4YUGt5LoqDCnIjPza+Sv8yZbXhhNjvdlpg5wrOF38vapqyG3tiRGCzgLYwUQihHt4v4lcvYt45MWb89/txWGecFYAobLMKNoQWcRlj0Mqk2f63bCE9pMtKXMYqIXZxx73PifyZrJPjLDXQ16X6+QoY7vDYhQf5MebLlOs//3lsz5YmBB13mObzKsGv0ZOz6BumqsOsJWBOeJRAPSkvINqIx9a9ZWUHAIjwMDLoPfE4WJkT8yJfdnx84oe4oBLnOEwgaehCAhdTd6u9lTnxCHeTbNtTQcQXv0wcKuMuYINfnK2bX12evl7oDMsHZUeepg3rcy3/cjpGe6O5g70TdQZ3r2mAWPfmLZmZRaDhWsx3Kf5srJFclx1kdlVU8MK5IJkl2A95Eir2RXuay994jLY3dS+4561EuYQ2Ygdl74WgJOxG/Rq9JzDUR67y/5Eid5g96E/dNJ8jnv05XiPBzsqNx8x3OZ6nr4jrwJ/QgsZsbHaPk8RvSmZBWlskvvMzwx/rCleiJRXteUvBu1cHBF85qeS+d1TqBu1RDzmH2wtNMSh3U8GBoo X-Microsoft-Exchange-Diagnostics: 1; DM5PR03MB3322; 6:wcD0rEcsGw11dLSX30fO7plq8KZ067pLtMfRgCojS/7Ujk9TlNUkZ+8yHKcGUnY8Nowvmqo02+g5bisw9KvTRPBFsZ0TebIebYaIif0jNrv6b04y6ilO5TXM8APKE+U2mPlXcwxQvio0M0mKDFKEzGMLeNSLEkmTje2ObUqBxfJS5eR5bjbaX8MJKjvuminkUcR8Aw5d4uU9HNZT2d4JboqrgHc9PdupBu2xW/XTsCkX0Om60L0RJu5zJuQIHQ2DbB1fHLt4LCiwqAjvRBhSVmUsQ1Tzf4Er7Lu+C64woe1CPRhjhAr8H1cPUj5uyBfzza9QkcO+fB8Co6DBMn6CWw==; 5:gsy8kYcrjQ60ubGTAnt6latZqVyEom/ortXq6tDomTzglFWr0Le9uGMKbgXDSCuwI4EJRUwook7MtBpxfjJc/hOfJa7Fw97W0fuJzBZohJKuaMR5iqQf/H1f6tPI68lH7EUC0gZOumg/bWMtQIcTBw==; 24:FHFzL9D47rrUgRk6tqPqpX/D1QjoqT7BIJeG6WcByEWeHcRVXdq5H0Tx9v1VPUJ4ReojnLPBIjgu0CQEZkBXPhMrmXpdCjDJkUcG7rvNAdc=; 7:SXZ4RGYHJvnqsxq8oOPkQc2yWuCYg4gbkVfz+dNJnlqaa025G77ryOeHLZnqoWiRpevKAieUPOGApIFieqLkO3uXNAUoYvUALOqjLYx3SC9uZrONCKBv0L8i2OM0XWB6nC4yJtfI7YbsHegsbF8X2ybB8Stev5Szt9nMZ7+EhhqYI8rjmnIKJvXDC10aAjMoN1NIDff65GjhB47CYZoaV7ZDdSqlxBS8lb1TUaKKubg= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Aug 2017 14:03:09.1354 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB3322 Subject: [dpdk-dev] [PATCH v3 21/40] maintainers: claim ownership of DPAA Mempool driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Checks
Context | Check | Description |
---|---|---|
ci/Intel-compilation | success | Compilation OK |
ci/checkpatch | success | coding style OK |
Commit Message
Shreyansh Jain
Aug. 23, 2017, 2:11 p.m. UTC
Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
Comments
23/08/2017 16:11, Shreyansh Jain: > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -409,6 +409,7 @@ NXP dpaa > M: Hemant Agrawal <hemant.agrawal@nxp.com> > M: Shreyansh Jain <shreyansh.jain@nxp.com> > F: drivers/bus/dpaa/ > +F: drivers/mempool/dpaa/ > F: doc/guides/nics/dpaa.rst > F: doc/guides/nics/features/dpaa.ini This kind of patch can be squashed in the first patch introducing this new directory.
On Friday 22 September 2017 03:26 AM, Thomas Monjalon wrote: > 23/08/2017 16:11, Shreyansh Jain: >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -409,6 +409,7 @@ NXP dpaa >> M: Hemant Agrawal <hemant.agrawal@nxp.com> >> M: Shreyansh Jain <shreyansh.jain@nxp.com> >> F: drivers/bus/dpaa/ >> +F: drivers/mempool/dpaa/ >> F: doc/guides/nics/dpaa.rst >> F: doc/guides/nics/features/dpaa.ini > > This kind of patch can be squashed in the first patch introducing > this new directory. > Then the patch script (devtools/check-git-log.sh) reports error - I think. That is the primary reason I split them across multiple patches. You sure that doesn't matter?
22/09/2017 08:47, Shreyansh Jain: > On Friday 22 September 2017 03:26 AM, Thomas Monjalon wrote: > > 23/08/2017 16:11, Shreyansh Jain: > >> --- a/MAINTAINERS > >> +++ b/MAINTAINERS > >> @@ -409,6 +409,7 @@ NXP dpaa > >> M: Hemant Agrawal <hemant.agrawal@nxp.com> > >> M: Shreyansh Jain <shreyansh.jain@nxp.com> > >> F: drivers/bus/dpaa/ > >> +F: drivers/mempool/dpaa/ > >> F: doc/guides/nics/dpaa.rst > >> F: doc/guides/nics/features/dpaa.ini > > > > This kind of patch can be squashed in the first patch introducing > > this new directory. > > > > Then the patch script (devtools/check-git-log.sh) reports error - I > think. That is the primary reason I split them across multiple patches. > You sure that doesn't matter? Which error? To be clear I suggest to squash with patch 19 where drivers/mempool/dpaa/Makefile is introduced.
22/09/2017 09:37, Shreyansh Jain: > On Friday 22 September 2017 12:23 PM, Thomas Monjalon wrote: > > 22/09/2017 08:47, Shreyansh Jain: > >> On Friday 22 September 2017 03:26 AM, Thomas Monjalon wrote: > >>> 23/08/2017 16:11, Shreyansh Jain: > >>>> --- a/MAINTAINERS > >>>> +++ b/MAINTAINERS > >>>> @@ -409,6 +409,7 @@ NXP dpaa > >>>> M: Hemant Agrawal <hemant.agrawal@nxp.com> > >>>> M: Shreyansh Jain <shreyansh.jain@nxp.com> > >>>> F: drivers/bus/dpaa/ > >>>> +F: drivers/mempool/dpaa/ > >>>> F: doc/guides/nics/dpaa.rst > >>>> F: doc/guides/nics/features/dpaa.ini > >>> > >>> This kind of patch can be squashed in the first patch introducing > >>> this new directory. > >> > >> Then the patch script (devtools/check-git-log.sh) reports error - I > >> think. That is the primary reason I split them across multiple patches. > >> You sure that doesn't matter? > > > > Which error? > > > > To be clear I suggest to squash with patch 19 where > > drivers/mempool/dpaa/Makefile is introduced. > > Yes, I understand that. > It would report error that the headline is wrong because I am hitting > different directories - "MAINTAINERS" and "drivers/mempool/*" with the > same patch having headline "mempool/*". The test you are talking about has this comment: # check headline prefix when touching only drivers, e.g. net/<driver name> If you hit a warning, there is a bug.
On Friday 22 September 2017 12:23 PM, Thomas Monjalon wrote: > 22/09/2017 08:47, Shreyansh Jain: >> On Friday 22 September 2017 03:26 AM, Thomas Monjalon wrote: >>> 23/08/2017 16:11, Shreyansh Jain: >>>> --- a/MAINTAINERS >>>> +++ b/MAINTAINERS >>>> @@ -409,6 +409,7 @@ NXP dpaa >>>> M: Hemant Agrawal <hemant.agrawal@nxp.com> >>>> M: Shreyansh Jain <shreyansh.jain@nxp.com> >>>> F: drivers/bus/dpaa/ >>>> +F: drivers/mempool/dpaa/ >>>> F: doc/guides/nics/dpaa.rst >>>> F: doc/guides/nics/features/dpaa.ini >>> >>> This kind of patch can be squashed in the first patch introducing >>> this new directory. >>> >> >> Then the patch script (devtools/check-git-log.sh) reports error - I >> think. That is the primary reason I split them across multiple patches. >> You sure that doesn't matter? > > Which error? > > To be clear I suggest to squash with patch 19 where > drivers/mempool/dpaa/Makefile is introduced. > Yes, I understand that. It would report error that the headline is wrong because I am hitting different directories - "MAINTAINERS" and "drivers/mempool/*" with the same patch having headline "mempool/*".
On Friday 22 September 2017 01:05 PM, Thomas Monjalon wrote: > 22/09/2017 09:37, Shreyansh Jain: >> On Friday 22 September 2017 12:23 PM, Thomas Monjalon wrote: >>> 22/09/2017 08:47, Shreyansh Jain: >>>> On Friday 22 September 2017 03:26 AM, Thomas Monjalon wrote: >>>>> 23/08/2017 16:11, Shreyansh Jain: >>>>>> --- a/MAINTAINERS >>>>>> +++ b/MAINTAINERS >>>>>> @@ -409,6 +409,7 @@ NXP dpaa >>>>>> M: Hemant Agrawal <hemant.agrawal@nxp.com> >>>>>> M: Shreyansh Jain <shreyansh.jain@nxp.com> >>>>>> F: drivers/bus/dpaa/ >>>>>> +F: drivers/mempool/dpaa/ >>>>>> F: doc/guides/nics/dpaa.rst >>>>>> F: doc/guides/nics/features/dpaa.ini >>>>> >>>>> This kind of patch can be squashed in the first patch introducing >>>>> this new directory. >>>> >>>> Then the patch script (devtools/check-git-log.sh) reports error - I >>>> think. That is the primary reason I split them across multiple patches. >>>> You sure that doesn't matter? >>> >>> Which error? >>> >>> To be clear I suggest to squash with patch 19 where >>> drivers/mempool/dpaa/Makefile is introduced. >> >> Yes, I understand that. >> It would report error that the headline is wrong because I am hitting >> different directories - "MAINTAINERS" and "drivers/mempool/*" with the >> same patch having headline "mempool/*". > > The test you are talking about has this comment: > # check headline prefix when touching only drivers, e.g. net/<driver name> > If you hit a warning, there is a bug. Somehow I had the impression it throws an error in such cases. I changed as suggested and check-git-log.sh script didn't throw any error - I was wrong. Thanks for correcting. - Shreyansh
diff --git a/MAINTAINERS b/MAINTAINERS index 10646a4..74b7aba 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -409,6 +409,7 @@ NXP dpaa M: Hemant Agrawal <hemant.agrawal@nxp.com> M: Shreyansh Jain <shreyansh.jain@nxp.com> F: drivers/bus/dpaa/ +F: drivers/mempool/dpaa/ F: doc/guides/nics/dpaa.rst F: doc/guides/nics/features/dpaa.ini