[dpdk-dev] ethdev: increase length device internal name
Checks
Commit Message
Allow sufficicent space for UUID in string form (36+1).
Needed to use UUID with Hyper-V. This was in deprecation notice
for previous release and make it so in 17.11.
Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
---
doc/guides/rel_notes/deprecation.rst | 3 +++
lib/librte_eal/common/include/rte_dev.h | 6 +++++-
2 files changed, 8 insertions(+), 1 deletion(-)
Comments
On 9/27/2017 10:23 AM, Stephen Hemminger wrote:
> Allow sufficicent space for UUID in string form (36+1).
> Needed to use UUID with Hyper-V. This was in deprecation notice
> for previous release and make it so in 17.11.
>
> Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
Except from below note,
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> doc/guides/rel_notes/deprecation.rst | 3 +++
> lib/librte_eal/common/include/rte_dev.h | 6 +++++-
> 2 files changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 3362f33501dd..ba5b68e70098 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -120,3 +120,6 @@ Deprecation Notices
> The non-"do-sig" versions of the hash tables will be removed
> (including the ``signature_offset`` parameter)
> and the "do-sig" versions renamed accordingly.
> +
> +* ethdev: in 17.11 the size of internal device name is increased
> + to 64 characters to allow for storing longer bus specific name.
There is already a deprecation notice added in previous release for this
release. Since this patch implements it, notice should be removed,
instead of adding new one.
> diff --git a/lib/librte_eal/common/include/rte_dev.h b/lib/librte_eal/common/include/rte_dev.h
> index 5386d3a28be5..4c4ac7e5d375 100644
> --- a/lib/librte_eal/common/include/rte_dev.h
> +++ b/lib/librte_eal/common/include/rte_dev.h
> @@ -152,7 +152,11 @@ struct rte_driver {
> const char *alias; /**< Driver alias. */
> };
>
> -#define RTE_DEV_NAME_MAX_LEN (32)
> +/*
> + * Internal identifier length
> + * Sufficiently large to allow for UUID or PCI address
> + */
> +#define RTE_DEV_NAME_MAX_LEN 64
>
> /**
> * A structure describing a generic device.
>
On 10/10/2017 12:12 AM, Ferruh Yigit wrote:
> On 9/27/2017 10:23 AM, Stephen Hemminger wrote:
>> Allow sufficicent space for UUID in string form (36+1).
>> Needed to use UUID with Hyper-V. This was in deprecation notice
>> for previous release and make it so in 17.11.
>>
>> Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied to dpdk-next-net/master, thanks.
(deprecation notice fixed while applying)
@@ -120,3 +120,6 @@ Deprecation Notices
The non-"do-sig" versions of the hash tables will be removed
(including the ``signature_offset`` parameter)
and the "do-sig" versions renamed accordingly.
+
+* ethdev: in 17.11 the size of internal device name is increased
+ to 64 characters to allow for storing longer bus specific name.
@@ -152,7 +152,11 @@ struct rte_driver {
const char *alias; /**< Driver alias. */
};
-#define RTE_DEV_NAME_MAX_LEN (32)
+/*
+ * Internal identifier length
+ * Sufficiently large to allow for UUID or PCI address
+ */
+#define RTE_DEV_NAME_MAX_LEN 64
/**
* A structure describing a generic device.