[dpdk-dev,v2] test/mempool: improve default mempool ops selection
Checks
Commit Message
Use of rte_eal_mbuf_default_mempool_ops() API will
allow to override pool handler through "--mbuf-pool-ops-name"
eal command line argument.
Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Acked-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
---
v2:
- Added a local variable to store the rte_eal_mbuf_default_mempool_ops()
to use across the file(Olivier)
---
test/test/test_mempool.c | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)
Comments
On Tue, Jan 09, 2018 at 09:27:08PM +0530, Jerin Jacob wrote:
> Use of rte_eal_mbuf_default_mempool_ops() API will
> allow to override pool handler through "--mbuf-pool-ops-name"
> eal command line argument.
>
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> Acked-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
Acked-by: Olivier Matz <olivier.matz@6wind.com>
16/01/2018 15:25, Olivier Matz:
> On Tue, Jan 09, 2018 at 09:27:08PM +0530, Jerin Jacob wrote:
> > Use of rte_eal_mbuf_default_mempool_ops() API will
> > allow to override pool handler through "--mbuf-pool-ops-name"
> > eal command line argument.
> >
> > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > Acked-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
>
> Acked-by: Olivier Matz <olivier.matz@6wind.com>
Applied, thanks
@@ -485,6 +485,7 @@ test_mempool(void)
struct rte_mempool *mp_nocache = NULL;
struct rte_mempool *mp_stack = NULL;
struct rte_mempool *default_pool = NULL;
+ const char *default_pool_ops = rte_eal_mbuf_default_mempool_ops();
rte_atomic32_init(&synchro);
@@ -535,8 +536,7 @@ test_mempool(void)
rte_mempool_obj_iter(mp_stack, my_obj_init, NULL);
/* Create a mempool based on Default handler */
- printf("Testing %s mempool handler\n",
- RTE_MBUF_DEFAULT_MEMPOOL_OPS);
+ printf("Testing %s mempool handler\n", default_pool_ops);
default_pool = rte_mempool_create_empty("default_pool",
MEMPOOL_SIZE,
MEMPOOL_ELT_SIZE,
@@ -548,14 +548,12 @@ test_mempool(void)
goto err;
}
if (rte_mempool_set_ops_byname(default_pool,
- RTE_MBUF_DEFAULT_MEMPOOL_OPS, NULL) < 0) {
- printf("cannot set %s handler\n",
- RTE_MBUF_DEFAULT_MEMPOOL_OPS);
+ default_pool_ops, NULL) < 0) {
+ printf("cannot set %s handler\n", default_pool_ops);
goto err;
}
if (rte_mempool_populate_default(default_pool) < 0) {
- printf("cannot populate %s mempool\n",
- RTE_MBUF_DEFAULT_MEMPOOL_OPS);
+ printf("cannot populate %s mempool\n", default_pool_ops);
goto err;
}
rte_mempool_obj_iter(default_pool, my_obj_init, NULL);