Message ID | 20180210115736.7107-1-jerin.jacob@caviumnetworks.com (mailing list archive) |
---|---|
State | Accepted, archived |
Delegated to: | Thomas Monjalon |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4ABA01B6E3; Sat, 10 Feb 2018 12:58:12 +0100 (CET) Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-sn1nam01on0079.outbound.protection.outlook.com [104.47.32.79]) by dpdk.org (Postfix) with ESMTP id 83F801B6D2 for <dev@dpdk.org>; Sat, 10 Feb 2018 12:58:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=p3KtrwJaH03CIPJW3OnCKzt2RtxLkh5h4PQ9yPEr7YU=; b=apzhdXRxJzTaUpA2obXOQnOTIOYt8o5SeDi9rHfKbrWa1Ct9rJHirtBa/H7MlwW4YwwaGWtwz7Gg/I0M6IlBSQEht3BEqamh4R7OkO3F/Op3A4t7Ez1wvRwZzhnNbT/P8Y4LvPX5ipdwxN1ikdlk++9NlvELKWQn5cE/KY46aGA= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin.domain.name (122.178.236.101) by CO2PR07MB2520.namprd07.prod.outlook.com (10.166.201.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.485.10; Sat, 10 Feb 2018 11:58:07 +0000 From: Jerin Jacob <jerin.jacob@caviumnetworks.com> To: dev@dpdk.org Cc: Jerin Jacob <jerin.jacob@caviumnetworks.com>, hemant.agrawal@nxp.com Date: Sat, 10 Feb 2018 17:27:36 +0530 Message-Id: <20180210115736.7107-1-jerin.jacob@caviumnetworks.com> X-Mailer: git-send-email 2.16.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [122.178.236.101] X-ClientProxiedBy: MA1PR0101CA0069.INDPRD01.PROD.OUTLOOK.COM (52.134.136.31) To CO2PR07MB2520.namprd07.prod.outlook.com (10.166.201.7) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b0211245-d2b6-4115-a3b4-08d5707d8d47 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:CO2PR07MB2520; X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2520; 3:RgmIDcwPdzg9AJc5uYtr9vH+9qZHLM3OXd+GFxBtdKE3CIKv6e2zRxtH9mWOcwDZgWwBLnyQZZkr+WMD2ixMdNZhda0+gzF7ifto8dFbLZH/7cyqhWFvy2/w7C3VYr38IRWrlIijkhWgDAR0afrU0ngj11shR26Q8pF66gf/mu59j5RqAE6IaEZcsIMUBdUG5CL/sBvqaNObXFDStLDkjw4lkL23mvWK40VVtYGgeQja3K8ZSTyX/4WBWu0mft5K; 25:J6IO8j+SIeLhRnUUXav70rF6Se9bWNv3EH585Q/jnISV65Tylm1IcPFtgvOWUVl7JbgFhfIdRAvr+Vk1sEFOjz3fiKeZVK42tKjKTrK+0kQ1fI7Coqlmqm1bGUuCqdaQ9Ip9YBW/iuN6NYmSrAeRqOWpmFfekYrhScC9phXETlvcDb/jyaL9/2D70Ps1HtXzHWZpW7r+gLqrCrnVePR+GDwxA2WfITSGLUkV8ffxR/w9rSa/92LcYhPqwnQINFiO0FoVoDGLQpWCuNR3Xq/HFnvYi/4Gf5k0XU1kBB+5lmYWGD9iYhoXfYemHT91rMyymNUpw3sMWeghUSb6Pz+2UA==; 31:QV3twZBrxT1pQo3UVLwUkj2/lsT81l+diYvBb/wMi9Y7xhSZzahO7dX5voyUi/wJeyI+/4x0dgquERyCJ6Wi+dTZASLKZdavGxOzeeMbXj5BMeM+WCRvSLIc/Rod2DHrrvkbmUx9WcGfIiWIPvO9VWEyiJTeZdywijb0Qn+cgaX3WOsSx5+W0rEmnXtBoGVNBPl4/n30y68mbzlWMu39A6bvhZbZUB/cPumQLqVvEyQ= X-MS-TrafficTypeDiagnostic: CO2PR07MB2520: X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2520; 20:GwyN41JL2nW1NjLBn8iH+ZHJSzJ+7tai8Ie2WJBty7LvuAeniNcRhXtijDnmWXjt21YApXyz6StuObeLg1wG/iMaQgO8JvlBlJxmLWuOIYP4pM5t9HyvyLLTv8qWhuo+VaZC7AUtyOTcHTYW9uBmZhUNB/xCeT1SeTJwi+qdy7ypdqIdQhGSXMOoRP5ngUmWTqAOoiSHnzPHOLmquFWB++Dn3btFnoOMG+hoJZCZy/S5v2QEfFJhzkCb1NKvelx5WKJNOibsIlTd4m+iftL5+jQt6FGw0lKYC1SOTh5oQy/aVuI3rDKPNF7xn7CL660mHtGy629WVdc6/5UyL6B+0MjvL1xqZLsT+9BiyCOEYxjv8ac4j4ln2f5lOgIUqRLIYdW06z1I/XZAF+KKGtYM5YaySNAcb+6ZXFIkDtWHGbz3Ut58k3YknE/CZM9pXGEjwOMYBzHWzCTACCimeM3zXzkNorCjY8mgNfJjumWrqI6EMTevE0yNHAmm3i77RLpXRd9GNSn93HW8ajFDIAH33hZ3PLB+ZClMWac0hG0G4ddGARxI4VNGFrrIiu4esl2E1ZeX43Rm1XVEyebjwg4jJ28vPFAl6vNyWIrIJ0NbXm0=; 4:OshlKL8K+eGFhIOUWim7tn8bjy7UMmggs5K9SDTEvAMQLSXBAcwu6kzG5XVKLsztIXoaQF0bJpFOaaVgWDlO7cq2Ot9FubigXNwpAJ5N333wWqmUDrWBq0G4uVQKW5KbEqTnYCpeYtOUO6SXeNsOIUYYkyc83TumG4QLs6BSdtvJMj+HOLK8E/62YzrfUw0DGMBCyKYe3aArnyW93/hyK/Xk0rYpbnWlCKoFfdEqmxQN0Rd8MeEkdbRewhFE9HtTKkU52z4VlJU2kkLTVUtHxVXazlNAKvFO6DkSaZ77rISG+AMr30IQAAEOuodhyrEl X-Microsoft-Antispam-PRVS: <CO2PR07MB2520B829247FD5B62BC866A8E3F10@CO2PR07MB2520.namprd07.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(5005006)(8121501046)(10201501046)(3231101)(2400082)(944501161)(93006095)(3002001)(6041288)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123560045)(20161123564045)(20161123558120)(6072148)(201708071742011); SRVR:CO2PR07MB2520; BCL:0; PCL:0; RULEID:; SRVR:CO2PR07MB2520; X-Forefront-PRVS: 057906460E X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(346002)(396003)(39380400002)(39860400002)(376002)(366004)(189003)(199004)(106356001)(53416004)(2361001)(478600001)(72206003)(2351001)(36756003)(105586002)(66066001)(316002)(16526019)(48376002)(16586007)(51416003)(53936002)(52116002)(386003)(186003)(6486002)(6506007)(6512007)(59450400001)(1857600001)(50466002)(6116002)(3846002)(1076002)(26005)(69596002)(97736004)(6666003)(2906002)(68736007)(81166006)(5660300001)(81156014)(47776003)(6916009)(42882006)(4326008)(7736002)(25786009)(8676002)(50226002)(8656006)(305945005)(8936002); DIR:OUT; SFP:1101; SCL:1; SRVR:CO2PR07MB2520; H:jerin.domain.name; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CO2PR07MB2520; 23:H1IXPRHjO0BrMml6jbxKG0K6i6UpPPlXZGMLPAO1G?= SotZBK6FCAxvlPwVq/Cf6chtJSMUJm5XLdI14LZKYmVwO5nqYGwOqgUbrKduCjWMzP8P5v4m92dP7Dpr+GPn/ElnUk4pW8b26SCGxDqsQwPniDCrVMIQv0XjF3wHFNIZh6TXDxtae/ydrebNhYdvETCcTIJgdIWncNIGMfumcYCI4oT0/agvP2WgBEmJmUjrNEPpGsug/VydRoN8UCcHGY00Ps+YGiExqMczSCjwJe56fKhzk09T6fPhnzHaaC0ZXi5Gb1lO5alPkNAHOd9ZoZlxUiOptRXGLGcihAQ5Jl5k0CrP0GCVcco5CVGaEwGk1OOxupmSJO1fdUJ6odH4wmemIsb0/KfL8+mQZ5cUAyUHWd2FWpNocGsZCAj5GrBGv+4WrdKWHrHPnbkrpPnYo0g2LTy9ZxvEK2WCwqpIT8LSKFj9bsVo0IGB6IDkLMUNfqCHshp7KbbGjA98arly021f1u6XFc/ONGw+HHsjCRknvisdRsgnnvXw5+HvOknvaLeixQKc3gMgIjsBn42bMCa2fq6VWU6qXmPMg+ueB8uSHwp9wuhOrd+du9iLwz735W+nmsh8Ag6eaDQ/ir95iNvXJkARYdcTaDiHCNHh3Cc/jBdD0brwOaQHYM5Ob6argT+f+KrgnHdGdghMm1Qi4/ddU8+ALQ+epeCauc9+QaJo54Rx6Zmgj2XXvOpdFMlZ/0pq4iJnyfMr/DiCyBnXzQerya0cO1xRVxZCQsr3fIJV/BPoERzItuMUVlTgAb33QxFxoQZx49UO/0xJtzuzlj/J95Xn0idsFKFCCqgW4Fou2Gw1b7NSnOugGv181ZBrGOziyyND733u7i+85nAIct8OzcJUyQLdjrdHeZ9TgoLwYh8AzHRrxxjygHCuchmZ8mUbSbQOzBAfguA3vveDgdqjqMlalL573wcPc1wsvdo7cHG4fJviydgNfnU41fODVA0QuAdRPf4sPvda2P72ShvxGRvMgNtnwnBXQ0EUlzOZU4eHdRFMthNF54yNE5wo/yBdTi5YpZYJt5RGhxCmVqbE3eaflwJZwmXEH5dkLZYxXErgah3qQ1jUUuoyyA8qibNaXVM4OgiF/4F9yPT151fSgzPzS/ugdE6cT6Ep/humjE1IJfyaeEFrbQpOm7jseUQmVCmIq0ZcBPqN91MiYIdOyRaklgcoNHO3keBJFsxwnrR6XWARvkBO6/RT3whMp4= X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2520; 6:6V6ygs+EuSDh5wpVRvR352hjMo4qqsbMuRpNRv05PgRqP+asPHZ/UyjK3mmnK5BiOAE0eV9ISVJzmUnZ9vE7D7GyAnZ44DmtZMW4oFAtoQznEfX+LtJXfCoxX4+KXuM5VWJHwaodBsu/d7JcGL8Bp+Gurzxx5tV0EDajjD/f50FGTkyrIZxyC9eeOT0K6ddvV5+pDIDERiVTQzoXE5Q3pFlP71QK+jLgfLm+iRvDra2rzmSxlI6QHA6yd1ZzpAfZHrvFvyHnQyuI8Ow6Jn6TVhg5Wi35IZU1tzY1z+60BpWHd2/1TpJUA6TRoyML+zqUbAtwD959tGv1cnj0ERs39xJjCFsRaFRXPDBnZtq8i5M=; 5:CxSAgs97o9hiRItM0UqHnf0NYmZSWYyVCcwD5vQ4lWH2Ar5vJSJw9U5lo3z7zLlLZxvE3BjKKWbYnbq4dfUnB/16M8PimCVPjTQxjpC4szTNh2WJOyiyinU03MeDffYqQcohnmaYoUQ/I7TheFuzgdDCV7AJ0MsCGsxvIehSGRk=; 24:+JYhZBeVha7QiUNvgtNNArvKJhqNOl0jzHGvWb68ysv0kEMSD00kz/Q8UYBYSpG7uqZ8+QWh6LhDjc2U7JvwXosXuhJrfaSysl8XNKHgJ2E=; 7:EwuA5p6LeAe9X68ktqVkMUjlNSz5OU3tAm9oKHo4d3ZywmiqVpxaMFJd7FONE/CmTtSCpH4/EMNEzs/yoJ2DFT4QskEjf/rAx7yN7dHZQfXFJNhmQtr2MShZ0s+N40WD35o+bIaxzW4pyaLKDillRUy4ZbBAKkVae8yiv+RC7s+uzrA6ncstpfOGoGYIyEtjrGRNg3zzESa3Vj823P2LUW5JAQJ+JnwD4BAQzLKqoBfltgppTamlqxcAtE1/3Jhi SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2018 11:58:07.5517 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b0211245-d2b6-4115-a3b4-08d5707d8d47 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR07MB2520 Subject: [dpdk-dev] [PATCH] net/dpaa2: remove unused global variable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Checks
Context | Check | Description |
---|---|---|
ci/checkpatch | success | coding style OK |
ci/Intel-compilation | success | Compilation OK |
Commit Message
Jerin Jacob
Feb. 10, 2018, 11:57 a.m. UTC
Due to the missing __packed definition, compiler treating
it as as global variable.
#grep "Allocating common symbols" -A 100 build/app/testacl.map
__packed 0x8 /build/lib/librte_pmd_dpaa2.a(dpaa2_rxtx.o)
Fixes: a5fc38d422a7 ("net/dpaa2: support Rx packet parsing")
Cc: hemant.agrawal@nxp.com
Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
---
drivers/net/dpaa2/base/dpaa2_hw_dpni_annot.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
> -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jerin Jacob > Sent: Saturday, February 10, 2018 5:28 PM > To: dev@dpdk.org > Cc: Jerin Jacob <jerin.jacob@caviumnetworks.com>; Hemant Agrawal > <hemant.agrawal@nxp.com> > Subject: [dpdk-dev] [PATCH] net/dpaa2: remove unused global variable > Importance: High > > Due to the missing __packed definition, compiler treating it as as global variable. > > #grep "Allocating common symbols" -A 100 build/app/testacl.map > __packed 0x8 /build/lib/librte_pmd_dpaa2.a(dpaa2_rxtx.o) [Hemant] Which compiler, you mean you faced issue with testacl app? > > Fixes: a5fc38d422a7 ("net/dpaa2: support Rx packet parsing") > > Cc: hemant.agrawal@nxp.com > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com> > --- > drivers/net/dpaa2/base/dpaa2_hw_dpni_annot.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com> <snip>....
-----Original Message----- > Date: Sat, 10 Feb 2018 12:02:24 +0000 > From: Hemant Agrawal <hemant.agrawal@nxp.com> > To: Jerin Jacob <jerin.jacob@caviumnetworks.com>, "dev@dpdk.org" > <dev@dpdk.org> > Subject: RE: [dpdk-dev] [PATCH] net/dpaa2: remove unused global variable > > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jerin Jacob > > Sent: Saturday, February 10, 2018 5:28 PM > > To: dev@dpdk.org > > Cc: Jerin Jacob <jerin.jacob@caviumnetworks.com>; Hemant Agrawal > > <hemant.agrawal@nxp.com> > > Subject: [dpdk-dev] [PATCH] net/dpaa2: remove unused global variable > > Importance: High > > > > Due to the missing __packed definition, compiler treating it as as global variable. > > > > > #grep "Allocating common symbols" -A 100 build/app/testacl.map > > __packed 0x8 /build/lib/librte_pmd_dpaa2.a(dpaa2_rxtx.o) > > [Hemant] Which compiler, you mean you faced issue with testacl app? arm64 gcc. Not specific to testacl. We were getting minor performance regression (<1%) with l3fwd after the following change set. http://dpdk.org/dev/patchwork/patch/34709/ I don't think, the above change set directly has anything due to issue. I was chasing that issue and found that global variables has something due to with change.Most probably because it has indirect effect of changing the complete address generated in the binary and thus showing up some cached alignment related artifacts. > > > > > Fixes: a5fc38d422a7 ("net/dpaa2: support Rx packet parsing") > > > > Cc: hemant.agrawal@nxp.com > > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com> > > --- > > drivers/net/dpaa2/base/dpaa2_hw_dpni_annot.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com> > > <snip>....
> > Fixes: a5fc38d422a7 ("net/dpaa2: support Rx packet parsing") > > > > Cc: hemant.agrawal@nxp.com > > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com> > > --- > > drivers/net/dpaa2/base/dpaa2_hw_dpni_annot.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com> Applied, thanks
diff --git a/drivers/net/dpaa2/base/dpaa2_hw_dpni_annot.h b/drivers/net/dpaa2/base/dpaa2_hw_dpni_annot.h index 41931e858..779cdf2b2 100644 --- a/drivers/net/dpaa2/base/dpaa2_hw_dpni_annot.h +++ b/drivers/net/dpaa2/base/dpaa2_hw_dpni_annot.h @@ -37,7 +37,7 @@ struct dpaa2_fas { uint8_t ppid; __le16 ifpid; __le32 status; -} __packed; +} __attribute__((__packed__)); /** * HW Packet Annotation Register structures