[dpdk-dev] net/bonding: fix setting VLAN ID on slave ports
Checks
Commit Message
From: Chas Williams <chas3@att.com>
The pos returned is just the offset of the slab. You need to use this
to offset the bits in the slab.
Fixes: c771e4ef38 ("net/bonding: enable slave VLAN filter")
Cc: stable@dpdk.org
Signed-off-by: Chas Williams <chas3@att.com>
---
drivers/net/bonding/rte_eth_bond_api.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
Comments
On 4/3/2018 5:01 PM, Chas Williams wrote:
> From: Chas Williams<chas3@att.com>
>
> The pos returned is just the offset of the slab. You need to use this
> to offset the bits in the slab.
>
> Fixes: c771e4ef38 ("net/bonding: enable slave VLAN filter")
> Cc:stable@dpdk.org
>
> Signed-off-by: Chas Williams<chas3@att.com>
> ---
>
Acked-by: Radu Nicolau <radu.nicolau@intel.com>
<mailto:radu.nicolau@intel.com>
On 4/5/2018 12:06 PM, Radu Nicolau wrote:
>
> On 4/3/2018 5:01 PM, Chas Williams wrote:
>> From: Chas Williams<chas3@att.com>
>>
>> The pos returned is just the offset of the slab. You need to use this
>> to offset the bits in the slab.
>>
>> Fixes: c771e4ef38 ("net/bonding: enable slave VLAN filter")
>> Cc:stable@dpdk.org
>>
>> Signed-off-by: Chas Williams<chas3@att.com>
>> ---
>>
> Acked-by: Radu Nicolau <radu.nicolau@intel.com>
Applied to dpdk-next-net/master, thanks.
@@ -211,9 +211,12 @@ slave_vlan_filter_set(uint16_t bonded_port_id, uint16_t slave_port_id)
for (i = 0, mask = 1;
i < RTE_BITMAP_SLAB_BIT_SIZE;
i ++, mask <<= 1) {
- if (unlikely(slab & mask))
+ if (unlikely(slab & mask)) {
+ uint16_t vlan_id = pos + i;
+
res = rte_eth_dev_vlan_filter(slave_port_id,
- (uint16_t)pos, 1);
+ vlan_id, 1);
+ }
}
found = rte_bitmap_scan(internals->vlan_filter_bmp,
&pos, &slab);