[dpdk-dev,v2,2/5] net/virtio: use simple path for Tx even if Rx mergeable
Checks
Commit Message
Having Rx mergeable buffers feature enabled should not be
a reason to not use Tx simple path.
Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
---
drivers/net/virtio/virtio_ethdev.c | 1 -
1 file changed, 1 deletion(-)
Comments
On Wed, Jun 06, 2018 at 02:31:25PM +0200, Maxime Coquelin wrote:
> Having Rx mergeable buffers feature enabled should not be
> a reason to not use Tx simple path.
>
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> ---
> drivers/net/virtio/virtio_ethdev.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
> index bdc4f09d5..73e6d6b6b 100644
> --- a/drivers/net/virtio/virtio_ethdev.c
> +++ b/drivers/net/virtio/virtio_ethdev.c
> @@ -1949,7 +1949,6 @@ virtio_dev_configure(struct rte_eth_dev *dev)
> #endif
> if (vtpci_with_feature(hw, VIRTIO_NET_F_MRG_RXBUF)) {
> hw->use_simple_rx = 0;
> - hw->use_simple_tx = 0;
> }
Maybe it's better to also remove { and }.
Reviewed-by: Tiwei Bie <tiwei.bie@intel.com>
>
> if (rx_offloads & (DEV_RX_OFFLOAD_UDP_CKSUM |
> --
> 2.14.3
>
@@ -1949,7 +1949,6 @@ virtio_dev_configure(struct rte_eth_dev *dev)
#endif
if (vtpci_with_feature(hw, VIRTIO_NET_F_MRG_RXBUF)) {
hw->use_simple_rx = 0;
- hw->use_simple_tx = 0;
}
if (rx_offloads & (DEV_RX_OFFLOAD_UDP_CKSUM |