Message ID | 20180827123835.27531-1-jerin.jacob@caviumnetworks.com (mailing list archive) |
---|---|
State | Accepted, archived |
Delegated to: | Thomas Monjalon |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DCE4158FA; Mon, 27 Aug 2018 14:39:07 +0200 (CEST) Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0080.outbound.protection.outlook.com [104.47.33.80]) by dpdk.org (Postfix) with ESMTP id 949AF58CB for <dev@dpdk.org>; Mon, 27 Aug 2018 14:39:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p+qZXv+MsZPVT/r9v/myC7u1lsOy34pW6YHJI52YXe0=; b=TzoROno85P3JqNOBEAF6+I7GsD5wC39zXJuiCzlAp5kjo1kK5Mi9VlUjc9JyuSpa6m2oeVfIcGLptH0BHmHY2BIWlJISsJF3qCpjVX5aWRan6ti8vo9PZEqfMfYWwxRTvlo72pVNCURjanCNwR4dhI+vQZYrutVjoJ9de7Pj6zE= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from localhost.localdomain (115.113.156.3) by BYAPR07MB4998.namprd07.prod.outlook.com (2603:10b6:a03:5b::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1080.14; Mon, 27 Aug 2018 12:39:02 +0000 From: Jerin Jacob <jerin.jacob@caviumnetworks.com> To: dev@dpdk.org Cc: olivier.matz@6wind.com, Jerin Jacob <jerin.jacob@caviumnetworks.com> Date: Mon, 27 Aug 2018 18:08:35 +0530 Message-Id: <20180827123835.27531-1-jerin.jacob@caviumnetworks.com> X-Mailer: git-send-email 2.18.0 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [115.113.156.3] X-ClientProxiedBy: PN1PR0101CA0046.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00:c::32) To BYAPR07MB4998.namprd07.prod.outlook.com (2603:10b6:a03:5b::23) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c538dfd9-398d-47b4-d6db-08d60c1a1308 X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989137)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:BYAPR07MB4998; X-Microsoft-Exchange-Diagnostics: 1; BYAPR07MB4998; 3:7ip87WnV8EVTozan/qMYqbeoCjZhuLru0LrOeZfemFRPHuusg+mmGnHfgiL6nSp/EKtq86HuiEGwfuXKtzfzXGk9EiH5ICpdBYgpBCCztetfxEbJfWOusmo+OiBRMBGJrsUiMuzZjjlPVttjSGXIb+hwOwY/ogJVFhA5AhrZG/v+2vDSeH/Am/YmEvxbko3JnlYTWJNPfx4gFlTIOOUMv0oX80OELCxkEfwYA1qKxLIKWSYsaqZuUMagn/dpkqkD; 25:YkdRtywrBkNCpkmU6jxJ0MJfNG6HU58B7PR3ZlTP+NTK7LapWxFTE03bjcRfveVyv/sW/PNwvUzCiL41SPN+ojSEqpddepYNlj5fiQgkcdVQ20zUyqud1BPC6Na4sbQRGsm8JGWT62eRDC/bqhAfdCLwa7ZAT9CuK+p6qD6s3ZxTCJo6JMTaloU8g8WHBynKjU1jHVymbN2e5P4Vdkr6gY/mAtOFP8KGUpLnUjovNII/tpvBgmyrw9LAQDfFOfW7hMsHU5wyNTzsAREy+Eang7Lul6flrBnkOeUSj87kyKJoTemVn/xGwcilQSA1kNFgXU++WOeEYNQ3dHbu+5KvAA==; 31:6GjhfxMOA0kuFwsLXiC2JWQiPcx2iF2BFVhY8dkgMSBn3K0Xy33S0gaLJwao/axNZ9SIegS7y7mjQPyEn7I3Uipu9XxnS35r4EffWNHDtTS41Wo8gpUTdU0TbSnvJkf5iH471rHUmjRoYT7NHgFpfP74LImdfh1jWw0ZJyCg4LegPsS90oMJSRBV6prQjOGDQWsCqnaCds1cBdaCeHMni8CCnY86L+NVs5ZaelaD9u8= X-MS-TrafficTypeDiagnostic: BYAPR07MB4998: X-Microsoft-Exchange-Diagnostics: 1; BYAPR07MB4998; 20:aczSpMHo78lGR2aOJrp0t+Zxzx8cqLI5s22X99z+EOifX8BWKKLiUeStbqUbBliJDpu9pTCDru6xTYcCmr8C9GI4S7hVyLs6vPzwIEFgCB++JJq8Aewzn7iku1dbLaZ0lLpLk7wly/fTWRTwyQ27xwgWEpnlkjf4SwtNweDRA8WU7SjYQsVC1+KiIQOHOLaoYH1prlcTGINmVPyMKiZ51Np9N9qS0M8OLNkE5MCtZkxRskATZhZBsZcWhfACd/nxRg048i2HTD4nQDm1lVpW9x7a14tyW9uUvNPKIeO3GBkQL/PMW/aL0H6loRYa+o9WdVWAsfiXueynbORYkZT1oMfvJl8UOYJ5kT2eGgfZFYY+10R3ENZTVJDjmWptoha4H/wC1FJ1SildnEhLG78zor57sSSipvGmPDKLOsisyEw+TEl2NnimyJwZdpaBrwZRsYSswqtdTdjK5jbsqf0PfHp2NKdgcywS1Xa2DrzeQnu8fRWk3R6qjiFjlFCID6PyU97QxS2fvj6pI9P4m7GcZLNNqGTtZMdGI9JQTQqee//LXmmCWzkwPZk36rmB9ZGdDJf3hLS1zbVwVYRgVFpumNAYVxueAbdZm0TSXYCXxFI=; 4:779CdZFAwfQh569sDSfj09L0sx0U5q3gZHQNOV1Rx90XPcJYGnHyk8mzM4V9XfExiUsxzQQU2IBq30OvYbiLceIsGXtqi5DK5R7ubv0pM6bbqKP2UkpghehPFANVEJePj9M99qDm9d8kfQvmCWlvYkWKQsOmaYN/dx5C0L7jgFeQgcYKo8ZV0HC04R9KmisIRiCgOxDGID+LpJy/TPTIz0C2uFXiLNyZuL+Ci1ivGFflH9CJ0Vue3EZW5g/4GhMyTZw3iXOvSmKW+myx6zY5uA== X-Microsoft-Antispam-PRVS: <BYAPR07MB499872F8A3E1A17AF93E2CB2E30B0@BYAPR07MB4998.namprd07.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231311)(944501410)(52105095)(10201501046)(93006095)(3002001)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123558120)(20161123562045)(20161123564045)(201708071742011)(7699016); SRVR:BYAPR07MB4998; BCL:0; PCL:0; RULEID:; SRVR:BYAPR07MB4998; X-Forefront-PRVS: 07778E4001 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6069001)(366004)(396003)(39860400002)(376002)(136003)(346002)(199004)(189003)(2616005)(486006)(2906002)(50226002)(6512007)(3846002)(51416003)(6116002)(44832011)(52116002)(1857600001)(1076002)(25786009)(42882007)(8936002)(53936002)(4326008)(186003)(16526019)(478600001)(7736002)(305945005)(72206003)(16586007)(26005)(36756003)(6486002)(106356001)(105586002)(2351001)(81166006)(68736007)(81156014)(8676002)(6666003)(107886003)(6916009)(476003)(97736004)(956004)(50466002)(5660300001)(386003)(66066001)(48376002)(47776003)(55236004)(2361001)(6506007)(316002)(69590400005); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR07MB4998; H:localhost.localdomain; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BYAPR07MB4998; 23:PWO+rk6nlQZmyICdVMnQx7BNBsvaV1w/ABV1DELTy?= wmYBMRmo44XdoEAJrTe2SLEkh0mTcHqgkaz7jmZaXd8vCukcyIRiEoyH82Cd6R/eCUunIVS78sDgNVeDTCjUL95uBA7z2MX5vBrTYzyOUsMGMcTG3IDdDZ9/wTvbeM9vXz0nlzU9jesD69ddjmVhsRtePtzuKprNa/OQDwX77LNOWVL3si228MDAbS3a8y2SblMwcpoaM22u6T8o++7wCm/+G2dY+51raOVflPLAceuJte/Xexwz2H5DJpOq4SVXCbYjeFipzy/XivPRTqgsIieGJ1H7ySaHNt9Kenqmyn1YXyMfAqU9H3w9tSOvy64P3r8io9qJurOUOa5pM1EeqFICNgbDcY3+2INWY/54B1XyecxfhURbbTFzZvlnCGEGN/kmGRQf8HQphIeXIwp5KPp71DgLg7lmJPUxyRW4b2kYL0BejMoWirbrjFkxpo/mf3QyfLlrdkv+xqGOYhBz0lwxI0JMqzHTNtZb2v6npuIg0aqNgFK96W+9J7dLKF/pFeyGqozTjWyCZmXIlrhaKeUYp3TJZCJ0e6L0qtAX+UD3ij8qLQMNfchfiuFSCfYXMLU4owCp1+Mc4a56c9US0bh4uEkP/hwxE/O7d9lDf6QuPUWBPrEjyX7juVJHu6CwT6oWDAGA5McWOkFYmbMKdkV072e46gnLG003VmNI5VyovxUv1ZM/OkP/TftIarYz1K2Z50elf3YSrJ7LaeJ0n1tnLIhlM1lrOvfrOSTE6tuZhpaYirhflWKa8kcn1n+Ii0qFC2O5vqEc/SdffgRad8obnpWCFat69OLgUu85H2zColGAMq+golftpmsm+dYQvbscaC6BG3t361quyFd5Guf02RR61AEiL/xkWo4+xf7TKTnZdvlnDPROikJDBgAr32Prd+YsTzQYkzr9d/4aC1Qz2cFxb0ArnbaDQN14tvyiD8D+1kyJJYTeZls5rUT8bcA/XlHy2pfHk0cVorJGPVYxuWK6k7hGh+HjqlPTrywhNaJKn+Bc/BFCw55TA8m0XR0EYLbbdA3fnWzTrRlyI7NeqeYIXV0urcRf3D4b13JzwU98e2nEM4NE/TNPadK70iMGJ1iuj035PAWNessyL0pnpRxQBZ2aIq/oHNVhvm4br94dDZM+wDC7h3SQkK1TyvQGa2GCHLaxhkAVrBvImU3iILCW1PgF9Naj1595oObyf0UxCdnKZ4WWucWIL0Qp6UjPKpsZgyjVA7B3pvkj5RfP3l9hX8rqioXu76bMQdYK94BdQ3kvQEFKN/Rsa4gNnSSE2aAR2St0AnweG0QMeEQ X-Microsoft-Antispam-Message-Info: oCE7eiVivCEPyC9AePha4kUVtq44E83dKxXWj9+XPvUwil6hJ9zcRGerchJeAREyQq7/Xh/bhKyAzi/u2eYRVDjVvY11+xKL8/CVbNFrsMmZJokTSSUj/9YjpC6ZoSAl6AwhfZK428fCNDOByaqKRmmFTOT38wXbdegPu5H+hyU+8mSKUh1hUbdxy9N7BiTXMYUxPPef3pfzOr6fUOpwqskjFCIzQfVOE1vBBZEDtWJhEs7pW0pFEqDXaBuHFe1rqiRFaUTHaj8XoOHtreFgGzqPNz/pqYLpfbZLfWLaF2s9ePNrgWmIAZ6VR8ld+ChiQtyGe0P7vB9GIcIM8qql5RWo7CQOsicqYZaaW5v0PbI= X-Microsoft-Exchange-Diagnostics: 1; BYAPR07MB4998; 6:F6xGkeJendGLk2725uFdzQmLK/mVlaaxBVYkL/CUFRsB4tqC5041DSar8RLNnQuT3tfLeS/0LTWHcDb3WQ3DnvpMS7SljYnmWstEu/y2jUFhk5388GH1EXcTkOnSj3u5mT7NXO/i2qY8sFq07zAFejUIPzIV5eePcWax1QjPdsdB8AuM+SjwbiayeR2kqaOU0iaYqAPkGGV4YPxMc5OaXyJGa15Yl3Iqbl7/LVWbuU+mjXSttJM9XyHHdciUfVFaxve8r4Ye/yFgoSkJzvOlECSTz/Btjxdj1CwX9uV1/NfDTapg76/dkwd0wVwGWqF1JUSr+fYMRB1gJI0tYiZl9yD0LBGrs5fYKzf5Es6rkCOvsNnbOA05p3uWNZdeE6jukFjAEcEH1Z9wrih+Z+xqBDpNS/YUBWSCj/PyByYS1GSmGCEfskkFEY7kC6kBwS6T+jGDG49KCqWomJbAiiSlRg==; 5:iz8dwyVGO3C5k3+4EysyMHhT2jz9mVxa25QPvh7/WdrTSEMIS/bheBze5sDPZxloMEgcylHxUqmLlt2W+nwG7b8oEqHfKmXhvB8kD/tJ3MApvsiiDhGP6+wB4S6s/1oP2JnS1lrI1Du7R5ppIE1K32QxSPTMM0GCdbpiqCgccWE=; 7:lxsAR0ZNmHNEiJwVfrVZke8fIOEDIu+6ADd4bklpdNWR8N6KkNuepd2kKvUcucD7+YPjaKqewL0R5x9sYkDjtqDVx7Aqm87iAyPKy0hDePgoL9qiwDkZ7hIvYGbsBPUCSZiYjoBEyAYXnzPOQOOTgQT8G+fYcbSil7mIqrxCVyne2ngogKUeUQYt+AH8BzXOYQVgwdgBthTEfTyDsmD4TIP8gFH+S66UEM0ARyt6xK/T1mzqSJ8S3UYsYh5fhBNs SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Aug 2018 12:39:02.8119 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c538dfd9-398d-47b4-d6db-08d60c1a1308 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR07MB4998 Subject: [dpdk-dev] [PATCH] mbuf: add IGMP packet type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
mbuf: add IGMP packet type
|
|
Checks
Context | Check | Description |
---|---|---|
ci/checkpatch | success | coding style OK |
ci/Intel-compilation | success | Compilation OK |
Commit Message
Jerin Jacob
Aug. 27, 2018, 12:38 p.m. UTC
Add support for IGMP packet type.
Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
---
lib/librte_mbuf/rte_mbuf_ptype.c | 1 +
lib/librte_mbuf/rte_mbuf_ptype.h | 8 ++++++++
2 files changed, 9 insertions(+)
Comments
-----Original Message----- From: dev <dev-bounces@dpdk.org> On Behalf Of Jerin Jacob Sent: Monday, August 27, 2018 7:39 AM To: dev@dpdk.org Cc: olivier.matz@6wind.com; Jerin Jacob <jerin.jacob@caviumnetworks.com> Subject: [dpdk-dev] [PATCH] mbuf: add IGMP packet type Add support for IGMP packet type. Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com> --- lib/librte_mbuf/rte_mbuf_ptype.c | 1 + lib/librte_mbuf/rte_mbuf_ptype.h | 8 ++++++++ 2 files changed, 9 insertions(+) diff --git a/lib/librte_mbuf/rte_mbuf_ptype.c b/lib/librte_mbuf/rte_mbuf_ptype.c index d7835e283..b483a609d 100644 --- a/lib/librte_mbuf/rte_mbuf_ptype.c +++ b/lib/librte_mbuf/rte_mbuf_ptype.c @@ -47,6 +47,7 @@ const char *rte_get_ptype_l4_name(uint32_t ptype) case RTE_PTYPE_L4_SCTP: return "L4_SCTP"; case RTE_PTYPE_L4_ICMP: return "L4_ICMP"; case RTE_PTYPE_L4_NONFRAG: return "L4_NONFRAG"; + case RTE_PTYPE_L4_IGMP: return "L4_IGMP"; default: return "L4_UNKNOWN"; } } diff --git a/lib/librte_mbuf/rte_mbuf_ptype.h b/lib/librte_mbuf/rte_mbuf_ptype.h index 01acc66e2..00db3eeed 100644 --- a/lib/librte_mbuf/rte_mbuf_ptype.h +++ b/lib/librte_mbuf/rte_mbuf_ptype.h @@ -286,6 +286,14 @@ extern "C" { * | 'version'=6, 'next header'!=[6|17|44|132|1]> */ #define RTE_PTYPE_L4_NONFRAG 0x00000600 +/** + * IGMP (Internet Group Management Protocol) packet type. + * + * Packet format: + * <'ether type'=0x0800 + * | 'version'=4, 'protocol'=2, 'MF'=0, 'frag_offset'=0> */ +#define RTE_PTYPE_L4_IGMP 0x00000700 /** * Mask of layer 4 packet types. * It is used for outer packet for tunneling cases. -- 2.18.0 Acked-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
On 08/27/2018 03:38 PM, Jerin Jacob wrote: > Add support for IGMP packet type. > > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com> Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
On Mon, 27 Aug 2018 18:08:35 +0530 Jerin Jacob <jerin.jacob@caviumnetworks.com> wrote: > Add support for IGMP packet type. > > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com> Could you add logic to recoginize IGMP to the software packet type identification rte_net_get_ptype used by drivers that don't have hardware support. Also shouldn't this bit be part of RTE_PTYPE_L4_MASK?
-----Original Message----- > Date: Wed, 29 Aug 2018 08:31:10 -0700 > From: Stephen Hemminger <stephen@networkplumber.org> > To: Jerin Jacob <jerin.jacob@caviumnetworks.com> > Cc: dev@dpdk.org, olivier.matz@6wind.com > Subject: Re: [dpdk-dev] [PATCH] mbuf: add IGMP packet type > > External Email > > On Mon, 27 Aug 2018 18:08:35 +0530 > Jerin Jacob <jerin.jacob@caviumnetworks.com> wrote: > > > Add support for IGMP packet type. > > > > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com> > > Could you add logic to recoginize IGMP to the software packet type identification > rte_net_get_ptype used by drivers that don't have hardware support. If everyone agrees then I can do it as adding IGMP support will reduce the performance of rte_net_get_ptype() and most of the NIC may not need it. Opinions? > > Also shouldn't this bit be part of RTE_PTYPE_L4_MASK? The RTE_PTYPE_L4_MASK is 0x00000f00 so it is part it. Right? >
On Wed, 29 Aug 2018 21:29:05 +0530 Jerin Jacob <jerin.jacob@caviumnetworks.com> wrote: > -----Original Message----- > > Date: Wed, 29 Aug 2018 08:31:10 -0700 > > From: Stephen Hemminger <stephen@networkplumber.org> > > To: Jerin Jacob <jerin.jacob@caviumnetworks.com> > > Cc: dev@dpdk.org, olivier.matz@6wind.com > > Subject: Re: [dpdk-dev] [PATCH] mbuf: add IGMP packet type > > > > External Email > > > > On Mon, 27 Aug 2018 18:08:35 +0530 > > Jerin Jacob <jerin.jacob@caviumnetworks.com> wrote: > > > > > Add support for IGMP packet type. > > > > > > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com> > > > > Could you add logic to recoginize IGMP to the software packet type identification > > rte_net_get_ptype used by drivers that don't have hardware support. > > If everyone agrees then I can do it as adding IGMP support will reduce > the performance of rte_net_get_ptype() and most of the NIC may not need it. > > Opinions? > > > > > Also shouldn't this bit be part of RTE_PTYPE_L4_MASK? > > The RTE_PTYPE_L4_MASK is 0x00000f00 so it is part it. Right? Then you must add it to the software matcher since most drivers are advertising L4_MASK
On Wed, 29 Aug 2018 21:29:05 +0530 Jerin Jacob <jerin.jacob@caviumnetworks.com> wrote: > -----Original Message----- > > Date: Wed, 29 Aug 2018 08:31:10 -0700 > > From: Stephen Hemminger <stephen@networkplumber.org> > > To: Jerin Jacob <jerin.jacob@caviumnetworks.com> > > Cc: dev@dpdk.org, olivier.matz@6wind.com > > Subject: Re: [dpdk-dev] [PATCH] mbuf: add IGMP packet type > > > > External Email > > > > On Mon, 27 Aug 2018 18:08:35 +0530 > > Jerin Jacob <jerin.jacob@caviumnetworks.com> wrote: > > > > > Add support for IGMP packet type. > > > > > > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com> > > > > Could you add logic to recoginize IGMP to the software packet type identification > > rte_net_get_ptype used by drivers that don't have hardware support. > > If everyone agrees then I can do it as adding IGMP support will reduce > the performance of rte_net_get_ptype() and most of the NIC may not need it. Since IGMP is an IP protocol field and the code is already looking for TCP and UDP, how could adding another else slow it down in any observable way.
-----Original Message----- > Date: Wed, 29 Aug 2018 09:34:36 -0700 > From: Stephen Hemminger <stephen@networkplumber.org> > To: Jerin Jacob <jerin.jacob@caviumnetworks.com> > Cc: dev@dpdk.org, olivier.matz@6wind.com > Subject: Re: [dpdk-dev] [PATCH] mbuf: add IGMP packet type > > External Email > > On Wed, 29 Aug 2018 21:29:05 +0530 > Jerin Jacob <jerin.jacob@caviumnetworks.com> wrote: > > > -----Original Message----- > > > Date: Wed, 29 Aug 2018 08:31:10 -0700 > > > From: Stephen Hemminger <stephen@networkplumber.org> > > > To: Jerin Jacob <jerin.jacob@caviumnetworks.com> > > > Cc: dev@dpdk.org, olivier.matz@6wind.com > > > Subject: Re: [dpdk-dev] [PATCH] mbuf: add IGMP packet type > > > > > > External Email > > > > > > On Mon, 27 Aug 2018 18:08:35 +0530 > > > Jerin Jacob <jerin.jacob@caviumnetworks.com> wrote: > > > > > > > Add support for IGMP packet type. > > > > > > > > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com> > > > > > > Could you add logic to recoginize IGMP to the software packet type identification > > > rte_net_get_ptype used by drivers that don't have hardware support. > > > > If everyone agrees then I can do it as adding IGMP support will reduce > > the performance of rte_net_get_ptype() and most of the NIC may not need it. > > > > Opinions? > > > > > > > > Also shouldn't this bit be part of RTE_PTYPE_L4_MASK? > > > > The RTE_PTYPE_L4_MASK is 0x00000f00 so it is part it. Right? > > Then you must add it to the software matcher since most drivers are advertising L4_MASK Which driver returns .dev_supported_ptypes_get ethdev ops with L4_MASK? >
On Mon, Aug 27, 2018 at 06:08:35PM +0530, Jerin Jacob wrote: > Add support for IGMP packet type. > > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com> Acked-by: Olivier Matz <olivier.matz@6wind.com>
23/10/2018 11:20, Olivier Matz: > On Mon, Aug 27, 2018 at 06:08:35PM +0530, Jerin Jacob wrote: > > Add support for IGMP packet type. > > > > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com> > > Acked-by: Olivier Matz <olivier.matz@6wind.com> Applied, thanks
diff --git a/lib/librte_mbuf/rte_mbuf_ptype.c b/lib/librte_mbuf/rte_mbuf_ptype.c index d7835e283..b483a609d 100644 --- a/lib/librte_mbuf/rte_mbuf_ptype.c +++ b/lib/librte_mbuf/rte_mbuf_ptype.c @@ -47,6 +47,7 @@ const char *rte_get_ptype_l4_name(uint32_t ptype) case RTE_PTYPE_L4_SCTP: return "L4_SCTP"; case RTE_PTYPE_L4_ICMP: return "L4_ICMP"; case RTE_PTYPE_L4_NONFRAG: return "L4_NONFRAG"; + case RTE_PTYPE_L4_IGMP: return "L4_IGMP"; default: return "L4_UNKNOWN"; } } diff --git a/lib/librte_mbuf/rte_mbuf_ptype.h b/lib/librte_mbuf/rte_mbuf_ptype.h index 01acc66e2..00db3eeed 100644 --- a/lib/librte_mbuf/rte_mbuf_ptype.h +++ b/lib/librte_mbuf/rte_mbuf_ptype.h @@ -286,6 +286,14 @@ extern "C" { * | 'version'=6, 'next header'!=[6|17|44|132|1]> */ #define RTE_PTYPE_L4_NONFRAG 0x00000600 +/** + * IGMP (Internet Group Management Protocol) packet type. + * + * Packet format: + * <'ether type'=0x0800 + * | 'version'=4, 'protocol'=2, 'MF'=0, 'frag_offset'=0> + */ +#define RTE_PTYPE_L4_IGMP 0x00000700 /** * Mask of layer 4 packet types. * It is used for outer packet for tunneling cases.