| Message ID | 20181027164739.13110-1-jerin.jacob@caviumnetworks.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Delegated to: | akhil goyal |
| Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 96190559A; Sat, 27 Oct 2018 18:48:21 +0200 (CEST) Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0060.outbound.protection.outlook.com [104.47.41.60]) by dpdk.org (Postfix) with ESMTP id 131DE5592 for <dev@dpdk.org>; Sat, 27 Oct 2018 18:48:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1MN6ScYvpqWfqRAy3mUcy178Kg47UOEuT2L7s+nUOqc=; b=DZlCGFpkzbvs0bfA7ZPjiFaoS4jaGr7DzJvTfsWqOcTZSpedFb+7IFsGN7D1BD34U4Ybz4QYvrPWuLGwT7YbvzhWNlub4zHuOA+H5g5+rfNSorNZDroSa45pgD5eYBly9KNpQsZl2ZLFC9G36YUmVlMzrvsrdeS+fbSdLscF6v0= Received: from SN6PR07MB5008.namprd07.prod.outlook.com (52.135.121.74) by SN6PR07MB4607.namprd07.prod.outlook.com (52.135.76.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1273.18; Sat, 27 Oct 2018 16:48:17 +0000 Received: from SN6PR07MB5008.namprd07.prod.outlook.com ([fe80::913d:1a21:cb40:16de]) by SN6PR07MB5008.namprd07.prod.outlook.com ([fe80::913d:1a21:cb40:16de%3]) with mapi id 15.20.1273.025; Sat, 27 Oct 2018 16:48:17 +0000 From: Jerin Jacob <jerin.jacob@caviumnetworks.com> To: "dev@dpdk.org" <dev@dpdk.org>, Fiona Trahe <fiona.trahe@intel.com>, Pablo de Lara <pablo.de.lara.guarch@intel.com>, "Gupta, Ashish" <Ashish.Gupta@cavium.com> CC: "thomas@monjalon.net" <thomas@monjalon.net>, "Jacob, Jerin" <Jerin.JacobKollanukkaran@cavium.com> Thread-Topic: [dpdk-dev] [PATCH] compress/qat: fix build issue with clang 7.0.0 Thread-Index: AQHUbhTcptk0MRX4tECMgUqnhOhFcw== Date: Sat, 27 Oct 2018 16:48:17 +0000 Message-ID: <20181027164739.13110-1-jerin.jacob@caviumnetworks.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [122.178.242.38] x-clientproxiedby: SG2PR0302CA0019.apcprd03.prod.outlook.com (2603:1096:3:2::29) To SN6PR07MB5008.namprd07.prod.outlook.com (2603:10b6:805:ad::10) x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; SN6PR07MB4607; 6:RShYQZ9uCo8rI8gyrfqrhN5hfgG2aTOMJUYsvjAt/molO2gqvmFwi+F67xKKrOYc9zf2bakbotmAFTFg6zPBzNaeRl6zZIPtYnedBwNfaqzbJb1TC/5PNY6Nhk2+cunAyGeuoBhCEyn83VXBB5YwWhMfVakdSw+H1uf0iUMmdeRA8POpe0EZQspcRI/0rw6Diy1CHci8ECKC2NrWhVt4YjkPAEGeXf1cliYcNQcoLyzxpnDmcuZPUClrjfdNBv3fmgx5xW84m/LjE/pKZoFmL1rsdHhtkTpWkKumfS6fVlDVlWLAae7eLDEcelbv4LueW0PbJaDZ16wyhH0mAFOK5bNoW0/BWSx734501iu+Cb1JwqGznI4sTDKkTgI4KsAQFLYnkB52PJI62qQejxETzaLD0j8ASH/8uUfqcoi7krhQzII2OsWb28oGEubjba3g4eiXyn8girr8y9Vvj3zmhQ==; 5:xCumd24jm+ERIxtCi7lBtImclLPfFarAnJN9aUdI0KccUuR2YgxSP0+rlq+dYryQDfNbOdsBMvR902Ilu6iSIRw/P+CHunM4gw/WegifGxFALMkhz4RYrQGOCSNev4anQ8pBS3utNE6JLwPTUkKqSPy2evkKuBF2QUWOt7uS794=; 7:g8YaJI2/Lh1xJa3+dsm83C3NGhFfHYXVwXkKz/Q4qsNLhtVdLA6D80CDfFMZOto0wEDWQYjp1ar449Fpo/HT6fM+FUfa+FS7iF4MoM+ueEBtnkgAc8waMhFvtcefnF+dppudNjay4wAlRaTeEJk5zw== x-ms-office365-filtering-correlation-id: b25ccf14-09b1-4b60-e2ff-08d63c2bfe56 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:SN6PR07MB4607; x-ms-traffictypediagnostic: SN6PR07MB4607: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; x-microsoft-antispam-prvs: <SN6PR07MB46077D839D234E73E8ABF085E3F10@SN6PR07MB4607.namprd07.prod.outlook.com> x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(3231382)(944501410)(52105095)(10201501046)(3002001)(148016)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123560045)(20161123558120)(20161123564045)(201708071742011)(7699051)(76991095); SRVR:SN6PR07MB4607; BCL:0; PCL:0; RULEID:; SRVR:SN6PR07MB4607; x-forefront-prvs: 08381C729B x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(396003)(366004)(346002)(39860400002)(136003)(199004)(189003)(3846002)(6116002)(2501003)(1076002)(2906002)(66066001)(72206003)(14454004)(5250100002)(71200400001)(305945005)(2900100001)(7736002)(99286004)(575784001)(52116002)(386003)(6506007)(478600001)(71190400001)(1857600001)(256004)(14444005)(186003)(105586002)(6486002)(42882007)(36756003)(6436002)(106356001)(102836004)(26005)(8936002)(97736004)(486006)(4326008)(53936002)(6512007)(8676002)(316002)(81166006)(110136005)(54906003)(476003)(5660300001)(68736007)(81156014)(107886003)(2616005)(25786009); DIR:OUT; SFP:1101; SCL:1; SRVR:SN6PR07MB4607; H:SN6PR07MB5008.namprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: AcDd2e8bA2I5I+kMUsh1FoqtGsIhqcOERYkIla4vND6ZDC4Jekx29uTUf22RRrZGO98WRzJ7uMZQ2i+R9r7qi1k6S3QsLZYkatO21naHLl7kBX+AUUzNamnyzbUrtQ+pZPiCzOQIyWEFlw7526mtr/gnoXMzIARqRCQOifGK+n/tgh2tf5vRSj0FwX5DfU/1SAi0D5IcQseUyvWGjJXLemKZ2k+GHfvAU50u3+g6A5lkrgolyY4puOx/zzU2EosDzno4uKXi00/HdssadJD39HG8oMi8VpHsQx5O/B/qMk3CbmtuVwXS7Lf651vsLPUKEzdSfLNiCENGhfKtHoV1yW8bC8YKaLtXRKAxTk/OIic= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-Network-Message-Id: b25ccf14-09b1-4b60-e2ff-08d63c2bfe56 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2018 16:48:17.5966 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR07MB4607 Subject: [dpdk-dev] [PATCH] compress/qat: fix build issue with clang 7.0.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
| Series |
compress/qat: fix build issue with clang 7.0.0
|
|
Checks
| Context | Check | Description |
|---|---|---|
| ci/Intel-compilation | success | Compilation OK |
Commit Message
Jerin Jacob
Oct. 27, 2018, 4:48 p.m. UTC
QAT_NUM_BUFS_IN_IM_SGL defined as 1 the code access beyond
the first element.
error log:
/export/dpdk.org/drivers/compress/qat/qat_comp_pmd.c:214:3:
error: array index 1 is past the end of the array
(which contains 1 element) [-Werror,-Warray-bounds]
sgl->buffers[1].addr = mz_start_phys + offset_of_flat_buffs +
Fixes: a124830a6f00 ("compress/qat: enable dynamic huffman encoding")
Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
---
drivers/compress/qat/qat_comp.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Hi Jerin, > -----Original Message----- > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] > Sent: Saturday, October 27, 2018 9:48 AM > To: dev@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>; De Lara Guarch, Pablo > <pablo.de.lara.guarch@intel.com>; Gupta, Ashish <Ashish.Gupta@cavium.com> > Cc: thomas@monjalon.net; Jacob, Jerin <Jerin.JacobKollanukkaran@cavium.com> > Subject: [dpdk-dev] [PATCH] compress/qat: fix build issue with clang 7.0.0 > > QAT_NUM_BUFS_IN_IM_SGL defined as 1 the code access beyond > the first element. > > error log: > /export/dpdk.org/drivers/compress/qat/qat_comp_pmd.c:214:3: > error: array index 1 is past the end of the array > (which contains 1 element) [-Werror,-Warray-bounds] > sgl->buffers[1].addr = mz_start_phys + offset_of_flat_buffs + > > Fixes: a124830a6f00 ("compress/qat: enable dynamic huffman encoding") > > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com> > --- > drivers/compress/qat/qat_comp.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/compress/qat/qat_comp.h b/drivers/compress/qat/qat_comp.h > index 99a4462eb..24d0d9cb4 100644 > --- a/drivers/compress/qat/qat_comp.h > +++ b/drivers/compress/qat/qat_comp.h > @@ -17,7 +17,7 @@ > > #define QAT_64_BYTE_ALIGN_MASK (~0x3f) > #define QAT_64_BYTE_ALIGN (64) > -#define QAT_NUM_BUFS_IN_IM_SGL 1 > +#define QAT_NUM_BUFS_IN_IM_SGL 2 [Fiona] Thanks for this. I'm surprised gcc didn't give a warning. However, setting to 2 causes issues on some platforms, which was why we reverted to 1 in an earlier iteration. So Nack I'll send a different patch to fix. > > #define ERR_CODE_QAT_COMP_WRONG_FW -99 > > -- > 2.19.1
diff --git a/drivers/compress/qat/qat_comp.h b/drivers/compress/qat/qat_comp.h index 99a4462eb..24d0d9cb4 100644 --- a/drivers/compress/qat/qat_comp.h +++ b/drivers/compress/qat/qat_comp.h @@ -17,7 +17,7 @@ #define QAT_64_BYTE_ALIGN_MASK (~0x3f) #define QAT_64_BYTE_ALIGN (64) -#define QAT_NUM_BUFS_IN_IM_SGL 1 +#define QAT_NUM_BUFS_IN_IM_SGL 2 #define ERR_CODE_QAT_COMP_WRONG_FW -99