[v2] compressdev: add feature flag to specify where processing is done
Checks
Commit Message
A new device feature flag, RTE_COMPDEV_FF_OP_DONE_IN_DEQUEUE
is added. A PMD should set this if the bulk of the
processing is done during the dequeue. It should leave it
cleared if the bulk of the processing is done during the
enqueue (default).
Applications can use this as a hint for tuning.
Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
---
lib/librte_compressdev/rte_compressdev.c | 2 ++
lib/librte_compressdev/rte_compressdev.h | 6 ++++++
2 files changed, 8 insertions(+)
Comments
>-----Original Message-----
>From: dev <dev-bounces@dpdk.org> On Behalf Of Fiona Trahe
>Sent: 17 January 2019 23:06
>To: dev@dpdk.org
>Cc: pablo.de.lara.guarch@intel.com; fiona.trahe@intel.com; akhil.goyal@nxp.com; paul.e.luse@intel.com
>Subject: [dpdk-dev] [PATCH v2] compressdev: add feature flag to specify where processing is done
>
>External Email
>
>A new device feature flag, RTE_COMPDEV_FF_OP_DONE_IN_DEQUEUE
>is added. A PMD should set this if the bulk of the
>processing is done during the dequeue. It should leave it
>cleared if the bulk of the processing is done during the
>enqueue (default).
>Applications can use this as a hint for tuning.
>
>Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
Acked-by: Shally Verma <shally.verma@marvell.com>
Thanks
Shally
On 2/20/2019 9:30 PM, Shally Verma wrote:
>
>> -----Original Message-----
>> From: dev <dev-bounces@dpdk.org> On Behalf Of Fiona Trahe
>> Sent: 17 January 2019 23:06
>> To: dev@dpdk.org
>> Cc: pablo.de.lara.guarch@intel.com; fiona.trahe@intel.com; akhil.goyal@nxp.com; paul.e.luse@intel.com
>> Subject: [dpdk-dev] [PATCH v2] compressdev: add feature flag to specify where processing is done
>>
>> External Email
>>
>> A new device feature flag, RTE_COMPDEV_FF_OP_DONE_IN_DEQUEUE
>> is added. A PMD should set this if the bulk of the
>> processing is done during the dequeue. It should leave it
>> cleared if the bulk of the processing is done during the
>> enqueue (default).
>> Applications can use this as a hint for tuning.
>>
>> Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
> Acked-by: Shally Verma <shally.verma@marvell.com>
>
> Thanks
> Shally
Applied to dpdk-next-crypto
Thanks.
@@ -66,6 +66,8 @@ rte_compressdev_get_feature_name(uint64_t flag)
return "CPU_AVX512";
case RTE_COMPDEV_FF_CPU_NEON:
return "CPU_NEON";
+ case RTE_COMPDEV_FF_OP_DONE_IN_DEQUEUE:
+ return "OP_DONE_IN_DEQ";
default:
return NULL;
}
@@ -73,6 +73,12 @@ rte_compressdev_capability_get(uint8_t dev_id,
/**< Utilises CPU SIMD AVX512 instructions */
#define RTE_COMPDEV_FF_CPU_NEON (1ULL << 5)
/**< Utilises CPU NEON instructions */
+#define RTE_COMPDEV_FF_OP_DONE_IN_DEQUEUE (1ULL << 6)
+/**< A PMD should set this if the bulk of the
+ * processing is done during the dequeue. It should leave it
+ * cleared if the processing is done during the enqueue (default).
+ * Applications can use this as a hint for tuning.
+ */
/**
* Get the name of a compress device feature flag.