diff mbox series

[v2,1/3] cryptodev: add result field to mod exp and inverse operations

Message ID 20190208111338.4544-2-arkadiuszx.kusztal@intel.com (mailing list archive)
State Accepted, archived
Delegated to: akhil goyal
Headers
Series crypotodev: add result field to modular operations |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Arkadiusz Kusztal Feb. 8, 2019, 11:13 a.m. UTC 
  This commit adds result field to be used when modular exponentiation or
modular multiplicative inverse operation is used

Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
---
 lib/librte_cryptodev/rte_crypto_asym.h | 10 ++++++++++
 1 file changed, 10 insertions(+)

Comments

Shally Verma Feb. 12, 2019, 10:55 a.m. UTC | #1 
>-----Original Message-----
>From: Arek Kusztal <arkadiuszx.kusztal@intel.com>
>Sent: 08 February 2019 16:44
>To: dev@dpdk.org
>Cc: akhil.goyal@nxp.com; fiona.trahe@intel.com; shally.verma@caviumnetworks.com; Arek Kusztal <arkadiuszx.kusztal@intel.com>
>Subject: [PATCH v2 1/3] cryptodev: add result field to mod exp and inverse operations
>
>External Email
>
>This commit adds result field to be used when modular exponentiation or
>modular multiplicative inverse operation is used
>
>Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
>---
Acked-by: Shally Verma <shallyv@marvell.com>

> lib/librte_cryptodev/rte_crypto_asym.h | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
>diff --git a/lib/librte_cryptodev/rte_crypto_asym.h b/lib/librte_cryptodev/rte_crypto_asym.h
>index 0a50cd5..991263f 100644
>--- a/lib/librte_cryptodev/rte_crypto_asym.h
>+++ b/lib/librte_cryptodev/rte_crypto_asym.h
>@@ -339,6 +339,16 @@ struct rte_crypto_mod_op_param {
>         * be relatively prime to modulus in corresponding Modular
>         * Multiplicative Inverse rte_crypto_modinv_xform
>         */
>+
>+       rte_crypto_param result;
>+       /**<
>+        * Pointer to the result of modular exponentiation/multiplicative inverse
>+        * data in octet-string network byte order format.
>+        *
>+        * This field shall be big enough to hold the result of Modular
>+        * Exponentiation or Modular Multplicative Inverse
>+        * (bigger or equal to length of modulus)
>+        */
> };
>
> /**
>--
>2.1.0
Akhil Goyal Feb. 28, 2019, 9:59 a.m. UTC | #2 
On 2/12/2019 4:25 PM, Shally Verma wrote:
>
>> -----Original Message-----
>> From: Arek Kusztal <arkadiuszx.kusztal@intel.com>
>> Sent: 08 February 2019 16:44
>> To: dev@dpdk.org
>> Cc: akhil.goyal@nxp.com; fiona.trahe@intel.com; shally.verma@caviumnetworks.com; Arek Kusztal <arkadiuszx.kusztal@intel.com>
>> Subject: [PATCH v2 1/3] cryptodev: add result field to mod exp and inverse operations
>>
>> External Email
>>
>> This commit adds result field to be used when modular exponentiation or
>> modular multiplicative inverse operation is used
>>
>> Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
>> ---
> Acked-by: Shally Verma <shallyv@marvell.com>
>
>> lib/librte_cryptodev/rte_crypto_asym.h | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>>
>> diff --git a/lib/librte_cryptodev/rte_crypto_asym.h b/lib/librte_cryptodev/rte_crypto_asym.h
>> index 0a50cd5..991263f 100644
>> --- a/lib/librte_cryptodev/rte_crypto_asym.h
>> +++ b/lib/librte_cryptodev/rte_crypto_asym.h
>> @@ -339,6 +339,16 @@ struct rte_crypto_mod_op_param {
>>          * be relatively prime to modulus in corresponding Modular
>>          * Multiplicative Inverse rte_crypto_modinv_xform
>>          */
>> +
>> +       rte_crypto_param result;
ABI breakage??
Do we have a deprecation notice?
>> +       /**<
>> +        * Pointer to the result of modular exponentiation/multiplicative inverse
>> +        * data in octet-string network byte order format.
>> +        *
>> +        * This field shall be big enough to hold the result of Modular
>> +        * Exponentiation or Modular Multplicative Inverse
>> +        * (bigger or equal to length of modulus)
>> +        */
>> };
>>
>> /**
>> --
>> 2.1.0
Arkadiusz Kusztal Feb. 28, 2019, 10:44 a.m. UTC | #3 
Hi Akhil,

> -----Original Message-----
> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
> Sent: Thursday, February 28, 2019 10:59 AM
> To: Shally Verma <shallyv@marvell.com>; Kusztal, ArkadiuszX
> <arkadiuszx.kusztal@intel.com>; dev@dpdk.org
> Cc: Trahe, Fiona <fiona.trahe@intel.com>;
> shally.verma@caviumnetworks.com
> Subject: Re: [dpdk-dev] [PATCH v2 1/3] cryptodev: add result field to mod
> exp and inverse operations
> 
> 
> 
> On 2/12/2019 4:25 PM, Shally Verma wrote:
> >
> >> -----Original Message-----
> >> From: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> >> Sent: 08 February 2019 16:44
> >> To: dev@dpdk.org
> >> Cc: akhil.goyal@nxp.com; fiona.trahe@intel.com;
> >> shally.verma@caviumnetworks.com; Arek Kusztal
> >> <arkadiuszx.kusztal@intel.com>
> >> Subject: [PATCH v2 1/3] cryptodev: add result field to mod exp and
> >> inverse operations
> >>
> >> External Email
> >>
> >> This commit adds result field to be used when modular exponentiation
> >> or modular multiplicative inverse operation is used
> >>
> >> Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> >> ---
> > Acked-by: Shally Verma <shallyv@marvell.com>
> >
> >> lib/librte_cryptodev/rte_crypto_asym.h | 10 ++++++++++
> >> 1 file changed, 10 insertions(+)
> >>
> >> diff --git a/lib/librte_cryptodev/rte_crypto_asym.h
> >> b/lib/librte_cryptodev/rte_crypto_asym.h
> >> index 0a50cd5..991263f 100644
> >> --- a/lib/librte_cryptodev/rte_crypto_asym.h
> >> +++ b/lib/librte_cryptodev/rte_crypto_asym.h
> >> @@ -339,6 +339,16 @@ struct rte_crypto_mod_op_param {
> >>          * be relatively prime to modulus in corresponding Modular
> >>          * Multiplicative Inverse rte_crypto_modinv_xform
> >>          */
> >> +
> >> +       rte_crypto_param result;
> ABI breakage??
> Do we have a deprecation notice?
Is not asymmetric crypto API still experimental? Do we have then add deprecation notice?

> >> +       /**<
> >> +        * Pointer to the result of modular exponentiation/multiplicative
> inverse
> >> +        * data in octet-string network byte order format.
> >> +        *
> >> +        * This field shall be big enough to hold the result of Modular
> >> +        * Exponentiation or Modular Multplicative Inverse
> >> +        * (bigger or equal to length of modulus)
> >> +        */
> >> };
> >>
> >> /**
> >> --
> >> 2.1.0

Thanks,
Arek
Akhil Goyal Feb. 28, 2019, 10:52 a.m. UTC | #4 
Hi Arek,

On 2/28/2019 4:14 PM, Kusztal, ArkadiuszX wrote:
> Hi Akhil,
>
>> -----Original Message-----
>> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
>> Sent: Thursday, February 28, 2019 10:59 AM
>> To: Shally Verma <shallyv@marvell.com>; Kusztal, ArkadiuszX
>> <arkadiuszx.kusztal@intel.com>; dev@dpdk.org
>> Cc: Trahe, Fiona <fiona.trahe@intel.com>;
>> shally.verma@caviumnetworks.com
>> Subject: Re: [dpdk-dev] [PATCH v2 1/3] cryptodev: add result field to mod
>> exp and inverse operations
>>
>>
>>
>> On 2/12/2019 4:25 PM, Shally Verma wrote:
>>>> -----Original Message-----
>>>> From: Arek Kusztal <arkadiuszx.kusztal@intel.com>
>>>> Sent: 08 February 2019 16:44
>>>> To: dev@dpdk.org
>>>> Cc: akhil.goyal@nxp.com; fiona.trahe@intel.com;
>>>> shally.verma@caviumnetworks.com; Arek Kusztal
>>>> <arkadiuszx.kusztal@intel.com>
>>>> Subject: [PATCH v2 1/3] cryptodev: add result field to mod exp and
>>>> inverse operations
>>>>
>>>> External Email
>>>>
>>>> This commit adds result field to be used when modular exponentiation
>>>> or modular multiplicative inverse operation is used
>>>>
>>>> Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
>>>> ---
>>> Acked-by: Shally Verma <shallyv@marvell.com>
>>>
>>>> lib/librte_cryptodev/rte_crypto_asym.h | 10 ++++++++++
>>>> 1 file changed, 10 insertions(+)
>>>>
>>>> diff --git a/lib/librte_cryptodev/rte_crypto_asym.h
>>>> b/lib/librte_cryptodev/rte_crypto_asym.h
>>>> index 0a50cd5..991263f 100644
>>>> --- a/lib/librte_cryptodev/rte_crypto_asym.h
>>>> +++ b/lib/librte_cryptodev/rte_crypto_asym.h
>>>> @@ -339,6 +339,16 @@ struct rte_crypto_mod_op_param {
>>>>           * be relatively prime to modulus in corresponding Modular
>>>>           * Multiplicative Inverse rte_crypto_modinv_xform
>>>>           */
>>>> +
>>>> +       rte_crypto_param result;
>> ABI breakage??
>> Do we have a deprecation notice?
> Is not asymmetric crypto API still experimental? Do we have then add deprecation notice?
sorry I missed that. Actually I did not see anything tagged as 
EXPERIMENTAL in rte_crypto_asym.h. Probably it should be mentioned at 
the top of the file as it is mentioned in other files which are 
experimental.
>
>>>> +       /**<
>>>> +        * Pointer to the result of modular exponentiation/multiplicative
>> inverse
>>>> +        * data in octet-string network byte order format.
>>>> +        *
>>>> +        * This field shall be big enough to hold the result of Modular
>>>> +        * Exponentiation or Modular Multplicative Inverse
>>>> +        * (bigger or equal to length of modulus)
>>>> +        */
>>>> };
>>>>
>>>> /**
>>>> --
>>>> 2.1.0
> Thanks,
> Arek
diff mbox series

Patch

diff --git a/lib/librte_cryptodev/rte_crypto_asym.h b/lib/librte_cryptodev/rte_crypto_asym.h
index 0a50cd5..991263f 100644
--- a/lib/librte_cryptodev/rte_crypto_asym.h
+++ b/lib/librte_cryptodev/rte_crypto_asym.h
@@ -339,6 +339,16 @@  struct rte_crypto_mod_op_param {
 	 * be relatively prime to modulus in corresponding Modular
 	 * Multiplicative Inverse rte_crypto_modinv_xform
 	 */
+
+	rte_crypto_param result;
+	/**<
+	 * Pointer to the result of modular exponentiation/multiplicative inverse
+	 * data in octet-string network byte order format.
+	 *
+	 * This field shall be big enough to hold the result of Modular
+	 * Exponentiation or Modular Multplicative Inverse
+	 * (bigger or equal to length of modulus)
+	 */
 };
 
 /**