[v2] devtools: select patches to check with git range
Checks
Commit Message
Rather than default to origin/master.., it can be handy to choose the
range you want to check.
Example on a branch rebased on next-net:
Before:
[dmarchan@dmarchan dpdk]$ ./devtools/checkpatches.sh
...
...
67/69 valid patches
After:
[dmarchan@dmarchan dpdk]$ ./devtools/checkpatches.sh -r next-net/master..
3/3 valid patches
Signed-off-by: David Marchand <david.marchand@redhat.com>
Acked-by: Thomas Monjalon <thomas@monjalon.net>
---
devtools/checkpatches.sh | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
---
Changelog since v1:
- fixed usage string to reflect the new option is exclusive to other
options that select patches (tu clair, Thomas)
Comments
10/05/2019 09:49, David Marchand:
> Rather than default to origin/master.., it can be handy to choose the
> range you want to check.
>
> Example on a branch rebased on next-net:
>
> Before:
> [dmarchan@dmarchan dpdk]$ ./devtools/checkpatches.sh
> ...
> ...
> 67/69 valid patches
>
> After:
> [dmarchan@dmarchan dpdk]$ ./devtools/checkpatches.sh -r next-net/master..
>
> 3/3 valid patches
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> Acked-by: Thomas Monjalon <thomas@monjalon.net>
Applied, thanks
@@ -44,13 +44,14 @@ trap "clean_tmp_files" INT
print_usage () {
cat <<- END_OF_HELP
- usage: $(basename $0) [-q] [-v] [-nX|patch1 [patch2] ...]]
+ usage: $(basename $0) [-q] [-v] [-nX|-r range|patch1 [patch2] ...]]
Run Linux kernel checkpatch.pl with DPDK options.
The environment variable DPDK_CHECKPATCH_PATH must be set.
The patches to check can be from stdin, files specified on the command line,
- or latest git commits limited with -n option (default limit: origin/master).
+ latest git commits limited with -n option, or commits in the git range
+ specified with -r option (default: "origin/master..").
END_OF_HELP
}
@@ -79,12 +80,14 @@ check_forbidden_additions() { # <patch>
}
number=0
+range='origin/master..'
quiet=false
verbose=false
-while getopts hn:qv ARG ; do
+while getopts hn:qr:v ARG ; do
case $ARG in
n ) number=$OPTARG ;;
q ) quiet=true ;;
+ r ) range=$OPTARG ;;
v ) verbose=true ;;
h ) print_usage ; exit 0 ;;
? ) print_usage ; exit 1 ;;
@@ -172,7 +175,7 @@ elif [ ! -t 0 ] ; then # stdin
check '' '' "$subject"
else
if [ $number -eq 0 ] ; then
- commits=$(git rev-list --reverse origin/master..)
+ commits=$(git rev-list --reverse $range)
else
commits=$(git rev-list --reverse --max-count=$number HEAD)
fi