net/softnic: remove trace of legacy "linuxapp"

Message ID 1560758067-3393-1-git-send-email-david.marchand@redhat.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers
Series net/softnic: remove trace of legacy "linuxapp" |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/intel-Performance-Testing success Performance Testing PASS
ci/Intel-compilation success Compilation OK

Commit Message

David Marchand June 17, 2019, 7:54 a.m. UTC
  This check on Linux environment has been added at a time when we already
had switched to using the boolean RTE_EXEC_ENV_LINUXAPP.
It was then missed when converting to RTE_EXEC_ENV_LINUX.

Fixes: 7709a63bf178 ("net/softnic: add connection agent")
Fixes: 742bde12f3bd ("build/linux: rename macro from LINUXAPP to LINUX")
Cc: stable@dpdk.org

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
If we backport this to 18.11, the fix is to switch to
RTE_EXEC_ENV_LINUXAPP.

---
 drivers/net/softnic/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Ferruh Yigit June 25, 2019, 5:16 p.m. UTC | #1
On 6/17/2019 8:54 AM, David Marchand wrote:
> This check on Linux environment has been added at a time when we already
> had switched to using the boolean RTE_EXEC_ENV_LINUXAPP.
> It was then missed when converting to RTE_EXEC_ENV_LINUX.
> 
> Fixes: 7709a63bf178 ("net/softnic: add connection agent")
> Fixes: 742bde12f3bd ("build/linux: rename macro from LINUXAPP to LINUX")
> Cc: stable@dpdk.org
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied to dpdk-next-net/master, thanks.
  

Patch

diff --git a/drivers/net/softnic/Makefile b/drivers/net/softnic/Makefile
index 64885dd..71cfd45 100644
--- a/drivers/net/softnic/Makefile
+++ b/drivers/net/softnic/Makefile
@@ -45,7 +45,7 @@  SRCS-$(CONFIG_RTE_LIBRTE_PMD_SOFTNIC) += conn.c
 #
 SYMLINK-y-include += rte_eth_softnic.h
 
-ifneq ($(CONFIG_RTE_EXEC_ENV),"linuxapp")
+ifneq ($(CONFIG_RTE_EXEC_ENV_LINUX),y)
 $(info Softnic PMD can only operate in a linux environment, \
 please change the definition of the RTE_TARGET environment variable)
 all: